Remove cheets_NativeCrash (part of autotest-tests-cheets) libstdc++ dependency |
||
Issue descriptioncheets_NativeCrash is built as a 32-bit binary in ChromeOS. As a result, it needs to be built with libstdc++ since we do not plan to ship a 32-bit libc++ library. Most of the code in cheets_nativeCrash is C and C++ usage appears to be limited to use of iostream cout, cerr etc. So there is a good chance that these uses can be replaced by C functions. This should remove the requirement for linking with libstdc++.
,
Jan 27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/57d20d124d4d0a2bd2e20abad8aa96c2d6ba2027 commit 57d20d124d4d0a2bd2e20abad8aa96c2d6ba2027 Author: Manoj Gupta <manojgupta@google.com> Date: Sat Jan 27 04:54:11 2018
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2cc1786fb52b6c5e2d5666da710ea8db7724ad0d commit 2cc1786fb52b6c5e2d5666da710ea8db7724ad0d Author: Manoj Gupta <manojgupta@google.com> Date: Sat Jan 27 04:54:10 2018 crasher: Rewrite to avoid C++ STL dependencies. crasher.cc is mostly C code but was using iostream to write to cerr. Use fprintf instead so that it can be linked without using C++ libraries. This removes one of the last libstdc++ dependencies. CQ-DEPEND=CL:*555608 BUG= chromium:803280 TEST=cheets_NativeCrash builds. logging_UserCrash passed. Change-Id: I9c003cc1ba15218a761a451112f061ac3acfc929 Reviewed-on: https://chromium-review.googlesource.com/888320 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2cc1786fb52b6c5e2d5666da710ea8db7724ad0d/client/cros/crash/user_crash_test.py [modify] https://crrev.com/2cc1786fb52b6c5e2d5666da710ea8db7724ad0d/client/cros/crash/crasher/crasher.cc
,
Jan 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by manojgupta@chromium.org
, Jan 26 2018