New issue
Advanced search Search tips

Issue 803275 link

Starred by 1 user
Status: Fixed
Owner:
jfernan...@igalia.com
Closed: Jan 2018
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-align] Incorrect computed value for 'baseline' and 'first baseline' values

Project Member Reported by jfernan...@igalia.com, Jan 18 2018 
In M65 we have the following computed values:

  - baseline -> baseline
  - first baseline -> baseline

According to the last draft of the spec, we should have the following computed values:

  - baseline -> first baseline
  - first baseline -> first baseline

https://drafts.csswg.org/css-align-3/#typedef-baseline-position

Comment 1 by jfernan...@igalia.com, Jan 24 2018

Components: Blink>CSS
FF has a similar bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1432654

Comment 2 by mikelawther@chromium.org, Jan 24 2018

Labels: Hotlist-Interop
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948b8dee181da1bd431f91229f05e73e3b423490

commit 948b8dee181da1bd431f91229f05e73e3b423490
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Mon Jan 29 11:56:58 2018

[css-align] justify-content doesn't allow <baseline-position> values

The CSS WG has resolved that it doesn't make sense to define Baseline
Content-Alignment in the inline/main axis.

https://github.com/w3c/csswg-drafts/issues/1184

The spec has been updated so that <baseline-postion> is not valid for
the 'justify-content' property's syntax. This CL updates our parsing
logic to match the new spec, including the parsing logic of the
place-content shorthand.

Additionally, this CL updates the computed value of the
<baseline-position> values to match other browsers.

We don't implement support for <baseline-position> values in the
Content Distribution properties (align-content and justify-content),
so I don't expect this change to break content of sites using the CSS
Box Alignment feature.

Bug:  802248 ,  803275 
Change-Id: I0d3b1b7e7dd28552ee7e131bfe09ef7198565283
Reviewed-on: https://chromium-review.googlesource.com/882362
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532400}
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-align-content-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-align-content-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/parse-justify-content-004.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-002.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-004.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-006.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-align-items-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-align-items-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-002.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-004.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-006.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/resources/alignment-parsing-utils.js
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-align-self-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-align-self-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-justify-self-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/parse-justify-self-003.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-001.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-002.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-004.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-006.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/fast/alignment/parse-align-content.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/948b8dee181da1bd431f91229f05e73e3b423490/third_party/WebKit/Source/core/css/properties/longhands/JustifyContentCustom.cpp

Comment 4 by jfernandez@chromium.org, Jan 29 2018

Status: Fixed (was: Started)
This issue should be FIXED now.
►

Sign in to add a comment