New issue
Advanced search Search tips

Issue 803242 link

Starred by 1 user
Status: Assigned
Owner:
mek@chromium.org
Cc:
jbroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove blink::MessagePortChannel

Project Member Reported by mek@chromium.org, Jan 17 2018 
Currently the only remaining usage of this class is as a ref-counted ScopedMessagePipeHandle container; actual MessagePort implementations in blink and android code just use the handle directly to write/read messages. So we should eliminate this class entirely and replace its usage with plain ScopedMessagePipeHandle where possible (pipes being passed across IPC might be a bit tricky, but should be possibly somehow).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1895b89cb50d449091e3c312602818082a91a50c

commit 1895b89cb50d449091e3c312602818082a91a50c
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jan 18 16:02:47 2018

Mostly gut the MessagePortChannel implementation.

At this point the class is only used as a ref-counted container of a
MessagePipeHandle, so remove the rest of the implementation. Ideally all
usage of this class should just be replaced with a simple
MessagePipeHandle, but that is a bit more complicated due to how
widespread instances are passed around, so that'll be done in future
CLs.

Bug: 803242
Change-Id: I6c316e6a8b210e010df8e4a115c6d16dba90799a
Reviewed-on: https://chromium-review.googlesource.com/871840
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530152}
[modify] https://crrev.com/1895b89cb50d449091e3c312602818082a91a50c/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/1895b89cb50d449091e3c312602818082a91a50c/third_party/WebKit/common/message_port/message_port_channel.cc
[modify] https://crrev.com/1895b89cb50d449091e3c312602818082a91a50c/third_party/WebKit/common/message_port/message_port_channel.h
►

Sign in to add a comment