Replace breakpoint-manager.js test with useful set of non-mock-based tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d4ff09053af834ff69b03372e83ac2dcc6e9e57 commit 6d4ff09053af834ff69b03372e83ac2dcc6e9e57 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jan 18 00:44:51 2018 [DevTools] remove breakpoint-manager test, part 1 Tests set-breakpoint in separate test without using mocks. + fixed a bug - we used to request inline decorations for disabled breakpoints as well. R=dgozman@chromium.org Bug: chromium:803241 Change-Id: I8cd262016228354accb16e84298524eef2487def Reviewed-on: https://chromium-review.googlesource.com/871799 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529982} [modify] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-expected.txt [modify] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager.js [add] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame-expected.txt [add] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-in-ui-source-frame.js [add] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint-expected.txt [add] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/no-pause-on-disabled-breakpoint.js [add] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/resources/a.js [modify] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt [modify] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js [modify] https://crrev.com/6d4ff09053af834ff69b03372e83ac2dcc6e9e57/third_party/WebKit/Source/devtools/front_end/sources_test_runner/DebuggerTestRunner.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae909a43d73eb0a0909ece0a3531a637957ae31e commit ae909a43d73eb0a0909ece0a3531a637957ae31e Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jan 18 02:17:29 2018 [DevTools] remove breakpoint-manager test, part 2 Test includes simple case when breakpoint storage has breakpoints and script is added and complicated one when iframes with script with the same url are added. In second case everything is broken right now. We will fix this issue later. R=lushnikov@chromium.org Bug: chromium:803241 Change-Id: Ide1a5248357cb4848d55dcebadec60dee0d1b7cc Reviewed-on: https://chromium-review.googlesource.com/872210 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#530016} [modify] https://crrev.com/ae909a43d73eb0a0909ece0a3531a637957ae31e/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-expected.txt [modify] https://crrev.com/ae909a43d73eb0a0909ece0a3531a637957ae31e/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager.js [add] https://crrev.com/ae909a43d73eb0a0909ece0a3531a637957ae31e/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint-expected.txt [add] https://crrev.com/ae909a43d73eb0a0909ece0a3531a637957ae31e/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint.js [add] https://crrev.com/ae909a43d73eb0a0909ece0a3531a637957ae31e/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/resources/frame-with-script.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac0349435d7be5a165479c82b8b883ef33ba384 commit 1ac0349435d7be5a165479c82b8b883ef33ba384 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jan 18 06:53:45 2018 [DevTools] remove breakpoint-manager test, part 3 Extracted test for shifted breakpoint. We can remove "removeBreakpoint" test since removing is covered in most breakpoints related tests. R=lushnikov@chromium.org Bug: chromium:803241 Change-Id: I7f810fd431cf18857e097845a85b10870459472b Reviewed-on: https://chromium-review.googlesource.com/872239 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#530078} [modify] https://crrev.com/1ac0349435d7be5a165479c82b8b883ef33ba384/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager-expected.txt [modify] https://crrev.com/1ac0349435d7be5a165479c82b8b883ef33ba384/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-manager.js [add] https://crrev.com/1ac0349435d7be5a165479c82b8b883ef33ba384/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt [add] https://crrev.com/1ac0349435d7be5a165479c82b8b883ef33ba384/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint.js [modify] https://crrev.com/1ac0349435d7be5a165479c82b8b883ef33ba384/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/resources/a.js
Fore notes: part 4 was attributed with incorrect bug: https://chromium-review.googlesource.com/c/chromium/src/+/872266
As well as part 5: https://chromium-review.googlesource.com/c/chromium/src/+/874780 :(
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55daf265ddce7a7d10288a0024d4b2b93b966008 commit 55daf265ddce7a7d10288a0024d4b2b93b966008 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jan 18 23:25:32 2018 [DevTools] fixed breakpoints-ui-restored-breakpoints test R=lushnikov@chromium.org Bug: chromium:803449 , chromium:803241 Change-Id: I3bd1652d994c45d83e386522ee1fa8cf47d3efa9 Reviewed-on: https://chromium-review.googlesource.com/874596 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530332} [modify] https://crrev.com/55daf265ddce7a7d10288a0024d4b2b93b966008/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/55daf265ddce7a7d10288a0024d4b2b93b966008/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-restored-breakpoint.js [modify] https://crrev.com/55daf265ddce7a7d10288a0024d4b2b93b966008/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/pause-in-inline-script-expected.txt [modify] https://crrev.com/55daf265ddce7a7d10288a0024d4b2b93b966008/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
Comment 1 by bugdroid1@chromium.org
, Jan 18 2018