New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803236 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Mar 2018
Cc:
█ vollick@chromium.org
█ ymalik@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Remove the showToast parameter from VrShell#setVrModeEnabled()

Project Member Reported by mthiesse@chromium.org, Jan 17 2018 
For some reason we're deciding whether or not to show the 'press app button to exit' toast in java when setting WebVR mode.

The UI code should have all of the information it needs to know whether or not the toast should be shown, java shouldn't be aware of its existence.

Comment 1 by mthiesse@chromium.org, Feb 28 2018

Labels: -M-66 M-67

Comment 2 by cjgrant@chromium.org, Mar 28 2018

Owner: cjgrant@chromium.org
Status: Started (was: Available)
I'm doing this as follow-on to some WebVr indicator work - it's easy.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2f269264a80af7900f39cc88fe1bdf49dc6053

commit bd2f269264a80af7900f39cc88fe1bdf49dc6053
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Mar 29 20:52:16 2018

VR: Remove show toast parameter from SetWebVR call path.

As was pointed out in the attached bug, we don't need this anymore, and
can derive it from the other state the UI has.

BUG= 803236 
R=bshe

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4ad0d4ec40e0d7e7f22b72ba6918a9dcb6544a72
Reviewed-on: https://chromium-review.googlesource.com/984953
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546947}
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/ui.cc
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/ui.h
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/bd2f269264a80af7900f39cc88fe1bdf49dc6053/chrome/browser/vr/ui_unittest.cc

Comment 4 by cjgrant@chromium.org, Mar 29 2018

Status: Fixed (was: Started)

Comment 5 by dougman@chromium.org, Apr 11 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified in build 67.0.3394.0 Canary.  The Toast is presented in the appropriate locations.
►

Sign in to add a comment