New issue
Advanced search Search tips

Issue 803232 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

PageLoaded is called before DidFinishNavigation for "unsupported://chromium.test" url

Project Member Reported by eugene...@chromium.org, Jan 17 2018

Issue description

See NavigationAndLoadCallbacksTest.FailedNavigation unit test for details
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73f220adf7a80a14d0569b08b11fe18f345b497b

commit 73f220adf7a80a14d0569b08b11fe18f345b497b
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Feb 12 17:40:44 2018

Fix PageLoaded callback for failed navigation and load.

This CL fixes 2 problems:
 - PageLoaded was called twice if load has failed after commit
 - PageLoaded was called before DidFinishNavigation on navigation failure

After the change loadNativeViewWithSuccess:navigationContext: does not
update loadPhase and does not call didFinishWithURL:loadSuccess:context:
because it's not a responsibility of loadNativeViewWithSuccess.

loadPhase update and didFinishWithURL:loadSuccess:context: calls where
moved to places which call loadNativeViewWithSuccess:navigationContext:.

Bug:  806457 ,  803232 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2cc69018e189532fb3a4a0075451d4b30541ae34
Reviewed-on: https://chromium-review.googlesource.com/912245
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536122}
[modify] https://crrev.com/73f220adf7a80a14d0569b08b11fe18f345b497b/ios/web/public/web_state/web_state_observer.h
[modify] https://crrev.com/73f220adf7a80a14d0569b08b11fe18f345b497b/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
[modify] https://crrev.com/73f220adf7a80a14d0569b08b11fe18f345b497b/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment