WebScopedUserGesture vs WebUserGestureIndicator split seems unnecessary |
||||
Issue descriptionAfter we cleaned up gesture indicator entry points, - WebScopedUserGesture currently only holds a UserGestureIndicator to maintain its scope for users outside Blink, and - WebUserGestureIndicator only provides static methods to UserGestureIndicator. Seems merging this two class to mirror Blink's UGI would make our code cleaner and more intuitive. And it will be the first step for something like "WebUserActivation" interface.
,
Mar 5 2018
,
Apr 6 2018
Plan for 2018Q2: we will migrate appropriate parts of WebUserGestureIndicator into some Web*Frame class, and the possible merge the remaining old code into a single class.
,
Sep 14
,
Sep 28
We revisited the cleanup plan mentioned in #c3 and decided not to go ahead: - UAv2 web-layer interface is only in WebUserGestureIndicator, which directly connects to the static wrappers in Frame. Moving them to WebFrame class needs 100+ ref fixing which we can defer until UAv2 ships to simplify the task. - Anything that affects only old code (UAv1) would be a waste of time. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mustaq@chromium.org
, Jan 17 2018