New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803194 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ smut@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need validation for mp_dimensions in bots.cfg

Project Member Reported by iannucci@chromium.org, Jan 17 2018 
User accidentally specified an mp dimension of 'cores:32', but really meant 'num_cpus:32' (https://chrome-internal.googlesource.com/infradata/config/+/4c2a4139fbff54ae1350a5d14372d6d998e9fc8a/configs/chromium-swarm/bots.cfg#242)

We need an error channel for this so that this could have been caught (ideally) at pre-submit time.

Comment 1 by vadimsh@chromium.org, Jan 17 2018

Cc: smut@chromium.org
luci-config validation pipeline is already used for bots.cfg validation. There's just no code that checks mp_dimensions values are recognized. I believe it should verify keys match https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/components/components/machine_provider/dimensions.py#30

Comment 2 by iannucci@chromium.org, Jan 17 2018

Cc: -smut@chromium.org s...@google.com

Comment 3 by estaab@chromium.org, Jan 22 2018

Owner: s...@google.com
Status: Assigned (was: Untriaged)
That seems pretty fixable. smut, want to take this?

Comment 4 by s...@google.com, Jan 23 2018

Owner: ----
Status: Available (was: Assigned)
Not right now. Is there even presubmit for infradata/config?

Comment 5 by s...@google.com, Jul 26

Cc: smut@chromium.org

Comment 6 by s...@google.com, Jul 26

Cc: -s...@google.com
►

Sign in to add a comment