New issue
Advanced search Search tips

Issue 803191 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

New error page when profile is blocked

Project Member Reported by zmin@chromium.org, Jan 17 2018

Issue description

New error page when profile is permanently blocked due to force-sign-in policy. 
 

Comment 1 by zmin@chromium.org, Jan 17 2018

Owner: zmin@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b

commit 073b0641e1ca015efcc19b3dd11cb1e33d9cc11b
Author: Owen Min <zmin@chromium.org>
Date: Sat Jan 20 00:03:34 2018

Add new error page when profile is permanently disabled by force-sign-in policy.

Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing

Bug:  803191 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a41f51a82213f628a3ab11b5af341cc94f89a56
Reviewed-on: https://chromium-review.googlesource.com/876765
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530673}
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/resources/signin/signin_error/signin_error.html
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/login_ui_service.h
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/signin_error_ui.cc
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/073b0641e1ca015efcc19b3dd11cb1e33d9cc11b/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc

Comment 3 by zmin@chromium.org, Jan 29 2018

Labels: Merge-Request-65
Status: Started (was: Assigned)
This patch needs to be merged into M65 as the request of privacy reviewer.
This patch creates a new web UI and it does not introduce text change.
I have verified the patch on Canary and it's covered by browsertest/unittest.
Please add affected OSs.

Comment 5 by zmin@chromium.org, Jan 29 2018

Labels: OS-Windows

Comment 6 by zmin@chromium.org, Jan 29 2018

It's Windows only.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 30 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 30 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d204688f8ab2b9f8f6521fe54606b5e0c8e61642

commit d204688f8ab2b9f8f6521fe54606b5e0c8e61642
Author: Owen Min <zmin@chromium.org>
Date: Tue Jan 30 17:05:27 2018

Merge "Add new error page when profile is permanently disabled by force-sign-in policy."

Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing

TBR=zmin@chromium.org

(cherry picked from commit 073b0641e1ca015efcc19b3dd11cb1e33d9cc11b)

Bug:  803191 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a41f51a82213f628a3ab11b5af341cc94f89a56
Reviewed-on: https://chromium-review.googlesource.com/876765
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530673}
Reviewed-on: https://chromium-review.googlesource.com/893639
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#171}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/resources/signin/signin_error/signin_error.html
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/login_ui_service.h
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/signin_error_ui.cc
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/d204688f8ab2b9f8f6521fe54606b5e0c8e61642/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc

Comment 9 by tnagel@chromium.org, Feb 15 2018

Cc: tnagel@chromium.org
Thanks Owen! May I suggest inserting "still" as in "Although you can no longer access your old profile, you can still remove it."?
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069198f770f8582e7eb144cd33b99cb900019436

commit 069198f770f8582e7eb144cd33b99cb900019436
Author: Owen Min <zmin@chromium.org>
Date: Tue Feb 27 17:52:10 2018

Tune the error message of profile blocking.

Bug:  803191 
Change-Id: I04053d35036e05014c0ff8a670b774a7be5cb96c
Reviewed-on: https://chromium-review.googlesource.com/939584
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539495}
[modify] https://crrev.com/069198f770f8582e7eb144cd33b99cb900019436/chrome/app/generated_resources.grd

Comment 12 by zmin@chromium.org, May 11 2018

Status: Verified (was: Started)

Sign in to add a comment