New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803183 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
OOO
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fail to run setup_dev_autotest.sh

Project Member Reported by gu...@chromium.org, Jan 17 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) cd chromeos/src/third_party/autotest/files
(2) ran ./site_utils/setup_dev_autotest.sh


What is the expected result?
  The script should run successfully.

What happens instead?
  I got an error of 
  >  mysqladmin: Unknown command: ''

Please use labels and text to provide additional information.

When I checked the script of ./site_utils/setup_db.sh, in function of check_database(), it calls `mysqladmin` which, unlike mysql, doesn't accept empty string as part of option, see


$ mysqladmin -u root '' ping
mysqladmin: Unknown command: ''

$ mysqladmin --version
mysqladmin  Ver 8.42 Distrib 5.5.58, for debian-linux-gnu on x86_64

$ mysql -u root '' -e ';'
$ mysql --version
mysql  Ver 14.14 Distrib 5.5.58, for debian-linux-gnu (x86_64) using readline 6.3




 

Comment 1 by gu...@chromium.org, Jan 17 2018

Cc: shuqianz@chromium.org
Owner: gu...@chromium.org

Comment 2 by gu...@chromium.org, Jan 20 2018

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3b7b0e2fd4940171607e7f2f9cfee0aaff48617a

commit 3b7b0e2fd4940171607e7f2f9cfee0aaff48617a
Author: Congbin Guo <guocb@chromium.org>
Date: Mon Jan 22 22:46:24 2018

autotest: minor script bugfix

`mysqladmin` doesn't accept empty string as an option. When there is no
password set for root@localhost of mysql, the script `setup_db.sh`
raises an error when run `mysqladmin`.

BUG= chromium:803183 
TEST=1) removed password for root@localhost of mysql
    2) ran setup_dev_autotest.sh and ensure it finished successfully
    3) set password for root@localhost of mysql to something
    4) ran `setup_dev_autotest.sh` again and ensure it still finished
    successfully

Change-Id: I299309cbada80cdfd964be29712448bbf6dc7ee2
Reviewed-on: https://chromium-review.googlesource.com/871975
Commit-Ready: Congbin Guo <guocb@chromium.org>
Tested-by: Congbin Guo <guocb@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/3b7b0e2fd4940171607e7f2f9cfee0aaff48617a/site_utils/setup_db.sh

Comment 4 by gu...@chromium.org, Jan 25 2018

Status: Verified (was: Started)

Sign in to add a comment