New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803157 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Delete directory data for migrated types

Project Member Reported by s...@chromium.org, Jan 17 2018

Issue description

When a type is successfully migrated to USS, we should delete all the data inside of the Directory for that type. In the past we've thought that we shouldn't be doing this deletion mid migration, incase we wanted to roll back or investigate a bug. But this has so far never turned out to be useful.

This is important to do because we use less disk space, and we remove potential privacy problems of hanging onto old data. Imagine a TYPED_URL that was supposed to be deleted, but hanging around in the directory.
 
Cc: jkrcal@chromium.org pnoland@chromium.org
This does not seem to be precise, I see code from mid 2017 that purges directory after migration:

https://cs.chromium.org/chromium/src/components/sync/engine_impl/model_type_registry.cc?l=139&rcl=73defadf883036a56cb541f79c727a0d1f875719

Patrick (as the author of that code snippet), do you think something is missing w.r.t. to this bug report?
No, I think you have it right and this is already done.
Status: Fixed (was: Available)
Thanks for taking a look!

Sign in to add a comment