Modern Media Controls: Blank video with only play button when scrubbing ends on paused video |
||
Issue descriptionWhen using the modern media controls and you stop scrubbing on a paused video, the frame disappears and the controls (besides the overlay play button) disappear. Haven't yet looked into it, but suspecting a bug in the MediaControlsImpl::State method. Repro'd on both Desktop and Android.
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa16c8210abdb783cbb1a10727534d633c41012e commit aa16c8210abdb783cbb1a10727534d633c41012e Author: Tommy Steimel <steimel@chromium.org> Date: Mon Jan 22 19:02:46 2018 Avoid falling back into default poster once reaching a ready state This CL changes the MediaControls logic that decides whether or not to add the "use-default-poster" CSS class to only add it when we haven't already reached a ready state. This fixes a bug where the user would scrub a paused video to an unloaded point in the video and we would hide the timeline and show the default poster instead of the video frame we already had. Bug: 803143 Change-Id: Ie93153429643d7e60e506432ba761cba780f62d1 Reviewed-on: https://chromium-review.googlesource.com/875918 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#530931} [rename] https://crrev.com/aa16c8210abdb783cbb1a10727534d633c41012e/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-preload-metadata.html [copy] https://crrev.com/aa16c8210abdb783cbb1a10727534d633c41012e/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-preload-none.html [modify] https://crrev.com/aa16c8210abdb783cbb1a10727534d633c41012e/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
Jan 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Jan 18 2018