Issue 803135 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	qin...@chromium.org
Closed:	Aug 20
Cc:	█ jming@chromium.org shaktisahu@chromium.org xingliu@chromium.org dtrainor@chromium.org
Components:	UI>Browser>Downloads
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Hotlist-KnownIssue Proj-Servicification merge-merged-testbranch

Blocked on:
issue 842245
issue 796425

Participants' hotlists:
Downloads-Servicification-Refactor

Move content/browser/download to components/download

Project Member Reported by qin...@chromium.org, Jan 17 2018

Issue description

We eventually want to move everything related to download to be moved into services/download. 

Before that happens, we need to decouple all the dependencies from content/ and move all download code to components/ first, so that it will be much easier for us to move everything to services/

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48bf2b931acb1a02a03dac61b62727da407b2443

commit 48bf2b931acb1a02a03dac61b62727da407b2443
Author: Min Qin <qinmin@chromium.org>
Date: Tue Jan 23 19:16:43 2018

add background_service sub dir for components/download/internal(public)

This CL moves files from components/download/internal to components/download/internal/background_service
and components/download/public to components/download/public/background_service.

the download_service under components/download is conflicting with the download servicification work.
As a result, this CL moves the current code into a background_service sub-directory to avoid confusion

See https://docs.google.com/document/d/1yhKMfEICV5X9fI1kRXJACdOWRsIXYA3lhzQLPpNlbAE/ for details.

BUG=803135

Change-Id: I19b1c69bcfcd0d6f5299efd16c77c9fc79c318cc
Reviewed-on: https://chromium-review.googlesource.com/874991
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531295}
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/android/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/android/download/service/download_background_task.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/android/download/service/download_task_scheduler.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/background_fetch/background_fetch_download_client.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/background_fetch/background_fetch_download_client.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/download/download_service_factory.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/download/download_task_scheduler_impl.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/download/download_task_scheduler_impl.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/ui/webui/download_internals/download_internals_ui_message_handler.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/chrome/browser/ui/webui/download_internals/download_internals_ui_message_handler.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/factory/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/factory/download_service_factory.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/factory/download_service_factory.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/factory/navigation_monitor_factory.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/internal/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/internal/download_driver_impl.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/public/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/content/public/download_navigation_observer.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/BUILD.gn
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/DEPS
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/battery_status_listener_android.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/battery_status_listener_android.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/java/src/org/chromium/components/download/internal/BatteryStatusListenerAndroid.java
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/java/src/org/chromium/components/download/internal/NetworkStatusListenerAndroid.java
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/network_status_listener_android.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/android/network_status_listener_android.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/blob_task_proxy.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/blob_task_proxy.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/client_set.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/client_set.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/client_set_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/config.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/config.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/controller.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/controller_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/controller_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/controller_impl_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/debugging_client.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/debugging_client.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_driver.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_service_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_service_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_service_impl_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_store.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_store.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/download_store_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/driver_entry.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/driver_entry.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/entry.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/entry.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/entry_utils.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/entry_utils.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/entry_utils_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/file_monitor.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/file_monitor_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/file_monitor_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/file_monitor_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/in_memory_download.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/in_memory_download.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/in_memory_download_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/log_sink.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/log_source.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/logger_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/logger_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/memory_tracker.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/model.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/model_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/model_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/model_impl_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/navigation_monitor_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/navigation_monitor_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/navigation_monitor_impl_unittests.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto/BUILD.gn
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto/entry.proto
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto/request.proto
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto/scheduling.proto
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto_conversions.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto_conversions.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/proto_conversions_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/device_status.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/device_status.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/device_status_listener.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/device_status_listener.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/device_status_listener_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/network_status_listener.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/network_status_listener.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/scheduler.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/scheduler_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/scheduler_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/scheduler/scheduler_impl_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/service_config_impl.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/service_config_impl.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/service_config_impl_unittest.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/startup_status.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/startup_status.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/stats.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/stats.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/store.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/BUILD.gn
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/black_hole_log_sink.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/black_hole_log_sink.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/download_params_utils.cc
[add] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/download_params_utils.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/entry_utils.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/entry_utils.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_controller.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_controller.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_log_sink.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_log_sink.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_model_client.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/mock_model_client.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/noop_store.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/noop_store.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_device_status_listener.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_device_status_listener.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_download_driver.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_download_driver.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_store.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/internal/background_service/test/test_store.h
[delete] https://crrev.com/07f8bb44eb43b8dfccdc07d796d5ce0541466d4c/components/download/internal/test/download_params_utils.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/BUILD.gn
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/DEPS
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/client.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/clients.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_metadata.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_metadata.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_params.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_params.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_service.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/download_task_types.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/features.cc
[add] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/features.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/logger.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/navigation_monitor.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/service_config.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/task_scheduler.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/BUILD.gn
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/empty_client.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/empty_client.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/empty_logger.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/empty_logger.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/mock_client.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/mock_client.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/mock_download_service.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/mock_download_service.h
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/test_download_service.cc
[rename] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/download/public/background_service/test/test_download_service.h
[delete] https://crrev.com/07f8bb44eb43b8dfccdc07d796d5ce0541466d4c/components/download/public/features.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/BUILD.gn
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/prefetch_download_flow_unittest.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/prefetch_downloader_impl.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/components/offline_pages/core/prefetch/test_download_client.h
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/tools/traffic_annotation/auditor/safe_list.txt
[modify] https://crrev.com/48bf2b931acb1a02a03dac61b62727da407b2443/tools/traffic_annotation/auditor/tests/extractor_outputs/good_assignment.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c

commit 0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c
Author: Min Qin <qinmin@chromium.org>
Date: Wed Jan 31 00:49:35 2018

move some files from content/public/browser to components/download/public/core

These files are moved:
download_danger_type.h
download_save_info.h
download_save_info.cc
download_source.h

We are gradually moving all download related files from content/ to components/download.
This allows us to make download a standlone component,
and finally making it a service under services/download

BUG=803135

Change-Id: Id5be2a98beabd8bbd8be000a0fd1a36d633c6f7b
Reviewed-on: https://chromium-review.googlesource.com/891686
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533119}
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/android_webview/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/android_webview/browser/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/android_webview/browser/aw_download_manager_delegate.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/browsing_data/counters/downloads_counter_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/chrome_download_manager_delegate.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_danger_prompt.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_query.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_query.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_stats.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_stats.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_determiner.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_determiner_delegate.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_info.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_target_info.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/download/notification/download_notification_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/safe_browsing/download_protection/download_feedback_service.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/safe_browsing/download_protection/download_feedback_service.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/safe_browsing/download_protection/download_feedback_service_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/cocoa/download/md_download_item_view_unittest.mm
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chromecast/browser/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chromecast/browser/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/chromecast/browser/cast_download_manager_delegate.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/downloader/in_progress/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/downloader/in_progress/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/downloader/in_progress/download_entry.h
[delete] https://crrev.com/febd8e179ec5cdb40c5c13ff0204a30ce7a65ad8/components/download/downloader/in_progress/download_source.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/downloader/in_progress/proto/download_source.proto
[add] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/BUILD.gn
[add] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/DEPS
[rename] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/download_danger_type.h
[add] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/download_export.h
[rename] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/download_save_info.cc
[rename] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/download_save_info.h
[rename] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/download/public/common/download_source.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/history/content/browser/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/history/content/browser/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/history/content/browser/download_conversions.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/components/history/content/browser/download_conversions.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/devtools/protocol/devtools_download_manager_delegate.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_create_info.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_create_info.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_file_factory.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_file_factory.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_file_impl.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_factory.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_impl.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_job.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_request_core.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_request_core.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_request_core_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_response_handler.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_stats.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_stats.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_ukm_helper.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_ukm_helper.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_ukm_helper_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_utils.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/download_utils.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/mock_download_item_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/url_downloader.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/download/url_downloader.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/BUILD.gn
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/download_item.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/download_manager.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/download_manager_delegate.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/download_url_parameters.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/browser/download_url_parameters.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/DEPS
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/fake_download_item.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/fake_download_item.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/mock_download_item.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/mock_download_manager.h
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/0ca8e1eef71c8655224b58ef3b4fc710dcc9fc6c/content/shell/browser/shell_download_manager_delegate.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb78b7a549e481b133575cfd71d1be1338f264f8

commit eb78b7a549e481b133575cfd71d1be1338f264f8
Author: Min Qin <qinmin@chromium.org>
Date: Sat Feb 03 00:43:16 2018

move DownloadInterruptReasons from content/ to components/download

This CL is the ongoing effort to make download a standalone component

BUG=803135

Change-Id: I0b4c740d3785712b7106026cb624c29db0e6fcfb
Reviewed-on: https://chromium-review.googlesource.com/897967
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534214}
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/android_webview/browser/aw_download_manager_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/browsing_data/counters/downloads_counter_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_commands_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_target_determiner.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_target_info.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_target_info.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/api/downloads/downloads_api.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/extensions/webstore_installer.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/plugins/plugin_installer.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/plugins/plugin_installer.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/chromecast/browser/cast_download_manager_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/client_update_protocol/DEPS
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/content/internal/download_driver_impl_unittest.cc
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/internal/common/BUILD.gn
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/internal/common/DEPS
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/internal/common/download_interrupt_reasons_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/public/common/BUILD.gn
[rename] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/public/common/download_interrupt_reason_values.h
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/download/public/common/download_interrupt_reasons.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/history/content/browser/content_history_backend_db_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/history/content/browser/download_conversions.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/history/content/browser/download_conversions.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/history/content/browser/history_database_helper.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/components/history/ios/browser/history_database_helper.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/BUILD.gn
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/devtools/protocol/devtools_download_manager_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file_posix.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file_win.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/base_file_win_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_create_info.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_create_info.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_destination_observer.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_file.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_file_impl.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_file_unittest.cc
[delete] https://crrev.com/2459d2cdbe49cc71efee27fa973c7cd04c4f8517/content/browser/download/download_interrupt_reasons_impl.cc
[delete] https://crrev.com/2459d2cdbe49cc71efee27fa973c7cd04c4f8517/content/browser/download/download_interrupt_reasons_impl.h
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_interrupt_reasons_utils.cc
[add] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_interrupt_reasons_utils.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_item_factory.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_item_impl.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_job.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_job.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_request_core.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_request_core.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_response_handler.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_stats.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_stats.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_ukm_helper.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_ukm_helper.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_ukm_helper_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_utils.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_utils.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/download_worker.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/mock_download_file.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/mock_download_file.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/mock_download_item_impl.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/save_file.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/save_file.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/save_file_manager.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/url_downloader.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/download/url_downloader.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/browser/indexed_db/indexed_db_internals_ui.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/browser/BUILD.gn
[delete] https://crrev.com/2459d2cdbe49cc71efee27fa973c7cd04c4f8517/content/public/browser/download_interrupt_reasons.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/browser/download_item.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/browser/download_manager.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/browser/download_manager_delegate.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/browser/download_url_parameters.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/download_test_observer.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/download_test_observer.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/fake_download_item.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/fake_download_item.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/mock_download_item.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/mock_download_manager.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/public/test/test_file_error_injector.h
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/shell/browser/shell_download_manager_delegate.cc
[modify] https://crrev.com/eb78b7a549e481b133575cfd71d1be1338f264f8/content/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f487874963fe60a0a9b5cfd0773df6a3b30363

commit a9f487874963fe60a0a9b5cfd0773df6a3b30363
Author: Min Qin <qinmin@chromium.org>
Date: Fri Feb 09 20:43:23 2018

Move download_item.h from content/public to components/download

This CL moves the DownloadItem class from content/public to components/download.
It is the ongoing effort to make download a standalone component.
To achieve this, this CL splits DownloadItem into 2 classes:
DownloadItem and DownloadItemDelegate.
The new DownloadItemDelegate class allows content layer to inject its own implementation.
This allows any classes that call into DownloadItem::GetWebContents()
and DownloadItem::GetBrowserContext() to still work

BUG=803135

Change-Id: I494164af65eb5d83f395b085bd35b896d62884d8
Reviewed-on: https://chromium-review.googlesource.com/907687
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535817}
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/android_webview/browser/aw_download_manager_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/android_webview/browser/aw_download_manager_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/BUILD.gn
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/chrome_duplicate_download_infobar_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/chrome_duplicate_download_infobar_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/dangerous_download_infobar_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/dangerous_download_infobar_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_controller.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_controller_base.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/download_manager_service_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/mock_download_controller.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/android/download/mock_download_controller.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/browsing_data/counters/downloads_counter.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/browsing_data/counters/downloads_counter_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/chromeos/drive/download_handler.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/chromeos/drive/download_handler_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/chrome_download_manager_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_browsertest.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_commands.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_commands_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_completion_blocker.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_core_service_impl.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_crx_util.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_crx_util.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_crx_util_android.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_danger_prompt.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_danger_prompt.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_file_picker.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_file_picker.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_history.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_history.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_item_model.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_path_reservation_tracker.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_path_reservation_tracker.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_path_reservation_tracker_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_prefs.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_query.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_query.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_shelf.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_shelf.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_shelf_context_menu.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_shelf_context_menu.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_shelf_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_status_updater.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_status_updater.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_status_updater_mac.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_status_updater_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_status_updater_win.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_determiner.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_determiner_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_info.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_target_info.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_test_file_activity_observer.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_ui_controller.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_ui_controller.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/drag_download_item.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/drag_download_item_views.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_notification_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/notification/download_notification_manager.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/save_package_file_picker.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/save_page_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/test_download_shelf.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/download/test_download_shelf.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/api/downloads/downloads_api.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/webstore_installer.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/extensions/webstore_installer_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ntp_snippets/download_suggestions_provider.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/check_client_download_request.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_feedback_service.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_feedback_service.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_feedback_service_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_protection_service.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_protection_util.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_url_sb_client.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/download_protection/download_url_sb_client.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_button.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_cell.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_controller.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_controller.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_drag_mac.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_mac.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_item_mac.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_shelf_controller.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_shelf_mac.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/download_shelf_mac.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/md_download_item_view.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/cocoa/download/md_download_item_view_unittest.mm
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/views/download/download_shelf_view.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chromecast/browser/cast_download_manager_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/chromecast/browser/cast_download_manager_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/internal/download_driver_impl.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/internal/download_driver_impl_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/public/all_download_item_notifier.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/public/all_download_item_notifier.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/content/public/all_download_item_notifier_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/internal/background_service/driver_entry.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/internal/common/BUILD.gn
[add] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/public/common/BUILD.gn
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/public/common/DEPS
[rename] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/download/public/common/download_item.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/history/content/browser/download_conversions.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/history/content/browser/download_conversions.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/components/history/content/browser/download_conversions_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/BUILD.gn
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/background_fetch/background_fetch_request_info.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/background_fetch/background_fetch_request_info.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/devtools/protocol/devtools_download_manager_delegate.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/devtools/protocol/devtools_download_manager_delegate.h
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/a9f487874963fe60a0a9b5cfd0773df6a3b30363/content/browser/downloa

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a904f3303bf77f25bbd7c5fa5a81e53576062923

commit a904f3303bf77f25bbd7c5fa5a81e53576062923
Author: Min Qin <qinmin@chromium.org>
Date: Tue Feb 13 23:33:34 2018

move DownloadUrlParameters from content/public to components/download

This CL moves DownloadUrlParameters to components/download.
It replaces the content::Referrer member variable with a GURL and a
net::URLRequest::ReferrerPolicy variable in that class.
This is part of the ongoing effort to move all download into components/

Bug: 803135
Change-Id: I8b57d0d92b756f3b0bee8bc2b3371cb40a44c726
Reviewed-on: https://chromium-review.googlesource.com/914232
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536547}
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/android/download/download_manager_service_unittest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/components/download/public/common/BUILD.gn
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/components/download/public/common/DEPS
[add] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/components/download/public/common/download_url_parameters.cc
[rename] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/components/download/public/common/download_url_parameters.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/BUILD.gn
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_item_impl.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_request_core.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_request_core.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_request_core_unittest.cc
[add] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_request_utils.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_utils.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_utils.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_worker.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/download_worker.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/resource_downloader.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/url_download_handler.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/url_downloader.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/download/url_downloader.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/browser/BUILD.gn
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/browser/download_manager.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/browser/download_request_utils.h
[delete] https://crrev.com/f0f9d4e9287a34fd26c2735606a47fb22ec2932e/content/public/browser/download_url_parameters.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/test/download_test_observer.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/test/download_test_observer.h
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/a904f3303bf77f25bbd7c5fa5a81e53576062923/content/public/test/mock_download_manager.h

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28

commit 93bed6ae0a55402f48c5487474e2cdd0c7ab8f28
Author: Min Qin <qinmin@chromium.org>
Date: Wed Feb 14 21:53:22 2018

Pass URLLoaderFactory to ResourceDownloader

Currently DownloadManager passes a URLLoaderFactoryGetter to ResourceDownloader.
URLLoaderFactoryGetter is under content/, which will cause dependency
violations if we move all download code to components/.
Additionally, the ResourceDownloader uses content::BlobURLLoaderFactory,
which is being deprecated.
This CL consolidates the blob and non-blob case by passing a
network::mojom::URLLoaderFactory to the ResourceDownloader.
And it switches to use storage::BlobURLLoaderFactory.

Bug: 803135
Change-Id: I1067c601f632569e2d4d5e9b0c838787a889d14f
Reviewed-on: https://chromium-review.googlesource.com/916884
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536833}
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/components/download/public/common/BUILD.gn
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/components/download/public/common/DEPS
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/components/download/public/common/download_url_parameters.h
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/download/download_worker.cc
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/download/resource_downloader.h
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/public/browser/download_manager.h
[modify] https://crrev.com/93bed6ae0a55402f48c5487474e2cdd0c7ab8f28/content/public/test/mock_download_manager.h

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc77ad609c9a8193d24116c03c88be8394a4cb33

commit fc77ad609c9a8193d24116c03c88be8394a4cb33
Author: Min Qin <qinmin@chromium.org>
Date: Thu Feb 15 18:09:50 2018

Move download_stream.mojom from content/public to components/download

Simple file move, no function change

BUG=803135

Change-Id: Ibc605a91432d1a0be44ada5add43b50593b2061d
Reviewed-on: https://chromium-review.googlesource.com/917207
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537071}
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/components/download/public/common/BUILD.gn
[add] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/components/download/public/common/OWNERS
[rename] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/components/download/public/common/download_stream.mojom
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_file_impl.h
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_interrupt_reasons_utils.cc
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_interrupt_reasons_utils.h
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/download_response_handler.h
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/browser/download/resource_downloader.h
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/public/browser/download_manager.cc
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/public/browser/download_manager.h
[modify] https://crrev.com/fc77ad609c9a8193d24116c03c88be8394a4cb33/content/public/common/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece52f425ffafdbf92b5483a0bf5cfb8e3875650

commit ece52f425ffafdbf92b5483a0bf5cfb8e3875650
Author: Min Qin <qinmin@chromium.org>
Date: Fri Feb 16 17:19:33 2018

Move some download files content/browser to components/download

Simply moving the files, no structural change

BUG=803135

Change-Id: I2c986f07eae2fef2bd316cda512054c27c01758c
Reviewed-on: https://chromium-review.googlesource.com/920643
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537336}
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/BUILD.gn
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/internal/common/BUILD.gn
[rename] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/internal/common/rate_estimator.cc
[rename] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/internal/common/rate_estimator_unittest.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/public/common/BUILD.gn
[rename] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/public/common/download_content.h
[rename] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/public/common/rate_estimator.h
[rename] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/components/download/public/common/resume_mode.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/BUILD.gn
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_create_info.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_file_impl.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_item_impl.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_stats.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_stats.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_ukm_helper.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_ukm_helper.h
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/browser/download/download_ukm_helper_unittest.cc
[modify] https://crrev.com/ece52f425ffafdbf92b5483a0bf5cfb8e3875650/content/test/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1

commit 43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1
Author: Min Qin <qinmin@chromium.org>
Date: Wed Feb 21 22:01:58 2018

move DownloadCreateInfo from content/browser/ to components/download

Changed the DownloadRequestHandleInterface class to remove reference to WebContents.
And moved the DownloadCreateInfo from content/browser to components/

Bug: 803135
Change-Id: I4fb39494bd1c5226e6abab29bc2eae4ce364f5d5
Reviewed-on: https://chromium-review.googlesource.com/926961
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538227}
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/internal/common/DEPS
[rename] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/internal/common/download_create_info.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/public/common/BUILD.gn
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/public/common/DEPS
[rename] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/public/common/download_create_info.h
[add] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/components/download/public/common/download_request_handle_interface.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/BUILD.gn
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_item_factory.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_item_impl.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job_factory.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job_impl.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_job_impl.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_request_core.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_request_core.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_request_handle.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_request_handle.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_response_handler.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_utils.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_utils.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_worker.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/download_worker.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/mock_download_job.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/parallel_download_utils.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/resource_downloader.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/save_package.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/save_package_download_job.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/save_package_download_job.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/url_download_handler.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/url_downloader.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/browser/download/url_downloader.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/public/browser/download_manager.h
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/43e65bbdba68ffc326d8adc3b9dd45b24e8a4ca1/content/public/test/mock_download_manager.h

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1870c4170c953989a62c7bc3f7449d5ec4f7250

commit e1870c4170c953989a62c7bc3f7449d5ec4f7250
Author: Min Qin <qinmin@chromium.org>
Date: Fri Feb 23 19:16:25 2018

move download_task_runner.h from content/ to components

This CL simply moves the file, no major changes.

BUG=803135

Change-Id: I3158f7e4382940afe1114bb4f614eba4337ba660
Reviewed-on: https://chromium-review.googlesource.com/929745
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538850}
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/components/download/internal/common/BUILD.gn
[rename] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/components/download/internal/common/download_task_runner.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/components/download/public/common/BUILD.gn
[add] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/components/download/public/common/download_task_runner.h
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/BUILD.gn
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_job.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_request_core.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/download_resource_handler.cc
[delete] https://crrev.com/69a94cacf40f572841a44598b23ab659c9ce4fa3/content/browser/download/download_task_runner.h
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/save_file.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/save_file_manager.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/save_file_resource_handler.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/browser/download/save_package.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/public/browser/download_manager.cc
[modify] https://crrev.com/e1870c4170c953989a62c7bc3f7449d5ec4f7250/content/public/test/test_file_error_injector.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a311527d208680f187db36d00657764c04cd3bd4

commit a311527d208680f187db36d00657764c04cd3bd4
Author: Min Qin <qinmin@chromium.org>
Date: Fri Feb 23 19:23:31 2018

Move the logic of checking default download dir into DownloadManagerImpl

Currently BaseFile will ask ContentBrowserClient for default download dir
if preference returns an empty dir.
This CL moves that logic into DownloadManagerImpl,
so BaseFile won't need to reference ContentBrowserClient.

BUG=803135

Change-Id: I480d9f32bd685068134bd25b23e07ea21d7239f6
Reviewed-on: https://chromium-review.googlesource.com/930234
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538855}
[modify] https://crrev.com/a311527d208680f187db36d00657764c04cd3bd4/content/browser/download/base_file.cc
[modify] https://crrev.com/a311527d208680f187db36d00657764c04cd3bd4/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/a311527d208680f187db36d00657764c04cd3bd4/content/browser/download/download_manager_impl.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0ed206f6490a5c63cefd74e440755fe33f7476

commit da0ed206f6490a5c63cefd74e440755fe33f7476
Author: Min Qin <qinmin@chromium.org>
Date: Fri Feb 23 22:00:53 2018

move DownloadStats and DownloadUkmHelper to components/download

These 2 classes are needed for reporting UMA/UKM stats
And should be moved to the components/download

BUG=803135

Change-Id: I9ce2459a6bfd44c8c16ec0d31a5b06fba37b5f58
Reviewed-on: https://chromium-review.googlesource.com/924275
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538914}
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/DEPS
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/download_stats.cc
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/download_stats_unittest.cc
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/download_ukm_helper.cc
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/internal/common/download_ukm_helper_unittest.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/public/common/BUILD.gn
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/public/common/download_stats.h
[rename] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/components/download/public/common/download_ukm_helper.h
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/BUILD.gn
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/base_file.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/base_file_win.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_request_core.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/download_utils.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/save_package.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/download/url_download_handler.h
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/content/test/BUILD.gn
[modify] https://crrev.com/da0ed206f6490a5c63cefd74e440755fe33f7476/services/metrics/public/cpp/ukm_recorder.h

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d103f115ce35377345d6fe415aa8f97142148c33

commit d103f115ce35377345d6fe415aa8f97142148c33
Author: Min Qin <qinmin@chromium.org>
Date: Wed Feb 28 14:20:39 2018

Move file quarantine implementation to components

The implementation is currently in content/ and used by download and pepper.
Download code is being moved to components/.
This CL moves the quarantine implemetation to components/ so it
can be shared between content/ and components/

BUG=803135

Change-Id: Id68afca113891abb8475b6b64f5854be28b0ca3e
Reviewed-on: https://chromium-review.googlesource.com/933287
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539817}
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/chrome/test/BUILD.gn
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/BUILD.gn
[add] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/BUILD.gn
[add] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/DEPS
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine.cc
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine.h
[add] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_constants_linux.h
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_linux.cc
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_linux_unittest.cc
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_mac.mm
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_mac_unittest.mm
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_unittest.cc
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_win.cc
[rename] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/download/quarantine/quarantine_win_unittest.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/components/test/components_test_suite.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/browser/BUILD.gn
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/browser/DEPS
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/browser/download/base_file.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/browser/renderer_host/pepper/pepper_file_io_host.cc
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/browser/renderer_host/pepper/pepper_file_io_host.h
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/common/BUILD.gn
[delete] https://crrev.com/ab7770e4fcdbbd19c8d01ec97a9c141e05ce78d8/content/common/quarantine/quarantine_constants_linux.h
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/public/common/BUILD.gn
[modify] https://crrev.com/d103f115ce35377345d6fe415aa8f97142148c33/content/test/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/647161ede9210a5d17d3f1c02caf0cc2911a0f82

commit 647161ede9210a5d17d3f1c02caf0cc2911a0f82
Author: Min Qin <qinmin@chromium.org>
Date: Thu Mar 01 21:54:57 2018

move base_file from content/browser/download to components/download/

Simple moving the files, no logic change

Bug: 803135
Change-Id: I5d9d551eac5f4298c951d6090df6c0a72b9c30e8
Reviewed-on: https://chromium-review.googlesource.com/941725
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540301}
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/DEPS
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/base_file.cc
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/base_file_posix.cc
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/base_file_unittest.cc
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/base_file_win.cc
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/base_file_win_unittest.cc
[add] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/internal/common/download_interrupt_reasons_utils.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/public/common/BUILD.gn
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/public/common/DEPS
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/public/common/base_file.h
[rename] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/components/download/public/common/download_interrupt_reasons_utils.h
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/BUILD.gn
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_file_impl.h
[delete] https://crrev.com/fdbb173a345930127fa1944748daacd34bdd063f/content/browser/download/download_interrupt_reasons_utils.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_request_core.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/download_utils.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/browser/download/save_file.h
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/647161ede9210a5d17d3f1c02caf0cc2911a0f82/content/test/BUILD.gn

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824bbddf005642cd9c6b9818ce57dd82905ca84d

commit 824bbddf005642cd9c6b9818ce57dd82905ca84d
Author: Min Qin <qinmin@chromium.org>
Date: Sat Mar 03 03:11:18 2018

Move downloadResponseHandler to components/download

No major change in functionality, just moving the files

Bug: 803135
Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
Reviewed-on: https://chromium-review.googlesource.com/944545
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540736}
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/internal/common/DEPS
[rename] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/public/common/BUILD.gn
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/public/common/DEPS
[rename] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/public/common/download_response_handler.h
[add] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/components/download/public/common/download_utils.h
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/BUILD.gn
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/download/download_request_core.cc
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/download/download_utils.cc
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/download/download_utils.h
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/824bbddf005642cd9c6b9818ce57dd82905ca84d/content/browser/download/resource_downloader.h

Project Member

Comment 16 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73899cc3563736ac15f97dab1aeebe8179f936eb

commit 73899cc3563736ac15f97dab1aeebe8179f936eb
Author: Scott Violet <sky@chromium.org>
Date: Sat Mar 03 17:46:52 2018

Revert "Move downloadResponseHandler to components/download"

This reverts commit 824bbddf005642cd9c6b9818ce57dd82905ca84d.

Reason for revert: reverting in hopes of making tree green. The linux x64 bot has been flakely failing. For example, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59821%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout and 

FAILED: obj/components/download/internal/common/internal/download_response_handler.o 
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/download/internal/common/internal/download_response_handler.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"325667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPONENTS_DOWNLOAD_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fdebug-prefix-map=/b/c/b/linux_clobber/src/out/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-header-guard -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nspr -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../components/download/internal/common/download_response_handler.cc -o obj/components/download/internal/common/internal/download_response_handler.o
In file included from ../../components/download/internal/common/download_response_handler.cc:5:
../../components/download/public/common/download_response_handler.h:16:10: fatal error: 'services/network/public/mojom/url_loader.mojom.h' file not found
#include "services/network/public/mojom/url_loader.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Move downloadResponseHandler to components/download
> 
> No major change in functionality, just moving the files
> 
> Bug: 803135
> Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
> Reviewed-on: https://chromium-review.googlesource.com/944545
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540736}

TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org

Change-Id: I1863660ebd431022abe2bf919ab38925fead91af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803135
Reviewed-on: https://chromium-review.googlesource.com/947983
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540756}
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/components/download/internal/common/DEPS
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/components/download/public/common/BUILD.gn
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/components/download/public/common/DEPS
[delete] https://crrev.com/1681340abcd20dd8f29dbb9cb8027ada59a012cb/components/download/public/common/download_utils.h
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/BUILD.gn
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/download_request_core.cc
[rename] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/download_response_handler.cc
[rename] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/download_response_handler.h
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/download_utils.cc
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/download_utils.h
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/73899cc3563736ac15f97dab1aeebe8179f936eb/content/browser/download/resource_downloader.h

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c128a63a4b44ff476e2b48f8ac238a3f5d287cef

commit c128a63a4b44ff476e2b48f8ac238a3f5d287cef
Author: Min Qin <qinmin@chromium.org>
Date: Mon Mar 05 22:25:49 2018

Reland "Move downloadResponseHandler to components/download"

This is a reland of 824bbddf005642cd9c6b9818ce57dd82905ca84d

Original change's description:
> Move downloadResponseHandler to components/download
> 
> No major change in functionality, just moving the files
> 
> Bug: 803135
> Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
> Reviewed-on: https://chromium-review.googlesource.com/944545
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540736}

Bug: 803135
Change-Id: I270c0f6edc212ffe1a2a9d06ccfbc95f1da8f3e2
Reviewed-on: https://chromium-review.googlesource.com/949702
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540961}
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/internal/common/DEPS
[rename] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/public/common/BUILD.gn
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/public/common/DEPS
[rename] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/public/common/download_response_handler.h
[add] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/components/download/public/common/download_utils.h
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/BUILD.gn
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/download/download_request_core.cc
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/download/download_utils.cc
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/download/download_utils.h
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/c128a63a4b44ff476e2b48f8ac238a3f5d287cef/content/browser/download/resource_downloader.h

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96b15e1c0b06863d9d3a4414b41b03addca90c6

commit a96b15e1c0b06863d9d3a4414b41b03addca90c6
Author: Min Qin <qinmin@chromium.org>
Date: Mon Mar 05 22:45:19 2018

Revert "Reland "Move downloadResponseHandler to components/download""

This reverts commit c128a63a4b44ff476e2b48f8ac238a3f5d287cef.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Move downloadResponseHandler to components/download"
> 
> This is a reland of 824bbddf005642cd9c6b9818ce57dd82905ca84d
> 
> Original change's description:
> > Move downloadResponseHandler to components/download
> > 
> > No major change in functionality, just moving the files
> > 
> > Bug: 803135
> > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
> > Reviewed-on: https://chromium-review.googlesource.com/944545
> > Reviewed-by: Helen Li <xunjieli@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Commit-Queue: Min Qin <qinmin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#540736}
> 
> Bug: 803135
> Change-Id: I270c0f6edc212ffe1a2a9d06ccfbc95f1da8f3e2
> Reviewed-on: https://chromium-review.googlesource.com/949702
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540961}

TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org

Change-Id: Iea107687b6008c6132ee6533fdff56e1d3db0265
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803135
Reviewed-on: https://chromium-review.googlesource.com/950022
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540965}
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/components/download/internal/common/DEPS
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/components/download/public/common/BUILD.gn
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/components/download/public/common/DEPS
[delete] https://crrev.com/50fa83290a2937f8b7f90b109130786d039fa5b9/components/download/public/common/download_utils.h
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/BUILD.gn
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/download_request_core.cc
[rename] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/download_response_handler.cc
[rename] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/download_response_handler.h
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/download_utils.cc
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/download_utils.h
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/a96b15e1c0b06863d9d3a4414b41b03addca90c6/content/browser/download/resource_downloader.h

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb

commit fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 07 06:04:38 2018

Reland "Reland "Move downloadResponseHandler to components/download""

This is a reland of c128a63a4b44ff476e2b48f8ac238a3f5d287cef

The CL previously passed CQ, but break the waterfall.
The reason for the failure was that the mojom header file generation
has to be done before checking the .cc file.
Since the public/ target depends on internal/, the mojom dependency
has to be moved to internal/ for this to take place.

Original change's description:
> Reland "Move downloadResponseHandler to components/download"
>
> This is a reland of 824bbddf005642cd9c6b9818ce57dd82905ca84d
>
> Original change's description:
> > Move downloadResponseHandler to components/download
> >
> > No major change in functionality, just moving the files
> >
> > Bug: 803135
> > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
> > Reviewed-on: https://chromium-review.googlesource.com/944545
> > Reviewed-by: Helen Li <xunjieli@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Commit-Queue: Min Qin <qinmin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#540736}
>
> Bug: 803135
> Change-Id: I270c0f6edc212ffe1a2a9d06ccfbc95f1da8f3e2
> Reviewed-on: https://chromium-review.googlesource.com/949702
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540961}

TBR=boliu@chromium.org, xunjieli@chromium.org

Bug: 803135
Change-Id: I834dc92109a509c8b981e6e5eef40f3a1c1ecaed
Reviewed-on: https://chromium-review.googlesource.com/952032
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541365}
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/internal/common/DEPS
[rename] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/public/common/BUILD.gn
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/public/common/DEPS
[rename] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/public/common/download_response_handler.h
[add] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/components/download/public/common/download_utils.h
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/BUILD.gn
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/download/download_request_core.cc
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/download/download_utils.cc
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/download/download_utils.h
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/fdfd6ec5f4bf28bbdabc0d8b62860b0b865910fb/content/browser/download/resource_downloader.h

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224e17f1964d2c416240fd4aa3e2d8db9f1ed3c9

commit 224e17f1964d2c416240fd4aa3e2d8db9f1ed3c9
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 07 20:25:46 2018

Remove use of BrowserThread in DownloadFile

DownloadFile can simply use the TaskRunner is was created on to post tasks.

BUG=803135

Change-Id: Idaccfba1c719d96a2fa11d933809ce4573004ee6
Reviewed-on: https://chromium-review.googlesource.com/952204
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541553}
[modify] https://crrev.com/224e17f1964d2c416240fd4aa3e2d8db9f1ed3c9/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/224e17f1964d2c416240fd4aa3e2d8db9f1ed3c9/content/browser/download/download_file_impl.h
[modify] https://crrev.com/224e17f1964d2c416240fd4aa3e2d8db9f1ed3c9/content/browser/download/download_file_unittest.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0

commit d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0
Author: Min Qin <qinmin@chromium.org>
Date: Thu Mar 08 19:27:59 2018

Move DownloadDestinationObserver to components/download

Simple file move, no functional changes

BUG=803135

Change-Id: I023c36ebc58adf2e623e2a75eabb3c033aadbd63
Reviewed-on: https://chromium-review.googlesource.com/952276
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541861}
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/components/download/public/common/BUILD.gn
[add] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/components/download/public/common/download_destination_observer.cc
[rename] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/components/download/public/common/download_destination_observer.h
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/BUILD.gn
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_file_factory.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_file_factory.h
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_file_impl.h
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_item_impl.h
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/d1b82b4f155a74aa12e8c412817c6e2abdf0e4d0/content/public/test/test_file_error_injector.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/745839d917dae569a46fb237696e016342fe67d3

commit 745839d917dae569a46fb237696e016342fe67d3
Author: Min Qin <qinmin@chromium.org>
Date: Fri Mar 09 00:09:40 2018

Refactor DownloadManager::InputStream class

DownloadManager::InputStream is backed by either a ByteStreamReader or a
DataStreamHandle. The former is implemented in content/. And it is used
by the legacy download code. For network service, the latter is used.
To move download code to components/, this CL makes them 2 separate
child class of a common download::InputStream.
And that makes code more simple to read as there used to be a lot of
if-else statement to check which one is used in the InputStream.

Bug: 803135
Change-Id: Icab5369583b186bf253aec84f1d59769162300c9
Reviewed-on: https://chromium-review.googlesource.com/952023
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541948}
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/internal/common/DEPS
[add] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/internal/common/stream_handle_input_stream.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/public/common/BUILD.gn
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/public/common/DEPS
[add] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/public/common/input_stream.h
[add] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/components/download/public/common/stream_handle_input_stream.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/BUILD.gn
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[add] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/byte_stream_input_stream.cc
[add] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/byte_stream_input_stream.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file_factory.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file_factory.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file_impl.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_job.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_job.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_worker.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/download_worker.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/mock_download_file.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/mock_download_file.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/url_download_handler.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/browser/download/url_downloader.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/public/browser/download_manager.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/public/browser/download_manager.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/public/test/mock_download_manager.h
[modify] https://crrev.com/745839d917dae569a46fb237696e016342fe67d3/content/public/test/test_file_error_injector.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d461ee46f928bb3e0fd4b733952b5b6041ac86e3

commit d461ee46f928bb3e0fd4b733952b5b6041ac86e3
Author: Min Qin <qinmin@chromium.org>
Date: Fri Mar 09 19:39:15 2018

Move parallel download feature to components/download

This feature is currently defined in content/.
This Cl moves it to components/download to remove download dependency on content/.

BUG=803135

Change-Id: Iabbc34eff56554722d4aa7bde1f461135984ac74
Reviewed-on: https://chromium-review.googlesource.com/955899
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542199}
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/chrome/browser/about_flags.cc
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/components/download/public/common/BUILD.gn
[add] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/components/download/public/common/download_features.cc
[add] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/components/download/public/common/download_features.h
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/content/public/common/content_features.cc
[modify] https://crrev.com/d461ee46f928bb3e0fd4b733952b5b6041ac86e3/content/public/common/content_features.h

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a4ff06e4eaa99610d6786cbae044058c8f19018

commit 1a4ff06e4eaa99610d6786cbae044058c8f19018
Author: Min Qin <qinmin@chromium.org>
Date: Sat Mar 10 00:47:21 2018

Rewrite download unittests that uses ByteStreamReader

ByteStreamReader is in content/ and download should avoid such dependency.
Replace all the ByteStreamReader mocks with mocks of download::InputStream

Bug: 803135
Change-Id: I3650d482943c604bedc39c0db8ec7b1021656fe4
Reviewed-on: https://chromium-review.googlesource.com/957446
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542293}
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/components/download/internal/common/stream_handle_input_stream.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/components/download/public/common/BUILD.gn
[add] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/components/download/public/common/input_stream.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/components/download/public/common/input_stream.h
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/components/download/public/common/stream_handle_input_stream.h
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/byte_stream_input_stream.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/byte_stream_input_stream.h
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/download_file_impl.h
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/download_job.h
[add] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/mock_input_stream.cc
[add] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/mock_input_stream.h
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/1a4ff06e4eaa99610d6786cbae044058c8f19018/content/test/BUILD.gn

Comment 25 by qin...@chromium.org, Mar 13 2018

Blockedon: 796425

Comment 26 by chongz@chromium.org, Mar 13 2018

|SharedURLLoaderFactory| has been moved to services/network/public/cpp/ as per b7c8d1ce9f10ff2cd18f0b9d13849bfac484d88c. Hope that helps!

Project Member

Comment 27 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a419f154068880cc0806c78def9e660bd1a98fc6

commit a419f154068880cc0806c78def9e660bd1a98fc6
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 14 18:28:34 2018

Pass delegate's TaskRunner to ResourceDownloader

ResourceDownloader uses BrowserThread::UI to post tasks to the delegate.
This introduces dependency on content/
Let delegate pass a TaskRunner to ResourceDownloader solves the issue.

BUG=803135

Change-Id: I44ebce8c72d65f99f90009ac9ca20709300cb2cd
Reviewed-on: https://chromium-review.googlesource.com/961528
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543131}
[modify] https://crrev.com/a419f154068880cc0806c78def9e660bd1a98fc6/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/a419f154068880cc0806c78def9e660bd1a98fc6/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/a419f154068880cc0806c78def9e660bd1a98fc6/content/browser/download/download_worker.cc
[modify] https://crrev.com/a419f154068880cc0806c78def9e660bd1a98fc6/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/a419f154068880cc0806c78def9e660bd1a98fc6/content/browser/download/resource_downloader.h

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94becc73add51d38cc89649c0186cde7759e4f34

commit 94becc73add51d38cc89649c0186cde7759e4f34
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 14 20:22:02 2018

move DownloadFile from content/ to components/download

This CL moved DownloadFile and DownloadFileImpl to components/download
There are no functional changes.

Bug: 803135
Change-Id: I3c40ce2ac56251a3fec9d0eb75acb12ce0c0b0d3
Reviewed-on: https://chromium-review.googlesource.com/957845
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543181}
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/DEPS
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/download_file_factory.cc
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/download_file_impl.cc
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/download_file_unittest.cc
[add] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/parallel_download_utils.cc
[add] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/internal/common/parallel_download_utils_unittest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/BUILD.gn
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/download_file.h
[add] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/download_file_factory.h
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/download_file_impl.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/download_ukm_helper.h
[rename] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/mock_input_stream.cc
[add] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/mock_input_stream.h
[add] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/parallel_download_utils.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/download/public/common/rate_estimator.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/BUILD.gn
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_browsertest.cc
[delete] https://crrev.com/b9d2beb8ee7990fc796457698965995935406f56/content/browser/download/download_file_factory.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_item_impl.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_job.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_job.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/drag_download_file.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/mock_download_file.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/mock_download_file.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/mock_download_job.h
[delete] https://crrev.com/b9d2beb8ee7990fc796457698965995935406f56/content/browser/download/mock_input_stream.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_utils.h
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/content/test/BUILD.gn

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e081b990583ebacb687b456671657d74707fd150

commit e081b990583ebacb687b456671657d74707fd150
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 14 22:44:54 2018

Move DownloadJob and DownloadJobImpl to components/download

Simply moving file locations, no functional change

BUG=803135

Change-Id: I994b4080639c54a9f92fc18f726032d4fab159a0
Reviewed-on: https://chromium-review.googlesource.com/959602
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543226}
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/internal/common/BUILD.gn
[rename] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/internal/common/download_job.cc
[rename] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/internal/common/download_job_impl.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/public/common/BUILD.gn
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/public/common/download_item.h
[rename] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/public/common/download_job.h
[add] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/components/download/public/common/download_job_impl.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/BUILD.gn
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/download_item_impl.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/download_job_factory.h
[delete] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/content/browser/download/download_job_impl.h
[delete] https://crrev.com/00f0b3424bab8fb3c029729b2b91c1fa73ee596b/content/browser/download/download_job_unittest.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/mock_download_job.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/mock_download_job.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/save_package_download_job.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/browser/download/save_package_download_job.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/public/test/fake_download_item.cc
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/public/test/fake_download_item.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/public/test/mock_download_item.h
[modify] https://crrev.com/e081b990583ebacb687b456671657d74707fd150/content/test/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7771e52df63c0fe347cc31d4b7d4947db6446ba5

commit 7771e52df63c0fe347cc31d4b7d4947db6446ba5
Author: Min Qin <qinmin@chromium.org>
Date: Tue Mar 20 00:59:48 2018

move ResourceDownloader to components/download

No functional changes, just moving the files
ResourceDownloader no longer has any dependencies on content/ now

Bug: 803135
Change-Id: If1be16e03f4581ec4fb6eec4051c22b37d75797f
Reviewed-on: https://chromium-review.googlesource.com/962966
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544239}
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/components/download/internal/common/BUILD.gn
[rename] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/components/download/public/common/BUILD.gn
[rename] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/components/download/public/common/resource_downloader.h
[add] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/components/download/public/common/url_download_handler.h
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/BUILD.gn
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/download_worker.cc
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/download_worker.h
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/parallel_download_job_unittest.cc
[delete] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/content/browser/download/url_download_handler.h
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/url_downloader.cc
[modify] https://crrev.com/7771e52df63c0fe347cc31d4b7d4947db6446ba5/content/browser/download/url_downloader.h

Project Member

Comment 31 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22

commit d9f3bbd14cb8da8a185fe07c225392fe1a0adb22
Author: Min Qin <qinmin@chromium.org>
Date: Fri Mar 23 20:42:15 2018

Move DownloadWorker from content/ to components/

This CL moves DownloadWorker from content/browser/download to
components/download.
DownloadWorker is used by ParallelDownloadJob for creating parallel
download requests.
To remove the dependencies on content/, following changes are made:
1. Introduces URLDownloadHandlerFactory class, this class allows content/
to inject its own URLDownloadHandler implementation (UrlDownloader) when
network service is disabled.
2. DownloadManager will always pass a SharedURLLoaderFactory to
ResourceDownloader. ResourceDownloader will later return it back to
DownloadManager, and DownloadManager will then pass it to the
ParallelDownloadJob through DownloadItemImpl.

Bug: 803135
Change-Id: I96dfb75daa438049df0dc9fd0fbe74abd5ff1d7a
Reviewed-on: https://chromium-review.googlesource.com/974120
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545570}
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/DEPS
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/download_utils.cc
[add] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/download_worker.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/resource_downloader.cc
[add] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/internal/common/url_download_handler_factory.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/BUILD.gn
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/download_utils.h
[rename] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/download_worker.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/resource_downloader.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/url_download_handler.h
[add] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/components/download/public/common/url_download_handler_factory.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/BUILD.gn
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_item_impl.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_job_factory.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_utils.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/download_utils.h
[delete] https://crrev.com/c9ff6f8534738d691d44f90b80c8858dceab924a/content/browser/download/download_worker.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/url_downloader.cc
[add] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/url_downloader_factory.cc
[add] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/browser/download/url_downloader_factory.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/public/browser/download_manager.h
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/public/test/mock_download_manager.cc
[modify] https://crrev.com/d9f3bbd14cb8da8a185fe07c225392fe1a0adb22/content/public/test/mock_download_manager.h

Project Member

Comment 32 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd6064f68d6747970cf0a038b1d5bc793202cb31

commit bd6064f68d6747970cf0a038b1d5bc793202cb31
Author: Min Qin <qinmin@chromium.org>
Date: Tue Mar 27 04:25:40 2018

Small refactoring on downloaditemimpl

Remove BrowserThread and WebContents references

Bug: 803135
Change-Id: I791bbeb0bd3d52c497c7bad7d035aaac7440f588
Reviewed-on: https://chromium-review.googlesource.com/981328
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546008}
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_item_impl.h
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/bd6064f68d6747970cf0a038b1d5bc793202cb31/content/browser/download/download_manager_impl.h

Project Member

Comment 33 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/addcd1672c2379778d155baa4b7d49ef65150d2d

commit addcd1672c2379778d155baa4b7d49ef65150d2d
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 28 23:25:47 2018

Move MockDownloadItem and MockDownloadFile to components/download

DownloadItem and DownloadFile are all in components/download
Move the mock classes to components/download too.
No functional changes, just file move.

Bug: 803135
Change-Id: I73dd2a5e90704830146dd09a599c458e0748a046
Reviewed-on: https://chromium-review.googlesource.com/978872
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546652}
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/android/download/download_manager_service_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/chromeos/drive/download_handler_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_commands_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_item_model_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_path_reservation_tracker_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_shelf_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_status_updater_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/safe_browsing/download_protection/download_feedback_service_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/cocoa/download/download_item_button_unittest.mm
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/cocoa/download/md_download_item_view_unittest.mm
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/content/public/all_download_item_notifier_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/public/common/BUILD.gn
[add] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/public/common/mock_download_file.cc
[rename] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/public/common/mock_download_file.h
[rename] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/public/common/mock_download_item.cc
[rename] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/components/download/public/common/mock_download_item.h
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/content/browser/download/download_manager_impl_unittest.cc
[delete] https://crrev.com/a535b4aadd9d3371a2e4fa42455646f18b2feffd/content/browser/download/mock_download_file.cc
[delete] https://crrev.com/a535b4aadd9d3371a2e4fa42455646f18b2feffd/content/browser/download/mock_download_job.cc
[delete] https://crrev.com/a535b4aadd9d3371a2e4fa42455646f18b2feffd/content/browser/download/mock_download_job.h
[modify] https://crrev.com/addcd1672c2379778d155baa4b7d49ef65150d2d/content/test/BUILD.gn

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b

commit 33f19f2bafc6df467163129a8eb6e74e6ad6ba5b
Author: Min Qin <qinmin@chromium.org>
Date: Thu Mar 29 06:35:06 2018

remove StoragePartitionImpl reference from DownloadItemImpl

This reference is not needed.
We can put the logic into DownloadManagerImpl.

BUG=803135

Change-Id: I7bdb0dfaa64d1860865566a67d8619fcd0f6bdaf
Reviewed-on: https://chromium-review.googlesource.com/985030
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546747}
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/components/download/public/common/download_url_parameters.h
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/33f19f2bafc6df467163129a8eb6e74e6ad6ba5b/content/browser/download/download_manager_impl.h

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330a613eee73a974613286101f108154bbe53fc6

commit 330a613eee73a974613286101f108154bbe53fc6
Author: Min Qin <qinmin@chromium.org>
Date: Fri Mar 30 05:17:50 2018

move ParallelDownloadJob from content/ to components/download

ParallelDownloadJob is introduced for parallel downloading.
This CL moves the class to components/download, where all the download code
will eventually locate.
Most of the code changes are moving files and fixing includes.
One major change is that DownloadManagerImpl now passes a URLRequestContextGetter
to DownloadItemImpl, and it will be passed to ParallelDownloadJob for issuing requests.

Bug: 803135
Change-Id: Ie83f6225e8f764a7aa46ad8c35ea03fce911b889
Reviewed-on: https://chromium-review.googlesource.com/985893
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547111}
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/DEPS
[rename] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/parallel_download_job.cc
[rename] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/parallel_download_job_unittest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/parallel_download_utils.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/internal/common/parallel_download_utils_unittest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/public/common/BUILD.gn
[rename] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/public/common/parallel_download_job.h
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/components/download/public/common/parallel_download_utils.h
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/BUILD.gn
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_item_impl.h
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_job_factory.h
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/browser/download/mock_download_item_impl.h
[delete] https://crrev.com/9fc1f60ba805c19e5588d5cd2a1613dc8bbc4312/content/browser/download/parallel_download_utils.cc
[delete] https://crrev.com/9fc1f60ba805c19e5588d5cd2a1613dc8bbc4312/content/browser/download/parallel_download_utils.h
[delete] https://crrev.com/9fc1f60ba805c19e5588d5cd2a1613dc8bbc4312/content/browser/download/parallel_download_utils_unittest.cc
[modify] https://crrev.com/330a613eee73a974613286101f108154bbe53fc6/content/test/BUILD.gn

Project Member

Comment 36 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f556e96a9447cdfe629e634a6a68ff37112263ab

commit f556e96a9447cdfe629e634a6a68ff37112263ab
Author: Min Qin <qinmin@chromium.org>
Date: Fri Mar 30 20:00:08 2018

Remove BrowserContext dependency from DownloadItemImpl

All the related methods is moved into DownloadItemImplDelegate

Bug: 803135
Change-Id: If874d29cb9f9a504a80b6098dee454498eaae520
Reviewed-on: https://chromium-review.googlesource.com/986652
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547249}
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_item_impl.h
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_item_impl_delegate.cc
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_item_impl_delegate.h
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/f556e96a9447cdfe629e634a6a68ff37112263ab/content/browser/download/download_manager_impl.h

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd

commit 3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd
Author: Min Qin <qinmin@chromium.org>
Date: Mon Apr 02 19:26:50 2018

move DownloadJobFactory from content/ to components/

Just moving the files, no functional changes.

BUG=803135

Change-Id: I4784172d7b41152531ae3cb7e569613b66132cc7
Reviewed-on: https://chromium-review.googlesource.com/988416
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547485}
[modify] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/internal/common/BUILD.gn
[add] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/internal/common/download_job_factory.cc
[add] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/internal/common/save_package_download_job.cc
[modify] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/public/common/BUILD.gn
[rename] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/public/common/download_job_factory.h
[add] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/components/download/public/common/save_package_download_job.h
[modify] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/content/browser/BUILD.gn
[modify] https://crrev.com/3ad5cfe39b30242addb3b778f3cb7a9bd86f60fd/content/browser/download/download_item_impl.cc
[delete] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/content/browser/download/download_job_factory.cc
[delete] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/content/browser/download/save_package_download_job.cc
[delete] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/content/browser/download/save_package_download_job.h

Project Member

Comment 38 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98db6a597848e4f840b232f4da3583da97894908

commit 98db6a597848e4f840b232f4da3583da97894908
Author: Min Qin <qinmin@chromium.org>
Date: Tue Apr 03 19:09:25 2018

move DownloadItemImpl and DownloadItemImplDelegate to components/download

Just move the files and resolve all the includes, no functional change.

BUG=803135

Change-Id: Ib5a9d7958639526da697ba6556b0d9433d544cee
Reviewed-on: https://chromium-review.googlesource.com/991076
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547786}
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/downloader/in_progress/BUILD.gn
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/internal/common/DEPS
[rename] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/internal/common/download_item_impl.cc
[rename] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/internal/common/download_item_impl_delegate.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/public/common/BUILD.gn
[rename] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/public/common/download_item_impl.h
[rename] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/components/download/public/common/download_item_impl_delegate.h
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/BUILD.gn
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_item_factory.h
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_request_core_unittest.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_utils.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/download_utils.h
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/mock_download_item_impl.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/save_package.cc
[modify] https://crrev.com/98db6a597848e4f840b232f4da3583da97894908/content/browser/download/save_package.h

Project Member

Comment 39 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ee0c516f01e49746d7f719d4e1406bac3f17449

commit 7ee0c516f01e49746d7f719d4e1406bac3f17449
Author: Min Qin <qinmin@chromium.org>
Date: Thu Apr 05 21:25:27 2018

Move MockDownloadItemImpl and DownloadItemFactory to components/download

These class no longer has any dependencies on content/.
Move them to components/download for servicification work.
Also move some classes from components/download/public to
components/download/internal.

BUG=803135

Change-Id: I7f41ba131d7a184da2090cad733c9f5b3106aadc
Reviewed-on: https://chromium-review.googlesource.com/996020
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548559}
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_file_impl.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_job_factory.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_job_impl.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_job_impl.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_worker.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/download_worker.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_job.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_job.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_job_unittest.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_utils.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_utils.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/parallel_download_utils_unittest.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/save_package_download_job.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/internal/common/save_package_download_job.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/BUILD.gn
[add] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/download_item_factory.cc
[add] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/download_item_factory.h
[add] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/mock_download_item_impl.cc
[rename] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/mock_download_item_impl.h
[add] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/components/download/public/common/parallel_download_configs.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/browser/BUILD.gn
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/browser/download/download_browsertest.cc
[delete] https://crrev.com/6263bcf0ec9f112b5f0d84fc059c759302bd8c67/content/browser/download/download_item_factory.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/browser/download/download_manager_impl_unittest.cc
[delete] https://crrev.com/6263bcf0ec9f112b5f0d84fc059c759302bd8c67/content/browser/download/mock_download_item_impl.cc
[modify] https://crrev.com/7ee0c516f01e49746d7f719d4e1406bac3f17449/content/test/BUILD.gn

Project Member

Comment 40 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/361abda7d8f3b7f02d4cb5a327ebf0a294f54918

commit 361abda7d8f3b7f02d4cb5a327ebf0a294f54918
Author: Min Qin <qinmin@chromium.org>
Date: Fri Apr 06 17:22:03 2018

move download_item_impl_unittest.cc to components/download

BUG=803135

Change-Id: Ic015aad8a0ebeaecabd50b1cce18d520bfc9d053
Reviewed-on: https://chromium-review.googlesource.com/998614
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548834}
[modify] https://crrev.com/361abda7d8f3b7f02d4cb5a327ebf0a294f54918/components/download/internal/common/BUILD.gn
[rename] https://crrev.com/361abda7d8f3b7f02d4cb5a327ebf0a294f54918/components/download/internal/common/download_item_impl_unittest.cc
[modify] https://crrev.com/361abda7d8f3b7f02d4cb5a327ebf0a294f54918/content/test/BUILD.gn

Project Member

Comment 41 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb03a3df7cd7097fb58528c8284b044e1b1059d

commit 0cb03a3df7cd7097fb58528c8284b044e1b1059d
Author: Min Qin <qinmin@chromium.org>
Date: Thu Apr 12 14:48:18 2018

Add a new interface to get URLLoaderFactory for components/download

For download service, we are going to pass a class that retrieves URLLoaderFactory.
This CL defines a common interface for that purpose.
And the implementation can support either a blob url or a network url.

BUG=803135

Change-Id: I505e025fc54553753180f05b97fbd3c4b654253a
Reviewed-on: https://chromium-review.googlesource.com/1007974
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550192}
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/download_task_runner.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/download_url_loader_factory_getter.cc
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/BUILD.gn
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/download_task_runner.h
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/download_url_loader_factory_getter.h
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/BUILD.gn
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/blob_download_url_loader_factory_getter.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/blob_download_url_loader_factory_getter.h
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/download_manager_impl.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/network_download_url_loader_factory_getter.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/network_download_url_loader_factory_getter.h

Project Member

Comment 42 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c430ae59f895b5d2d1516f9285fc7cda4e589bd3

commit c430ae59f895b5d2d1516f9285fc7cda4e589bd3
Author: Min Qin <qinmin@chromium.org>
Date: Fri Apr 13 20:30:35 2018

Small refactoring: Check whether URL can be requested on UI thread

ChildProcessSecurityPolicy can be used on any thread.
This CL moves the security policy check to UI thread, so that all
the content/ dependencies in BeginResourceDownload() are removed()

BUG=803135

Change-Id: I97ecb0788f099d010627599275553ad268404345
Reviewed-on: https://chromium-review.googlesource.com/1008869
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550746}
[modify] https://crrev.com/c430ae59f895b5d2d1516f9285fc7cda4e589bd3/content/browser/download/download_manager_impl.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb03a3df7cd7097fb58528c8284b044e1b1059d

commit 0cb03a3df7cd7097fb58528c8284b044e1b1059d
Author: Min Qin <qinmin@chromium.org>
Date: Thu Apr 12 14:48:18 2018

Add a new interface to get URLLoaderFactory for components/download

For download service, we are going to pass a class that retrieves URLLoaderFactory.
This CL defines a common interface for that purpose.
And the implementation can support either a blob url or a network url.

BUG=803135

Change-Id: I505e025fc54553753180f05b97fbd3c4b654253a
Reviewed-on: https://chromium-review.googlesource.com/1007974
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550192}
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/download_task_runner.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/internal/common/download_url_loader_factory_getter.cc
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/BUILD.gn
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/download_task_runner.h
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/components/download/public/common/download_url_loader_factory_getter.h
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/BUILD.gn
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/blob_download_url_loader_factory_getter.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/blob_download_url_loader_factory_getter.h
[modify] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/download_manager_impl.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/network_download_url_loader_factory_getter.cc
[add] https://crrev.com/0cb03a3df7cd7097fb58528c8284b044e1b1059d/content/browser/download/network_download_url_loader_factory_getter.h

Project Member

Comment 44 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c430ae59f895b5d2d1516f9285fc7cda4e589bd3

commit c430ae59f895b5d2d1516f9285fc7cda4e589bd3
Author: Min Qin <qinmin@chromium.org>
Date: Fri Apr 13 20:30:35 2018

Small refactoring: Check whether URL can be requested on UI thread

ChildProcessSecurityPolicy can be used on any thread.
This CL moves the security policy check to UI thread, so that all
the content/ dependencies in BeginResourceDownload() are removed()

BUG=803135

Change-Id: I97ecb0788f099d010627599275553ad268404345
Reviewed-on: https://chromium-review.googlesource.com/1008869
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550746}
[modify] https://crrev.com/c430ae59f895b5d2d1516f9285fc7cda4e589bd3/content/browser/download/download_manager_impl.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a62630c0a1c5b90af80c937d5efc27807ca0b997

commit a62630c0a1c5b90af80c937d5efc27807ca0b997
Author: Min Qin <qinmin@chromium.org>
Date: Fri Apr 20 21:35:00 2018

Move some download implementation for network service to components/

Once download becomes a service, Chrome needs to start download without
content::DownloadManager.
Split some DownloadManager functionalities into InProgressDownloadManager.
The InProgressDownloadManager will manage the InProgressCache,
and own the UrlDownloadHandlers.
This CL moves the regular URL download and navigation interception logic
into InProgressDownloadManager, so that InProgressDownloadManager now
owns the UrlDownloadHandlers.

BUG=803135

Change-Id: I97c81b9f9f3d88d5823fe8b94456e5b4d033a029
Reviewed-on: https://chromium-review.googlesource.com/1012987
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552481}
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/DEPS
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/download_worker.cc
[add] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/resource_downloader.cc
[rename] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/resource_downloader.h
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/internal/common/url_download_handler_factory.cc
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/public/common/BUILD.gn
[add] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/public/common/in_progress_download_manager.h
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/components/download/public/common/url_download_handler.h
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/a62630c0a1c5b90af80c937d5efc27807ca0b997/content/browser/download/download_manager_impl.h

Project Member

Comment 46 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/950748a25fbf81027188f664d29c8d4a213dad51

commit 950748a25fbf81027188f664d29c8d4a213dad51
Author: Min Qin <qinmin@chromium.org>
Date: Tue Apr 24 23:32:18 2018

move InProgressCache and some methods into InProgressDownloadManager

Currently the InProgressCache is owned by ChromeDownloadManagerDelegate.
In order for download to work as a service,  the InProgressDownloadManager
should be able to manage InProgressCache. It should read from the cache
and recreate the download before resuming it.
This CL moves the InProgressCache from ChromeDownloadManagerDelegate into
InProgressDownloadmanager. And it also moves StartDownload() method as
this is needed when resuming the download without DownloadManagerImpl.
DownloadManagerImpl now becomes a delegate of InProgressDownloadManager.
It will provide InProgressDownloadManager the information to create a new
download. When resuming a download after launching download service,
DownloadManagerImpl is not needed.

BUG=803135

Change-Id: Ie7a22213e935638dac10dd82d2e079326e8083f2
Reviewed-on: https://chromium-review.googlesource.com/1024723
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553359}
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/chrome/browser/download/chrome_download_manager_delegate.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/chrome/common/chrome_constants.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/chrome/common/chrome_constants.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/downloader/in_progress/download_entry.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/downloader/in_progress/in_progress_cache.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/downloader/in_progress/in_progress_cache_impl.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/public/common/download_utils.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/components/download/public/common/in_progress_download_manager.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/download_utils.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/download_utils.h
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/browser/download/save_package.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/public/browser/download_manager_delegate.cc
[modify] https://crrev.com/950748a25fbf81027188f664d29c8d4a213dad51/content/public/browser/download_manager_delegate.h

Project Member

Comment 47 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7a0b781421f10352803028c9e5c10ea011d2c7

commit 9f7a0b781421f10352803028c9e5c10ea011d2c7
Author: Min Qin <qinmin@chromium.org>
Date: Fri May 04 20:38:07 2018

introduce new proto messages for in-progress downloads

Splits downloadEntry into UkmInfo and InProgressInfo,
added new information needed to resume the download item after chrome crashes.


Bug: 803135
Change-Id: Ided64d9801a3e8e1d8390a4190d17aa3b58d652c
Reviewed-on: https://chromium-review.googlesource.com/1036539
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556179}
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/BUILD.gn
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/in_progress_conversions.cc
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/in_progress_conversions.h
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/in_progress_conversions_unittest.cc
[add] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/in_progress_info.cc
[add] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/in_progress_info.h
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/proto/download_entry.proto
[add] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/ukm_info.cc
[add] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/downloader/in_progress/ukm_info.h
[modify] https://crrev.com/9f7a0b781421f10352803028c9e5c10ea011d2c7/components/download/public/common/download_item.h

Comment 48 by qin...@chromium.org, May 11 2018

Blockedon: 842245

Project Member

Comment 49 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a5a86ca0b36f5a45883171d5855853d4c0cc04

commit 66a5a86ca0b36f5a45883171d5855853d4c0cc04
Author: Min Qin <qinmin@chromium.org>
Date: Sat May 12 00:50:33 2018

Add new in-progress classes for corresponding proto messages

Adding new classes to be used by the C++ code.
These classes will be serialized into the proto messages

Bug: 803135
Change-Id: Ib0cae24a8d0cc7ff8fee5a14d6c80070b092b8ff
Reviewed-on: https://chromium-review.googlesource.com/1050797
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558074}
[modify] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/BUILD.gn
[add] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/download_db_entry.cc
[add] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/download_db_entry.h
[add] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/download_info.cc
[add] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/download_info.h
[modify] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/in_progress_conversions.cc
[modify] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/in_progress_conversions.h
[modify] https://crrev.com/66a5a86ca0b36f5a45883171d5855853d4c0cc04/components/download/downloader/in_progress/in_progress_conversions_unittest.cc

Comment 50 by dxie@chromium.org, May 30 2018

Labels: Hotlist-KnownIssue

Comment 51 by qin...@chromium.org, Aug 20

Status: Fixed (was: Assigned)

►

Issue 803135 link

Issue metadata

Move content/browser/download to components/download

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 23 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jan 31 2018

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Feb 3 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Feb 9 2018

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Feb 14 2018

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Feb 15 2018

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Feb 21 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Feb 23 2018

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Feb 23 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Feb 23 2018

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Feb 28 2018

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Mar 1 2018

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Mar 3 2018

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Mar 3 2018

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Mar 5 2018

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Mar 5 2018

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Mar 7 2018

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Mar 7 2018

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Mar 8 2018

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Mar 9 2018

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Mar 9 2018

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Mar 10 2018

Comment 24 Deleted

Comment 25 by qin...@chromium.org, Mar 13 2018

Comment 25 Deleted

Comment 26 by chongz@chromium.org, Mar 13 2018

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Mar 14 2018

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Mar 14 2018

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Mar 14 2018

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Mar 20 2018

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Mar 23 2018

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Mar 27 2018

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Mar 28 2018

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Mar 29 2018

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Mar 30 2018

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Mar 30 2018

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Apr 2 2018

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Apr 3 2018

Comment 38 Deleted