WPT import https://crrev.com/c/870690 introduced new failures in external/wpt/svg: List of new failures: external/wpt/svg/path/distance/pathLength-positive.svg [ Failure ] external/wpt/svg/path/distance/pathLength-zero.svg [ Failure ] This import contains upstream changes from 262e3e1a018b2ee3359173b8f83f4180a246a0ce to 93c659851f1143a573ad7749ffb92b30ddb61826: Remove all remaining references to b2g (#9052): https://github.com/w3c/web-platform-tests/commit/93c659851f1143a573ad7749ffb92b30ddb61826 refactor: use assert_unreached where possible (#9045): https://github.com/w3c/web-platform-tests/commit/d5566dc52e0fc93255e373be97be2af6a27672e2 Merge pull request #8717 from ewilligers/SVGAnimatedPathData-removed: https://github.com/w3c/web-platform-tests/commit/4eb38a47842820a8e57e9ab9c01d7f5ad752d559 Merge pull request #8716 from ewilligers/SVGGeometryElement-rect: https://github.com/w3c/web-platform-tests/commit/f89badbe4ed1514d917d476de31ba2d7447a4753 Merge pull request #8714 from ewilligers/pathLength: https://github.com/w3c/web-platform-tests/commit/3bd9f4636c782673a210cf9b61a6c0bcb43703ea Add slow etc. markers to some tools.wpt tests: https://github.com/w3c/web-platform-tests/commit/b4b9ec466d8f719da9876c00afcf709529f1e4a6 Fix tools.wpt.stability throwing because of a cyclic import: https://github.com/w3c/web-platform-tests/commit/223c99d272e10e759d5c11f605d632db39043b76 css 2.1 class selector tests, also for Selectors 3: https://github.com/w3c/web-platform-tests/commit/9b10724c89b7ac79e1de97233e2f36db58d507f3 Test that SVGAnimatedPathData is not supported: https://github.com/w3c/web-platform-tests/commit/96b4f91965ddfedbc75aae257bd10acf02f63424 [affecting this directory] Test that geometry elements have path length: https://github.com/w3c/web-platform-tests/commit/2e72b5110ed5e2cd8938eff04109535157221cd0 [affecting this directory] Test pathDistance attribute: https://github.com/w3c/web-platform-tests/commit/58002c06dd3fbaed70e2a13f31118b659c769ce3 [affecting this directory]
We don't support this ATM (AFAICR), I think I have an implementation on a branch that I can untangle though. (I'd be interested to see the "support matrix" though.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00c4d7d6f69574516058cf2fa3eb5c21ee267ba0 commit 00c4d7d6f69574516058cf2fa3eb5c21ee267ba0 Author: Fredrik Söderquist <fs@opera.com> Date: Tue Jan 30 20:08:24 2018 [PE] Fix edge-cases in SVGGeometryElement::PathLengthScaleFactor Update the computation of the scale factor to match what the spec [1] has to say about a value of zero: i.e yield (near) infinity rather than zero. Also update the case where the computed path length is zero. [1] https://svgwg.org/svg2-draft/paths.html#PathLengthAttribute Bug: 803127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6816b6bdd47cbaee90e8ad22e16d1dcf44498c7d Reviewed-on: https://chromium-review.googlesource.com/893184 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533003} [modify] https://crrev.com/00c4d7d6f69574516058cf2fa3eb5c21ee267ba0/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0 commit af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Feb 01 17:26:37 2018 [PE] Support 'pathLength' for <path>s referenced from <textPath> A 'pathLength' attribute on a <path> referenced from <textPath> will affect the starting offset on the path as computed from 'startOffset' attribute. Refactor the PathPositionMapper setup a bit so that the start offset is computed together with all the other path related state. Bug: 803127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id12c88580dd74db403598d2aa05ac9764ad68cdb Reviewed-on: https://chromium-review.googlesource.com/897626 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533712} [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/LayoutTests/external/wpt/svg/path/distance/pathLength-positive-percentage.svg [add] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/LayoutTests/external/wpt/svg/path/distance/pathLength-zero-percentage-ref.svg [add] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/LayoutTests/external/wpt/svg/path/distance/pathLength-zero-percentage.svg [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/layout/api/LineLayoutSVGTextPath.h [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp [modify] https://crrev.com/af7076ff6dd6f0279c0aa23d5c2ecd93ced6d5b0/third_party/WebKit/Source/core/svg/SVGGeometryElement.h
Comment 1 by schenney@chromium.org
, Jan 18 2018Labels: Test-Layout Pri-2 Type-Bug
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)