New issue
Advanced search Search tips

Issue 803117 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Improve appearance modal UI in reader mode

Project Member Reported by k...@chromium.org, Jan 17 2018

Issue description

Right now the "appearance" modal UI when you open a page in reader mode do not have controls far enough apart, the scrubber does not work reliably, and the drop-down only has one value.

We should fix this appearance issue.
 

Comment 1 by k...@chromium.org, Jan 17 2018

Cc: wychen@chromium.org
 Issue 803113  has been merged into this issue.

Comment 2 by wychen@chromium.org, Jan 18 2018

Labels: Needs-Bisect
About the drop down only having one value, preliminary debugging showed that
  getStringArray(R.array.distiller_mode_font_family_values)
strangely only return 1 element while 3 are expected.

For this particular issue, it's a recent regression. Known good: 65.0.3299.6 Dev, known bad: ToT. Could we get a bisect to know when this regression happened? Per revision would be nice.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c235742b6517d5dd02f80ad8caf2650af3033755

commit c235742b6517d5dd02f80ad8caf2650af3033755
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Jan 18 23:58:14 2018

Improve appearance preference UI in reader mode

Larger margin between controls, larger touchable area of seeker,
and fixed drop-down menu with all items.

Bug:  803117 
Change-Id: Ic8b5b534aa684f09a5e28ad20685387fabc3eb23
Reviewed-on: https://chromium-review.googlesource.com/874753
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530350}
[modify] https://crrev.com/c235742b6517d5dd02f80ad8caf2650af3033755/chrome/android/java/res/layout/distilled_page_prefs_view.xml
[delete] https://crrev.com/8a8bc0bc5a8fb97023d4a3469786f9c62f147fdb/chrome/android/java/res/values/arrays.xml
[modify] https://crrev.com/c235742b6517d5dd02f80ad8caf2650af3033755/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java

Comment 4 by wychen@chromium.org, Jan 19 2018

The symptom is fixed by a workaround, but the issue about getStringArray() mentioned in #c2 is still there.
Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback
wychen@ -- Could you please provide a sample test file where the issue can be reproduced. It would help us in reproducing the issue and provide per-revision bisect.

Thanks!

Comment 6 by wychen@chromium.org, Jan 22 2018

To reproduce this issue:
- Go to chrome://flags and set "Reader Mode triggering" to "Always".
- Visit any page, and tap "Show mobile-friendly view".
- Tap menu, and tap appearance.

Expected: font drop down menu has 3 items.
Buggy state: the menu only has one item.

Comment 7 by wychen@chromium.org, Jan 22 2018

Status: Fixed (was: Assigned)
About drop down menu having only one item, it is tracked in issue 797626, so closing this one.

Comment 8 by wychen@chromium.org, Jan 22 2018

Cc: -wychen@chromium.org mdjones@chromium.org
Labels: -Needs-Bisect

Sign in to add a comment