New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803104 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
perezju@chromium.org
█ kbr@chromium.org
nedngu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SeriallyExecutedBrowserTestCase calls "browser_options" what should be "finder_options"

Project Member Reported by perezju@chromium.org, Jan 17 2018 
See e.g. callers here:
https://cs.chromium.org/search/?q=%5C.SetBrowserOptions+-file:%5Esrc/third_party/android_tools+-file:%5Einfra/infra/services/android_docker&type=cs

I propose to rename the method SetFinderOptions, and rename the private variable within the class.

Comment 1 by nedngu...@google.com, Jan 17 2018

Cc: kbr@chromium.org
Components: Speed>Telemetry

Comment 2 by perezju@chromium.org, Jan 17 2018

Blocking: -801578
Cc: -nednguyen@chromium.org perezju@chromium.org nedngu...@google.com
Owner: ----
Status: Available (was: Started)
Hmm, looking at it again, SeriallyExecutedBrowserTestCase has *both* a _finder_options and a _browser_options private attributes, although both of them *are* FinderOptions objects.

This is confusing, but I don't know what will be a better solution. I'll remove this as blocker from  issue 801578 , and just do the least amount of work necessary to keep things working without a rename.

Keeping open anyway in case there are any better ideas on how to deal with this.

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment