New issue
Advanced search Search tips

Issue 803074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK when opening chrome://signin-internals on Android

Project Member Reported by bauerb@chromium.org, Jan 17 2018

Issue description

Steps to reproduce:
1) Install a Debug build
2) Open chrome://signin-internals

[FATAL:shared_resources_data_source.cc(208)] Check failed: it != GetResourcesMap().end(). missing shared resource: polymer/v1_0/paper-button/paper-button.html

Stack Trace:
  RELADDR   FUNCTION
  00049e44  <UNKNOWN>
  000475e3  <UNKNOWN>
  0001d8a5  <UNKNOWN>
  000193f1  <UNKNOWN>
  00017034  <UNKNOWN>
  v------>  base::debug::(anonymous namespace)::DebugBreak()
  00096cb1  base::debug::BreakDebugger()
  000a85ab  logging::LogMessage::~LogMessage()
  00acd95d  content::SharedResourcesDataSource::IsGzipped(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) const
  00acf3a5  content::URLDataManagerBackend::StartRequest(net::URLRequest const*, content::URLRequestChromeJob*)
  00ace89b  content::URLRequestChromeJob::StartAsync()
  0008e8dd  base::OnceCallback<void ()>::Run() &&
  000971ad  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
  000ad355  base::internal::IncomingTaskQueue::RunTask(base::PendingTask*)
  000af2eb  base::MessageLoop::RunTask(base::PendingTask*)
  000af5d7  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
  000af6ad  base::MessageLoop::DoWork()
  000b1215  base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
  000af0af  base::MessageLoop::Run(bool)
  000c76e1  base::RunLoop::Run()
  000e8959  base::Thread::Run(base::RunLoop*)
  0085b78d  content::BrowserThreadImpl::IOThreadRun(base::RunLoop*)
  0085b873  content::BrowserThreadImpl::Run(base::RunLoop*)
  000e8c19  base::Thread::ThreadMain()
  000e3f29  base::(anonymous namespace)::ThreadFunc(void*)
  000470b3  <UNKNOWN>
  00019e3d  <UNKNOWN>

 

Comment 1 by dbeam@chromium.org, Jan 18 2018

Cc: msarda@chromium.org
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
that DCHECK() makes sense as ... Android doesn't bundle Polymer ;) and <paper-button> won't work there.

I'll just wrap these includes in grit <if>s as <paper-button> only seems to actually be shown/used on desktop anyways.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a569bd7d64eee6c568ee8c09fc41dded6af117

commit f1a569bd7d64eee6c568ee8c09fc41dded6af117
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 18 19:14:13 2018

Fix DCHECK() about broken import import on chrome://signin-internals

Polymer is not included on mobile and these imports are only needed for
the desktop UI, so exclude them.

R=msarda@chromium.org
BUG= 803074 

Change-Id: Ic3c9a84a3b174bb18375cd69d3cddc79f83f7252
Reviewed-on: https://chromium-review.googlesource.com/872052
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530223}
[modify] https://crrev.com/f1a569bd7d64eee6c568ee8c09fc41dded6af117/components/signin/core/browser/resources/signin_index.html

Comment 3 by dbeam@chromium.org, Jan 19 2018

Status: Fixed (was: Started)

Sign in to add a comment