New issue
Advanced search Search tips

Issue 803063 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

GTK window buttons disappear when exiting fullscreen

Reported by misterma...@gmail.com, Jan 17 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.85 Safari/537.36

Steps to reproduce the problem:
It's a bit more complicated than what I've described above, actually. To reproduce the issue (in Gnome Shell 3.26.2, haven't tested other DEs):

1. Disable system title bars and window borders
2. Go fullscreen either by pressing F11 or by watching a fullscreen video
3.  While keeping the video or browser in fullscreen, switch to another program either through Alt-tab or through the overview (Super-key in Gnome-Shell)
4. Get back to the Chrome window that is in full-screen
5. Exit fullscreen (F11 or Escape)

What is the expected behavior?
The Window buttons should still be there.

What went wrong?
The window buttons disappear and you have to minimize/maximize the window (or re-switch program through Alt-tab and come back) for them to reappear.

Did this work before? No 

Chrome version: 64.0.3282.85  Channel: beta
OS Version: Ubuntu 17.10
Flash Version: Shockwave Flash 28.0 r0

As for the "it never worked" part, I have had this issue consistently since I disabled system title bars and window borders when GTK theming was enabled for Window buttons in Chrome's client-side decorations.

It's obviously a very minor issue (fixed in a split second when it happens, basically no real hassle), but I thought I'd make a bug report anyway in case it can be permanently fixed easily.
 
Labels: Needs-Triage-M64
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
I'm able to repro this issue too
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e

commit c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jan 18 22:42:44 2018

Relayout frame buttons when fullscreen state changes

This CL fixes a bug where frame buttons are not rendered after these steps:
1. Maximize a video
2. Alt-tab to another app
3. Alt-tab back to the video
4. Unmaximize the video

The buttons were getting rendered at zero-size since the tabstrip has 0 height
when the video is playing.  The solution is to relayout the buttons when the
maximized state changes.

BUG= 803063 
R=sky

Change-Id: Ic1c1e98ce08ead6e8dee284a333515ed022520a5
Reviewed-on: https://chromium-review.googlesource.com/874992
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530315}
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.h
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/c6f5e91e2baef8be1b2a36b9f0af035ea3683c4e/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Status: Fixed (was: Started)
Labels: TE-Verified-M65 TE-Verified-65.0.3325.0
Tested this issue on Ubuntu 17.10 on the latest Chrome build 65.0.3325.0 by following the steps mentioned in the original comment.

Can observe that after following the above steps, the window buttons are seen.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
803063.webm
3.7 MB View Download

Sign in to add a comment