New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803038 link

Starred by 1 user
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: Jan 2018
Cc:
bsazonov@chromium.org
█ escordeiro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Navigations to Google/Youtube aren't blocked for unauthenticated child accounts

Project Member Reported by bauerb@chromium.org, Jan 17 2018 
From b/35726215, steps to reproduce:

1) Add a child account to the device
2) Change the child account's password
3) In Chrome, navigate to a Google SRP or to Youtube

Expected:
The navigation should be deferred while the Gaia reauth screen is shown

Actual:
The navigation succeeds.

It looks like we need to check the |valid| flag in the list of accounts returned by GaiaCookieManagerService::ListAccounts. Don't know why it stopped working -- maybe a Gaia change that used to show accounts with invalid credentials as signed out and now doesn't anymore?
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfdba30c319eff9a655c71051b3ebb1750609c1e

commit bfdba30c319eff9a655c71051b3ebb1750609c1e
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Fri Jan 19 15:50:22 2018

Check for account validity in ChildAccountService::GetGoogleAuthState().

If the credentials are invalid, the account is still listed as signed
in, but invalid.

Bug:  803038 ,b/35726215
Change-Id: I2613a1478b53cb3d6d08af065d584b958c0048c5
Reviewed-on: https://chromium-review.googlesource.com/870314
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530517}
[modify] https://crrev.com/bfdba30c319eff9a655c71051b3ebb1750609c1e/chrome/browser/supervised_user/child_accounts/child_account_service.cc
[add] https://crrev.com/bfdba30c319eff9a655c71051b3ebb1750609c1e/chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
[modify] https://crrev.com/bfdba30c319eff9a655c71051b3ebb1750609c1e/chrome/test/BUILD.gn

Comment 2 by escordeiro@chromium.org, Jan 24 2018

Cc: escordeiro@chromium.org

Comment 3 by bauerb@chromium.org, Jan 30 2018

Status: Fixed (was: Started)
►

Sign in to add a comment