Regression: Incorrect placeholder text (i.e. Undefined) is seen on feedback overlay.
Reported by
db...@etouch.net,
Jan 17 2018
|
||||||||||
Issue descriptionChrome Version: 65.0.3322.3 (Official Build)Revision 8758ca55b13d4f2082b2ed9269fce8f37f37c577-refs/branch-heads/3322@{#6}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3) Pre-condition: Sign in into browser with valid credentials. Test URL: https://chrome.google.com/webstore/detail/google-hangouts/nckgahadagoaajjgafhacjanaoiihapd?hl=en What steps will reproduce the problem? (1) Launch chrome, navigate to above URL and click on ADD TO CHROME button. (2) Launch Hangouts extension and click on Options and then select Send Feedback option. (3) Observe placeholder text. Actual: Incorrect placeholder text (i.e. Undefined) is seen on feedback overlay. Expected: Placeholder text should seen proper on feedback overlay. This is a regression issue, broken in 'M65' and provide bisect usion bisect-per-revision script: Good build: 65.0.3311.0(526880) Bad build: 65.0.3312.0(527163) You are probably looking for a change made after 529082 (known good), but no later than 529083 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/52e1d55c1ef39797050456f93ca6681ada56fb63..286fcbbbf520fae74cb3b6ae342644d684bc9d31 Suspect : https://chromium.googlesource.com/chromium/src/+/286fcbbbf520fae74cb3b6ae342644d684bc9d31
,
Jan 18 2018
weidongg@ I'm still OOO sick. Could you please fix this issue. It's really simple. All you need is to change this line: https://cs.chromium.org/chromium/src/chrome/browser/resources/feedback/js/feedback.js?q=feedback.js&sq=package:chromium&l=324 to: if (feedbackInfo.descriptionPlaceholder) $('description-text').placeholder = feedbackInfo.descriptionPlaceholder;
,
Jan 18 2018
Sure, I just tested, it fixed the problem.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58f6e6d431069413ac0dabd478f0b1956a1babf5 commit 58f6e6d431069413ac0dabd478f0b1956a1babf5 Author: Weidong Guo <weidongg@chromium.org> Date: Fri Jan 19 20:15:28 2018 Fix incorrect placeholder text in feedback dialog. Changes: Avoid showing description placeholder if it is undefined. BUG= 803030 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iecdfddaa53dc0cb1343b5ba66060df74cbc6da87 Reviewed-on: https://chromium-review.googlesource.com/874550 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530597} [modify] https://crrev.com/58f6e6d431069413ac0dabd478f0b1956a1babf5/chrome/browser/resources/feedback/js/feedback.js
,
Jan 19 2018
Thank you, Weidong!
,
Jan 19 2018
You are welcome.
,
Feb 1 2018
,
Feb 1 2018
Issue seen on ChromeOS as well. Build: 10323.10.0, 65.0.3325.35 dev-channel
,
Feb 1 2018
weidongg@ Could you merge the fix to M65?
,
Feb 1 2018
Sure
,
Feb 1 2018
I thought this landed before branch already, no?
,
Feb 1 2018
No, branch for M65 was Jan 18 which was right before I landed this change.
,
Feb 2 2018
,
Feb 2 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cfbf35f3dce7ab3dd9c4dc9cc7242a9380df4f4 commit 9cfbf35f3dce7ab3dd9c4dc9cc7242a9380df4f4 Author: Weidong Guo <weidongg@chromium.org> Date: Fri Feb 02 21:54:23 2018 Fix incorrect placeholder text in feedback dialog. Changes: Avoid showing description placeholder if it is undefined. TBR=xiyuan@chromium.org BUG= 803030 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iecdfddaa53dc0cb1343b5ba66060df74cbc6da87 Reviewed-on: https://chromium-review.googlesource.com/874550 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530597}(cherry picked from commit 58f6e6d431069413ac0dabd478f0b1956a1babf5) Reviewed-on: https://chromium-review.googlesource.com/899544 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#272} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/9cfbf35f3dce7ab3dd9c4dc9cc7242a9380df4f4/chrome/browser/resources/feedback/js/feedback.js
,
Feb 6 2018
Just to update: Rechecked above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.3) using Dev build #65.0.3325.51 and it is fixed and working as intended. Kindly refer attached screen cast for the same. Thank you. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by nyerramilli@chromium.org
, Jan 17 2018