New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Focus is not seen on Headphone icon in Ubertray

Project Member Reported by kebalaji@chromium.org, Jan 17 2018

Issue description

Chrome Version: 65.0.3322.0/10315.0.0 dev channel Kip,Paine,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Connect a Earphone/Headphone
(2)Click on Ubertray>> Tab until focus reaches Headphone icon>> Click Enter
(3)Again tab and enter on Back arrow >> Observe the focus

Expected: Focus should be seen on Headphone icon as in case of other options like Accessibilty etc.,
Actual: Instead, focus goes missing and when tabbed focus is seen on Sign-out button

This is a Non-Regression issue seen from M62

NOTE: 1. Issue is not seen in windows and Linux
      2. Issue is seen in M63 stable and M64 beta also.

@Tbuckley: Please confirm the issue
 
 
ActualHeadphone.webm
1.1 MB View Download
Cc: tbuck...@chromium.org
Labels: -M-65 M-66
Owner: zork@chromium.org
Confirmed. Most rows return focus back to the row when clicking the back arrow. Moving to M66.
Labels: Inhouse-HYD-Reported
Cc: zork@chromium.org
Owner: sammiequon@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a071f1771aec616e6038635f71ebf80db2d9c319

commit a071f1771aec616e6038635f71ebf80db2d9c319
Author: Sammie Quon <sammiequon@google.com>
Date: Wed May 02 17:53:25 2018

system: When press back on audio detailed view, focus headphone button.

By default the back button will tell focus to go on the tray associated
with the detail view. This is usually the view that activated the
detail view, except in the case of the volume view whos child headphone
button activates the detail view.

Add functionality for a tray item to choose which item to restore focus
too. The default will be the tray item itself. The first and only
user will be the volume tray.

Test: manual
Bug:  803013 
Change-Id: If053cd6f152679b79a98b85570a3cf3f97ed5e8f
Reviewed-on: https://chromium-review.googlesource.com/1038884
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555460}
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/audio/tray_audio.h
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/audio/volume_view.h
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/tray/system_tray_item.h
[modify] https://crrev.com/a071f1771aec616e6038635f71ebf80db2d9c319/ash/system/tray/system_tray_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment