New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 802997 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Aug 13
Cc:
█ yoshiki@chromium.org
est...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Remove ability to access notifier settings bubble from outside MessageCenterView

Project Member Reported by tetsui@chromium.org, Jan 17 2018 
On Chrome OS, right click menu was removed  https://crbug.com/796030  and inline settings is implemented https://crbug.com/782533. As a result, there's no way to access notifier settings bubble except for the settings button in MessageCenterButtonBar.

Therefore, UiController::ShowNotifierSettingsBubble() and all the related methods and arguments can be removed now.

Comment 1 by tetsui@chromium.org, Jan 17 2018

Labels: -Type-Bug OS-Chrome Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f708c4666a0334ec63315b4df6eeb7dfe541b895

commit f708c4666a0334ec63315b4df6eeb7dfe541b895
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Mon Aug 13 01:35:14 2018

Remove notifier settings access from outside

On Chrome OS, there's no way to access notifier settings bubble from
outside MessageCenterView, as right click menu is removed and inline
settings is introduced. Therefore, they are dead code right now.

BUG= 802997 

Change-Id: If498fa9b8949975d4c7c06a38667798b7124fc12
Reviewed-on: https://chromium-review.googlesource.com/1168268
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582490}
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_button_bar.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_ui_controller.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_ui_controller.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_ui_controller_unittest.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_ui_delegate.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_view.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_view.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/system/message_center/notification_tray.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/system/message_center/notification_tray.h
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ui/message_center/message_center_stats_collector.cc
[modify] https://crrev.com/f708c4666a0334ec63315b4df6eeb7dfe541b895/ui/message_center/message_center_types.h

Comment 3 by tetsui@chromium.org, Aug 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment