New issue
Advanced search Search tips

Issue 802983 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in CJBig2_Image::composeTo_opt2

Project Member Reported by ClusterFuzz, Jan 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5745020161490944

Fuzzer: afl_pdf_codec_jbig2_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x619000008580
Crash State:
  CJBig2_Image::composeTo_opt2
  CJBig2_Context::parseGenericRefinementRegion
  CJBig2_Context::ProcessingParseSegmentData
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=497793:497860

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5745020161490944

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 17 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 17 2018

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/41799881d04a01168700558ff394962b3b318b46 (Skip decoding of excessively large JBIG2 images.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 17 2018

Labels: M-64
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 17 2018

Labels: Pri-1
Not related to my CL, but will fix. UBSAN says integer overflow.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/4aadb708642003404e666026bb6d390b5989e2b4

commit 4aadb708642003404e666026bb6d390b5989e2b4
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jan 18 19:07:58 2018

Avoid integer overflows in CJBig2_Image::composeTo_opt2().

BUG= chromium:802983 

Change-Id: I866ece9c370bf05571b76b50ad23598f5038332b
Reviewed-on: https://pdfium-review.googlesource.com/23151
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/4aadb708642003404e666026bb6d390b5989e2b4/core/fxcodec/jbig2/JBig2_Image.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ee95f6291a4c6de4262c25acc52a39e7833b8a3

commit 7ee95f6291a4c6de4262c25acc52a39e7833b8a3
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Thu Jan 18 21:49:42 2018

Roll src/third_party/pdfium/ 28cb9a764..4aadb7086 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/28cb9a764765..4aadb7086420

$ git log 28cb9a764..4aadb7086 --date=short --no-merges --format='%ad %ae %s'
2018-01-18 thestig Avoid integer overflows in CJBig2_Image::composeTo_opt2().

Created with:
  roll-dep src/third_party/pdfium
BUG= 802983 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idf932d7194798e74a27098db0d3e485223b10078
Reviewed-on: https://chromium-review.googlesource.com/874720
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530283}
[modify] https://crrev.com/7ee95f6291a4c6de4262c25acc52a39e7833b8a3/DEPS

Project Member

Comment 9 by ClusterFuzz, Jan 19 2018

ClusterFuzz has detected this issue as fixed in range 530279:530286.

Detailed report: https://clusterfuzz.com/testcase?key=5745020161490944

Fuzzer: afl_pdf_codec_jbig2_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x619000008580
Crash State:
  CJBig2_Image::composeTo_opt2
  CJBig2_Context::parseGenericRefinementRegion
  CJBig2_Context::ProcessingParseSegmentData
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=497793:497860
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=530279:530286

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5745020161490944

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jan 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5745020161490944 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -M-64 M-65
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Release-0-M65
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment