New issue
Advanced search Search tips

Issue 802982 link

Starred by 1 user
Status: Assigned
Owner:
yuzus@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTests should not navigate after navigating to about:blank

Project Member Reported by yuzus@chromium.org, Jan 17 2018 
Several layout tests (fast/events/drop-handler-should-not-stop-navigate.html ,  fast/events/only-valid-drop-targets-receive-file-drop.html ) were found to be navigating to another page after navigating to about:blank, which is considered to be the end of the test execution.
This was happening because preventDefault in onBeforeUnload function did not work.
An error message should be emitted to prevent this from happening again.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7

commit 44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7
Author: Yuzu Saijo <yuzus@chromium.org>
Date: Wed Jan 17 08:38:50 2018

Rewrite the layout tests that use preventDefault in beforeunload handler

This CL rewrites the layout tests that were failing to prevent the default action in beforeunload handler. It was causing a navigation after navigating to about:blank, which resulted in flaky leaks. (Leak detector counted the instances during a navigation to another page, not on about:blank as it is supposed to.)
Thic CL stops the navigation after navigating to about:blank by modifying the laytout tests.

Bug: 802982, 798735
Change-Id: I621642410e89012067b3b2f1ba0907cc1adad402
Reviewed-on: https://chromium-review.googlesource.com/869639
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529675}
[modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/drop-handler-should-not-stop-navigate-expected.txt
[modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html
[modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop-expected.txt
[modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html

Comment 2 by tkent@chromium.org, Jan 18 2018

Components: -Blink Blink>Infra

Comment 3 by kereliuk@chromium.org, Jan 19 2018

Status: Available (was: Untriaged)

Comment 4 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
►

Sign in to add a comment