Issue metadata
Sign in to add a comment
|
Regression: Focus navigation issue is observed under 'Privacy and security' section on settings page.
Reported by
dchau...@etouch.net,
Jan 17 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3282.99 (Official Build) 3f92f230cbfdbc0374fde18da9a8589bc27bba39-refs/branch-heads/3282@{#521} 32/64-bit. OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3), Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome, navigate to chrome://settings page and go to 'Privacy and security' section. 2. Enable/Disable the 'Automatically send usage statistics and crash reports to Google' toggle button such that 'RELAUNCH' button appears. 3. Now press the 'Tab' key from keyboard and observe the focus. Focus moves to 'RELAUNCH' button instead of 'Send a "Do Not Track" request with your browsing traffic' toggle button. Focus should move to 'Send a "Do Not Track" request with your browsing traffic' toggle button. This is a regression issue, broken in M-58 series, Using the per-revision bisect providing the bisect results: Good build: 58.0.3012.0 (Revision: 450200) Bad build: 58.0.3013.0 (Revision: 450530) You are probably looking for a change made after 450292 (known good), but no later than 450293 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1175597e824387e993a7dadd093ca58cdaae9246..3245561158dde6808bd24b3322304369af52abac Suspect: https://chromium.googlesource.com/chromium/src/+/3245561158dde6808bd24b3322304369af52abac @dbeam/scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: This issue is also reproducible on Stable M-63 build # 63.0.3239.132 and Dev M-65 build # 65.0.3322.3 Kindly review the attached screen-cast for reference.
,
Jan 18 2018
yeah, this is an unfortunate oddity of <slot> and Shadow DOM's "light DOM" concept. not really sure how to fix (prototyped a few things, including flex-direction: row-reverse and tweaking order: <val> without much success creating a visual rearrangement of the bytestream order).
it's the typical issue:
<dom-module id="settings-toggle-button">
<template>
<slot name="more-actions"></slot>
<cr-toggle ...></cr-toggle>
</template>
</dom-module>
<!-- technically the <cr-toggle> is here in the byte stream order -->
<settings-toggle-button>
<!-- and the slotted element comes after -->
<paper-button slot="more-actions">Relaunch</paper-button>
</settings-toggle-button>
dmazzoni@/kochi@/aboxhall@: thoughts?
,
Jan 18 2018
Isn't this a duplicate of issue 782440? If so let's merge it there to have a single discussion thread.
,
Feb 2 2018
,
Jun 5 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Jan 17 2018