New issue
Advanced search Search tips

Issue 802977 link

Starred by 1 user
Status: Fixed
Owner:
kolos@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:After clicking on "cancel" button of Re-authentication prompt password is revealed once clicked on eye icon.

Reported by vku...@etouch.net, Jan 17 2018 
Chrome Version:65.0.3322.3 (Official Build)Revision 8758ca55b13d4f2082b2ed9269fce8f37f37c577-refs/branch-heads/3322@{#6}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome and login to https://twitter.com/ with valid credentials.
(2)Click on 'Never' button from password bubble,click on password bubble and click on eye icon,observe.
(3)Re-authentication with OS password prompt appears, click on cancel/close button of overlay.
(4)Now click on eye icon and observe.

Actual: After clicking on "cancel" button of Re-authentication prompt password is revealed once clicked on eye icon.(i.e without Re-authentication password is revealed)

Expected: Re-authentication with OS password prompt should appear every-time if eye icon is clicked.

This is a regression issue broken in 'M65' and below is the manual bisect info
Good Build: 65.0.3316.0 (Revision 527862)
Bad Build:  65.0.3317.0 (Revision 528119)

Note: 
1. Issue not seen on Linux(14.04 LTS)OS i.e Re-authentication overlay doesn't appear.
2. Incase of Mac(10.12.6,10.13.1,10.13.3)OS Re-authentication with OS password prompt appears every-time if eye icon is clicked.
Actual_Password.mp4
880 KB View Download

Comment 1 by vku...@etouch.net, Jan 17 2018

Labels: hasbisect-per-revision
Owner: kolos@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 527981 (known good), but no later than 527982 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/d1603bb87f33912dc07c564d5ae2eb3d8ca7bd74..77e711eb50d673ad4060e36570d81085511b2656

Suspecting: https://chromium.googlesource.com/chromium/src/+/77e711eb50d673ad4060e36570d81085511b2656

@kolos: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Comment 2 by kolos@chromium.org, Jan 17 2018

Status: Started (was: Assigned)
vakupte@: Thank you so much for the report. It is important issue.

Comment 3 by nyerramilli@chromium.org, Jan 17 2018

Cc: pbomm...@chromium.org ligim...@chromium.org
Labels: ReleaseBlock-Stable RegressedIn-65 Target-65 FoundIn-65
marking as RBS, please change if required.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d32fef2278600f331d7848d7e97555eaa298c3

commit b1d32fef2278600f331d7848d7e97555eaa298c3
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Jan 17 18:11:54 2018

[Password Manager] Require re-auth in save bubble if the previous re-auth was unsuccessful

There is a bug: the password could be revealed in a bubble after re-auth (even if the previous the re-auth was unsuccessful)

Bug:  802977 
Change-Id: Ia1b541838dff0401fffe691a5dc1b3b035658be9
Reviewed-on: https://chromium-review.googlesource.com/870319
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529805}
[modify] https://crrev.com/b1d32fef2278600f331d7848d7e97555eaa298c3/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/b1d32fef2278600f331d7848d7e97555eaa298c3/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/b1d32fef2278600f331d7848d7e97555eaa298c3/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Comment 5 by kolos@chromium.org, Jan 18 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jan 18 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by gov...@chromium.org, Jan 19 2018

Labels: -Merge-TBD
M65 is branched at 3325, chromium revision 530369. CL listed at #4 is already in branch. No merge is needed here.

Comment 8 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported
►

Sign in to add a comment