[Snowflake] Update list styles to Modern |
||||||||||||||||||
Issue descriptionThis bug is to fully implement the new Material list style which includes the follow updates: -Adding 36x36 grey circles (#F1F3F4) behind icons (centered around the 16x16dp favicons) -Favicons move 2dp to the left so the padding to the left and right of the grey circles is 16dp) -Text moves 4dp to the left (so the padding between the circle and the text is 16dp) As a result, all icons and titles in the headers using this list style should be left aligned with the new list style icons and text which affects the following pages: - Bookmarks choose folder view - Bookmarks search list results (omnibox) - Bookmarks edit + selected item - Downloads edit + selected item Also note: - Retain current row height for single line items - Single line titles (Dates etc.) that were previously 13dp change to 14dp - Remove 13dp from xml (if not already done in blocking bug) - No change to the downloads pending text styles Interactive redlines here: https://folio.googleplex.com/modernliststyle Mock attached that highlights the changes in pink:
,
Jan 30 2018
,
Jan 30 2018
Screenshots attached of current modern list style on KitKat N5 for reference. Could we launch modern without these changes (is this really P3 polish)? > Favicons move 2dp to the left so the padding to the left and right of the grey circles is 16dp) I think the padding in front of the grey circles is already 16dp, and the favicons are centered inside the circles. > Text moves 4dp to the left (so the padding between the circle and the text is 16dp) Changing the position of the text in the toolbar is a challenge because we use the Android toolbar widget rather than a custom layout. We can change the title start/end margin, but this doesn't give us the ability to move the text over very far to the left. It appears that most of the space in front of the text is due to padding on navigation icon or otherwise set internally in Toolbar.java. I think we should move away from the Android Toolbar widget since it makes custom positioning hard, but this is likely a larger change that will take some time.
,
Jan 30 2018
Sounds good, I'll separate out toolbar text positioning / Android toolbar widget changes (as this is a new Material list style, I will check with the Android team to see if they anticipate making this change as well). Otherwise, everything lgtm except for the omnibox cancel "x" icon in Screenshot_2018-01-30-00-23-22.png Would it be possible to move that to the right a few dp so that it's aligned with the overflow icon? It's non blocking but would be a nice to have...
,
Jan 30 2018
,
Jan 30 2018
Screenshots for in-flight patch to move the 'x' button.
,
Jan 30 2018
lgtm! -insert pacha perfect meme :)
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebd237afe3eebb8545472443ce45ac3a81449511 commit ebd237afe3eebb8545472443ce45ac3a81449511 Author: Theresa <twellington@chromium.org> Date: Wed Jan 31 00:14:58 2018 [Modern] Adjust padding for list style clear search button BUG= 802935 Change-Id: I7e935c623fc70e51e9989a80bde32135b0f0a1b8 Reviewed-on: https://chromium-review.googlesource.com/894643 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533104} [modify] https://crrev.com/ebd237afe3eebb8545472443ce45ac3a81449511/chrome/android/java/res/values/dimens.xml
,
Jan 31 2018
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by twelling...@chromium.org
, Jan 30 2018