New issue
Advanced search Search tips

Issue 802931 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get rid of IFrame code in oobe.py

Project Member Reported by achuith@chromium.org, Jan 17 2018

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/8b70a1dfecfe510a22c8f5f842cd6482ec9c476a

commit 8b70a1dfecfe510a22c8f5f842cd6482ec9c476a
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Jan 17 18:46:40 2018

[oobe]: Get rid of IFrame support.

Gaia IFrame deprecated since M44
Replace WebView with Webview in function names for consistency.

BUG= chromium:802931 
TEST=testGaiaLogin, testEnterpriseEnrollment
TBR=nednguyen@google.com

Change-Id: I051ee4afd662b86ca6fdf585ddaa2262ff433bfe
Reviewed-on: https://chromium-review.googlesource.com/869250
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/8b70a1dfecfe510a22c8f5f842cd6482ec9c476a/telemetry/telemetry/internal/backends/chrome/oobe.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5589b9962d15eab74e274e4fce3ff15163e7a32b

commit 5589b9962d15eab74e274e4fce3ff15163e7a32b
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jan 18 03:12:03 2018

Roll src/third_party/catapult/ 9071424be..1e70b8208 (5 commits)

https://chromium.googlesource.com/catapult.git/+log/9071424be9cd..1e70b8208a77

$ git log 9071424be..1e70b8208 --date=short --no-merges --format='%ad %ae %s'
2018-01-18 nednguyen Revert "[Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API"
2018-01-12 eakuefner [Dashboard] Whitelist cronet histogram account
2018-01-17 dtu [pinpoint] Merge bot mappings and move "builder" to an API argument.
2018-01-16 achuith [oobe]: Get rid of IFrame support.
2018-01-17 perezju [Telemetry] Migrate SeriallyExecutedBrowserTestCase to new API

Created with:
  roll-dep src/third_party/catapult
BUG= 802931 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I512111c201d756a2c5055b12ade36d42f828a08a
Reviewed-on: https://chromium-review.googlesource.com/872097
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530037}
[modify] https://crrev.com/5589b9962d15eab74e274e4fce3ff15163e7a32b/DEPS

Status: Fixed (was: Started)

Sign in to add a comment