ChromeOS issue: Proxy settings for VPN connection no longer present |
|||||||||||||||
Issue descriptionChromeOS version: 62.0.3202.97 ChromeOS device model: Case#: 14519100 Description: After changes in UI for network connections, it's no longer possible to set up proxy for VPN connection, they were present in v59 Steps to reproduce: 1. Create new VPN connection 2. Go to settings to add proxy information Current Behavior / Reproduction: No setting for proxy Expected Behavior: Some way to add proxy information Drive link to logs: Attached screenshots from v59 and v62
,
Jan 17 2018
,
Jan 17 2018
,
Jan 17 2018
Kevin: Can you please take a look at this ?
,
Jan 17 2018
+Steven
,
Jan 17 2018
,
Jan 17 2018
The section may not have made it to the new UI for VPN? I can definitely fix this for 65, but 64 is about to head to stable so that's unlikely (and it's much too late for 63).
,
Jan 19 2018
+Steven, is there no way to get this into a dot release in 64? We have devices which have been deployed into the field depending on this capability to get back to our intranet via vpn. Opening the site to the internet is not an option for us unfortunately. Any opportunity to bring this forward would be great for us!
,
Jan 19 2018
That's a TPM call. I was just looking into this. It should be a simple fix, but it's tricky for me to test.
,
Jan 19 2018
,
Jan 19 2018
[RBS temporarily until Enterprise PMs make the call on this]
,
Jan 19 2018
CL is up for review: https://chromium-review.googlesource.com/c/chromium/src/+/876983
,
Jan 19 2018
,
Jan 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/151cc6943f01a38ced210aa5e0a02caad0432fce commit 151cc6943f01a38ced210aa5e0a02caad0432fce Author: Steven Bennetts <stevenjb@chromium.org> Date: Sat Jan 20 00:18:41 2018 Show proxy section for VPN This was an incorrect conversion from the old UI; VPN should show the proxy section. Bug: 802930 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba5385a7286b8fc2c2b92a5ab15a4add65b79870 Reviewed-on: https://chromium-review.googlesource.com/876983 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#530679} [modify] https://crrev.com/151cc6943f01a38ced210aa5e0a02caad0432fce/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/151cc6943f01a38ced210aa5e0a02caad0432fce/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jan 22 2018
,
Jan 22 2018
Discussed internally with product team - The risk is high of merging to M64. - Will be shooting for M65 instead. - Lets recommend customers to pin versions until M65 with patch is out.
,
Jan 22 2018
Looks like this didn't get committed until after the 65 branch, can we get it merged to 65?
,
Jan 22 2018
,
Jan 22 2018
#16; should I be testing this in beta or dev? And from when should I see it available? Thanks
,
Jan 23 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c78ba6c48e2bbd6009b536d1595f071dd34504b commit 3c78ba6c48e2bbd6009b536d1595f071dd34504b Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jan 23 22:59:52 2018 Show proxy section for VPN This was an incorrect conversion from the old UI; VPN should show the proxy section. TBR=stevenjb@chromium.org (cherry picked from commit 151cc6943f01a38ced210aa5e0a02caad0432fce) Bug: 802930 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba5385a7286b8fc2c2b92a5ab15a4add65b79870 Reviewed-on: https://chromium-review.googlesource.com/876983 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530679} Reviewed-on: https://chromium-review.googlesource.com/882386 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#45} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/3c78ba6c48e2bbd6009b536d1595f071dd34504b/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/3c78ba6c48e2bbd6009b536d1595f071dd34504b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jan 28 2018
Running Version 65.0.3325.9 (Official Build) dev (32-bit) / 10323.1.0 (Official Build) dev-channel veyron_minnie Options not available under where I assume it should be (Under VPN profile once connected or under configure (see screenshot)). Please advise
,
Jan 30 2018
65.0.3325.9 was built on 2018-01-22, this was merged on 01-23 so that build will not have the fix. Also, the proxy settings should be in the details section, not the 'configure' section. That said, the 'configure' section should not be empty, that seems like a different issue that I will investigate.
,
Jan 30 2018
Steven, thx is there any easy way for us to be able to work out in these cases for ourselves, which specific build number a particular change will go into once it has been approved and merged? I think we worked out that the branch number mentioned in this ticket is the build number after 65.0. and so any changes in that branch number will go into the minor minor number, so 3325.9 .10 .11 .12 etc. But it isn't obvious how we work out exactly which number this will be. If we knew that, we'd be able to just keep our eye on the number on our beta channel devices until it arrives and then start testing. Any advice on this?
,
Jan 30 2018
Settings > About Chrome OS > Detailed build information > Build Date (at the bottom) will give the build date which can be compared to the merge date for a first pass. For more detail you need to look at the chromium branch, e.g. https://chromium.googlesource.com/chromium/src.git/+/65.0.3325.9 (e.g. clock on 'log' then look for a non branch version commit, expand it, and look for e.g. Cr-Commit-Position: refs/branch-heads/3325@{#12}, and compare #12 to the same line in comment #21 above)
,
Jan 30 2018
Steven, thx. Ok trying to work that out. I'm the end, I went to the latest version in that branch (3325.35) and went backwards through the log until I found your commit. The next "Incrementing VERSION to" message after that was for 65.0.3325.14. so I'm looking for anything .14 or later, correct? Does every .dot version number actually get pushed out publicly?
,
Jan 30 2018
Correct, and no.
,
Jan 31 2018
I can verify a Asus C100P build# 65.0.3325.35 has the proxy settings available with the ability to configure locally (per experience on M59). Thank you team for your efforts. What are the chances of this creeping into the upcoming beta release?
,
Jan 31 2018
Thanks for confirming! Sorry it took so long to triage and address. 65 is scheduled for beta "soon". Since 64 is already stable you may need to wait for 65 to make it to beta, hopefully within a week or so?
,
Jan 31 2018
All good; we are here now and seems to be working as it was previously. Next week is something we can work with I believe based on our use case. Will report back should we have any issues once we get a couple of users using the proxy.
,
Feb 16 2018
Team - can confirm that this is now available in Beta and have tested successfully. Next step is to move some of our devices into beta in production and test with end users. Next question is how can we manage this through policy? Asking end users to configure in small numbers (<25) is even stretching the boundaries. What can be done to support this being centrally managed? |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by mmenke@chromium.org
, Jan 17 2018