The NewTabPageInterceptorTests do not work with the NetworkService enabled at the moment. browser_tests --gtest_filter=*NewTabPageNavigationThrottleTest.* --enable-features=NetworkService
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ba21bcd266043ec39744a312c2921496e32000e commit 2ba21bcd266043ec39744a312c2921496e32000e Author: Conley Owens <cco3@chromium.org> Date: Fri Jan 19 00:49:37 2018 Replace the NTP Interceptor with Throttle This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. BUG= 802926 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iec0664df33e79d6bcc18f60aecc4017de7f65858 Reviewed-on: https://chromium-review.googlesource.com/868994 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530370} [modify] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/bc084a8b5afa3744a74927344e304c02ae54189f/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc [delete] https://crrev.com/bc084a8b5afa3744a74927344e304c02ae54189f/chrome/browser/ui/search/new_tab_page_interceptor_service.cc [delete] https://crrev.com/bc084a8b5afa3744a74927344e304c02ae54189f/chrome/browser/ui/search/new_tab_page_interceptor_service.h [delete] https://crrev.com/bc084a8b5afa3744a74927344e304c02ae54189f/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.cc [delete] https://crrev.com/bc084a8b5afa3744a74927344e304c02ae54189f/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h [add] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/ui/search/new_tab_page_navigation_throttle.cc [add] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/ui/search/new_tab_page_navigation_throttle.h [add] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc [modify] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/chrome/test/BUILD.gn [modify] https://crrev.com/2ba21bcd266043ec39744a312c2921496e32000e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The patch above was reverted to resolve issue 808011 . We will need to investigate the cause of the Official Build-specific test failures.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f77672dd3f34d5ba2e96912d34d657deb8f7433 commit 0f77672dd3f34d5ba2e96912d34d657deb8f7433 Author: Hans Wennborg <hans@chromium.org> Date: Thu Feb 01 15:46:13 2018 Revert "Replace the NTP Interceptor with Throttle" This reverts commit 2ba21bcd266043ec39744a312c2921496e32000e. Reason for revert: This broke browser_tests in official chrome-branded builds. See for example: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/78737 Also see the bug. Original change's description: > Replace the NTP Interceptor with Throttle > > This change replaces the NewTabPageInterceptorService with a > NewTabPageNavigationThrottle. The throttle reduces complexity, but it > is also neutral regarding the network stack / network service, so it > fixes the NewTabPageInterceptorServiceTests that were broken with the > NetworkService feature enabled. These tests are now renamed > NewTabPageNavigationThrottleTest. > > BUG= 802926 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Iec0664df33e79d6bcc18f60aecc4017de7f65858 > Reviewed-on: https://chromium-review.googlesource.com/868994 > Commit-Queue: Conley Owens <cco3@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530370} TBR=cco3@chromium.org,reillyg@chromium.org,mmenke@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 802926 , 808011 Change-Id: I6bedcaea58a7009cd0302469390645f2e496203e Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/897423 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533675} [modify] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/BUILD.gn [add] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc [add] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/search/new_tab_page_interceptor_service.cc [add] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/search/new_tab_page_interceptor_service.h [add] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.cc [add] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h [delete] https://crrev.com/b696eeaf6b786760b9a7e30b0957cd5d38fcdc34/chrome/browser/ui/search/new_tab_page_navigation_throttle.cc [delete] https://crrev.com/b696eeaf6b786760b9a7e30b0957cd5d38fcdc34/chrome/browser/ui/search/new_tab_page_navigation_throttle.h [delete] https://crrev.com/b696eeaf6b786760b9a7e30b0957cd5d38fcdc34/chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc [modify] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/chrome/test/BUILD.gn [modify] https://crrev.com/0f77672dd3f34d5ba2e96912d34d657deb8f7433/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9019d6765f35c87f22e1144421f3aceaf5962417 commit 9019d6765f35c87f22e1144421f3aceaf5962417 Author: Conley Owens <cco3@chromium.org> Date: Wed Feb 21 20:32:32 2018 Replace the NTP Interceptor with Throttle This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. This reverts commit 0f77672dd3f34d5ba2e96912d34d657deb8f7433. Issues with the previous version of the commit have been fixed by modifying the affected tests to handle redirection appropriately when features::kUseGoogleLocalNtp is not enabled. BUG= 802926 ,804055, 808011 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iec3a11c6454633860728f76564e10406ec0a9cbd Reviewed-on: https://chromium-review.googlesource.com/920461 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#538197} [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/extensions/all_urls_apitest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/extensions/content_script_apitest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/extensions/extension_url_rewrite_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/input_method/input_method_engine.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/search/local_ntp_test_utils.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/search/local_ntp_test_utils.h [delete] https://crrev.com/6e6e5b30bf3009a4b5ef8bbd25ef1f3da362b3cc/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc [delete] https://crrev.com/6e6e5b30bf3009a4b5ef8bbd25ef1f3da362b3cc/chrome/browser/ui/search/new_tab_page_interceptor_service.cc [delete] https://crrev.com/6e6e5b30bf3009a4b5ef8bbd25ef1f3da362b3cc/chrome/browser/ui/search/new_tab_page_interceptor_service.h [delete] https://crrev.com/6e6e5b30bf3009a4b5ef8bbd25ef1f3da362b3cc/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.cc [delete] https://crrev.com/6e6e5b30bf3009a4b5ef8bbd25ef1f3da362b3cc/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h [add] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/search/new_tab_page_navigation_throttle.cc [add] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/search/new_tab_page_navigation_throttle.h [add] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/test/BUILD.gn [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/test/data/extensions/api_test/content_scripts/ntp/background.js [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/test/data/extensions/api_test/tabs/basics/crud2.js [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/test/data/extensions/api_test/tabs/basics/move.js [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/chrome/test/data/extensions/api_test/tabs/on_updated/test.js [modify] https://crrev.com/9019d6765f35c87f22e1144421f3aceaf5962417/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01bea8cadcbae1df52c4b3aa71310a2311328c2d commit 01bea8cadcbae1df52c4b3aa71310a2311328c2d Author: Nico Weber <thakis@chromium.org> Date: Thu Feb 22 18:15:24 2018 Revert "Replace the NTP Interceptor with Throttle" This reverts commit 9019d6765f35c87f22e1144421f3aceaf5962417. Reason for revert: The test still seems to fail on various bots, see e.g. crbug.com/814545 Original change's description: > Replace the NTP Interceptor with Throttle > > This change replaces the NewTabPageInterceptorService with a > NewTabPageNavigationThrottle. The throttle reduces complexity, but it > is also neutral regarding the network stack / network service, so it > fixes the NewTabPageInterceptorServiceTests that were broken with the > NetworkService feature enabled. These tests are now renamed > NewTabPageNavigationThrottleTest. > > This reverts commit 0f77672dd3f34d5ba2e96912d34d657deb8f7433. > > Issues with the previous version of the commit have been fixed by modifying > the affected tests to handle redirection appropriately when > features::kUseGoogleLocalNtp is not enabled. > > BUG= 802926 ,804055, 808011 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Iec3a11c6454633860728f76564e10406ec0a9cbd > Reviewed-on: https://chromium-review.googlesource.com/920461 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Conley Owens <cco3@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538197} TBR=bartfab@chromium.org,bauerb@chromium.org,tapted@chromium.org,shuchen@chromium.org,cco3@chromium.org,reillyg@chromium.org,treib@chromium.org,emaxx@chromium.org,tmartino@chromium.org Change-Id: I65df1f24e4cdcc5d3ee8845fa64b669153819ec3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802926 , 804055, 808011 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/932081 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538485} [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/extensions/all_urls_apitest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/extensions/content_script_apitest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/extensions/extension_url_rewrite_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/input_method/input_method_engine.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/local_ntp_test_utils.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/local_ntp_test_utils.h [add] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc [add] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/new_tab_page_interceptor_service.cc [add] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/new_tab_page_interceptor_service.h [add] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.cc [add] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h [delete] https://crrev.com/d471df2beb31bb40c50a530f36c701f7d85ae36c/chrome/browser/ui/search/new_tab_page_navigation_throttle.cc [delete] https://crrev.com/d471df2beb31bb40c50a530f36c701f7d85ae36c/chrome/browser/ui/search/new_tab_page_navigation_throttle.h [delete] https://crrev.com/d471df2beb31bb40c50a530f36c701f7d85ae36c/chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/test/BUILD.gn [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/test/data/extensions/api_test/content_scripts/ntp/background.js [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/test/data/extensions/api_test/tabs/basics/crud2.js [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/test/data/extensions/api_test/tabs/basics/move.js [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/chrome/test/data/extensions/api_test/tabs/on_updated/test.js [modify] https://crrev.com/01bea8cadcbae1df52c4b3aa71310a2311328c2d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aafcf1279bd15fa897864f29a02153606bb6b755 commit aafcf1279bd15fa897864f29a02153606bb6b755 Author: Conley Owens <cco3@chromium.org> Date: Mon Feb 26 18:53:51 2018 Replace the NTP Interceptor with Throttle This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. We modify affected tests to handle the redirection appropriately, using either local_ntp_test_utils::GetFinalNtpUrl or search::IsInstantNTP. This reverts commit 01bea8cadcbae1df52c4b3aa71310a2311328c2d. The previous commit triggered a new test failure in ExtensionURLRewriteBrowserTest.NewTabPageURLOverride, in which case we were wrongly anticipating a redirect to the local NTP. This commit does not alter the shared TestURLNotShown method, but only fixes the test directly affected by our change. BUG= 802926 ,804055, 808011 ,814545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia7735eee7beed3a49ecfcf9eeb8798539693c97a Reviewed-on: https://chromium-review.googlesource.com/931988 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#539214} [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/extensions/all_urls_apitest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/extensions/content_script_apitest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/extensions/extension_url_rewrite_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/input_method/input_method_engine.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/search/local_ntp_test_utils.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/search/local_ntp_test_utils.h [delete] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc [delete] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/chrome/browser/ui/search/new_tab_page_interceptor_service.cc [delete] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/chrome/browser/ui/search/new_tab_page_interceptor_service.h [delete] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.cc [delete] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h [add] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/search/new_tab_page_navigation_throttle.cc [add] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/search/new_tab_page_navigation_throttle.h [add] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/search/new_tab_page_navigation_throttle_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/test/BUILD.gn [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/test/data/extensions/api_test/content_scripts/ntp/background.js [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/test/data/extensions/api_test/tabs/basics/crud2.js [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/test/data/extensions/api_test/tabs/basics/move.js [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/chrome/test/data/extensions/api_test/tabs/on_updated/test.js [modify] https://crrev.com/aafcf1279bd15fa897864f29a02153606bb6b755/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by bugdroid1@chromium.org
, Jan 19 2018