New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802923 link

Starred by 4 users

Issue metadata

Status: Fixed
Merged: issue 816652
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 808398



Sign in to add a comment

Swarming builds don't generate a result email.

Project Member Reported by dgarr...@chromium.org, Jan 17 2018

Issue description

Buildbot builds currently generate an email with the result of the build (including a list of stages with colors displayed and assorted relevant links.

Swarming tryjobs do no such thing.
 
Is this a blocker for tryjob -> swarming too? If so, we can prioritize in adding such an email. 
I don't think it's a blocker, but it's a strong nice to have. I'm also not certain of the best way to implement it. Does it belong in Legoland?

We have the infrastructure to send email, but this would require pinging some API regularly or get a notification when the tryjob finishes running. 

Is it possible to use its current way of sending email in swarming? 
I'm pretty sure the current emails are sent directly from buildbot.
Does swarming have a similar service we can utilize? 
Cc: no...@chromium.org mar...@chromium.org
We recently realized that there is no plan for how to send emailed tryjob results back. Is there a supported or suggested ChOps solution we can just use?

Comment 7 by no...@chromium.org, Jan 22 2018

Cc: athom@google.com
current emails are sent by gatekeeper, a service whose primary responsibility is to close a tree when critical builders fail, but it also sends an email. It does not have to close trees. Currently GK talks to Buildbot APIs that have LUCI emulation (i.e. this Buildbot API can return LUCI builds). See also http://g/luci-eng/qBKfRxQD3yM where Dart wanted the same thing and recommended piggy-backing on GK. +athom did it work for you?

Comment 8 by athom@google.com, Jan 23 2018

Adding Dart to GK is still pending review: https://chromium-review.googlesource.com/c/chromium/tools/build/+/870834

I'll update this bug when that is done.

We found the notification from the CQ by commenting on Gerrit to be sufficient, but some users would like additional notifications after the first failure (after the CQ stopped processing the patch). So email notifications for failing tryjobs is a "nice to have" for us, but for CI builds it's essential.

Comment 9 by no...@chromium.org, Jan 23 2018

Cc: -mar...@chromium.org tandrii@chromium.org
Shouldn’t first failure be sufficient for CQ to decide that the patchset is bad and post a comment?

Comment 10 by no...@chromium.org, Jan 23 2018

Cc: -no...@chromium.org mar...@chromium.org

Comment 11 by no...@chromium.org, Jan 23 2018

Cc: no...@chromium.org
(monorail doesn't like my phone)
1. Failing build notifications are sent by both Gatekeeper (for CI) and buildbot (through MailNotifier, for any kind of build). Gatekeeper should be flexible enough for this (though I had personally difficulty configuring it for something which was trivial in buildbot).

2. CQ will send email as soon as it aborts an attempt. I think what aathom@ meant was that some users prefer a notifications about a failed build even if CQ intends to retry it (by default, retry will happen once per 1 CQ attempt). I don't think we have a solution for this use-case. However, if builders of a project are not very flaky, then CQ config can be changed to avoid any retries and hence get email immediately upon first failure.
This is an example tryjob result for buildbot jobs. The new email service does not need to provide this much details, but should contain tryjob finishing status and necessary links.

Sounds like Gatekeeper is the way to go? 
tryjob_email.png
90.4 KB View Download

Comment 14 by no...@chromium.org, Jan 23 2018

Cc: mknyszek@chromium.org
sorry i confused two different use cases: CI and tryjobs. I don't know if it possible to use gatekeeper to send tryjob emails (also I have hard time imaging now it is going to work)

since the use case here is a tryjob, it might better to add it luci-notify service. Here its config proto
https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/luci_notify/api/config/notify.proto
function that decide what to do with a completed build: https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/luci_notify/notify/pubsub.go?l=65&rcl=bee896decafdfda281a007920c61bc10e2427a41
It looks like that requires the email address to be specified in the configuration file.

But for tryjobs, we want to send the email to the person that scheduled it. Preferably, by means of a buildbucket property.
Blocking: 808398

Comment 17 by no...@chromium.org, Feb 23 2018

For tryjobs, there email address would be fetched from Gerrit 
Mergedinto: 816652
Status: Duplicate (was: Untriaged)

Comment 19 by no...@chromium.org, Mar 20 2018

Cc: dgarr...@chromium.org
Owner: ----
Status: Available (was: Duplicate)
 Issue 816652  is different. Chromium CQ, git-cl-try and Gerrit don’t put emails and builds (and shouldn’t)
Labels: Swarming
Owner: dgarr...@chromium.org
Status: Fixed (was: Available)
I don't understand how it's different, except that it describes the implementation in more detail.

We now have email notifications for ChromeOS tryjobs that work using the mechanism. This is at least fixed. ;>

Comment 21 by no...@chromium.org, Mar 20 2018

i've confused this bug with the feature needed by Chromium. Filed bug 823934

Sign in to add a comment