New issue
Advanced search Search tips

Issue 802920 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Jan 2018
Cc:
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Black bar when minimized window is minimized in tablet mode.

Project Member Reported by sammiequon@chromium.org, Jan 17 2018 
(1) In non tablet mode, open a chrome v2 app.
(2) Minimize app.
(3) Enter tablet mode.
(4) Unminimize app.

What is the expected result?
No black bar on the top of the screen.

What happens instead?
Black bar on the top of the screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8bc0bc5a8fb97023d4a3469786f9c62f147fdb

commit 8a8bc0bc5a8fb97023d4a3469786f9c62f147fdb
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Jan 18 23:57:16 2018

wm: Remove black bar see in tablet mode when entered with minimized window.

Steps to reproduce in bug. Caused because the calculation is correct,
but no relayout when minimized window gets reactivated. This cl will
relayout the non client view which will layout the client view with the
correct bounds.

Also replaced some duplicate code in the test file with an already
made function.

Test: CustomFrameViewAshTest.*
Bug:  802920 
Change-Id: I0ca99fb837a5ddb0d6b78d2c22d1fb00e7b62230
Reviewed-on: https://chromium-review.googlesource.com/872095
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530349}
[modify] https://crrev.com/8a8bc0bc5a8fb97023d4a3469786f9c62f147fdb/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/8a8bc0bc5a8fb97023d4a3469786f9c62f147fdb/ash/frame/custom_frame_view_ash_unittest.cc

Comment 2 by sammiequon@chromium.org, Jan 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment