Update dense list style to new Material style with larger title text |
|||||||||||||||||
Issue descriptionThere is a new Material list style with larger text but a shorter row height which allows us to increase the text without losing vertical space. This bug is to track only the font and row height increase (there will be a separate bug to track implementation of the icon circles and text spacing) We've gotten feedback from several sources (779137) that the existing list in Bookmarks, History, and Downloads is too small. Using this new style will allow us to remove the all sizes for Regular 13sp in the xml which was added just for this list UI. Changelist from the current dense list UI would be: row height increases (from 60dp to 64dp) title text size increases (from Regular 13sp to Regular 16sp) subtitle text size decreases (from Regular 13sp to Regular 14sp) remove Regular 13sp text from text styles xml Interactive redlines: https://folio.googleplex.com/newdenseliststyle#%3Ff=hidden
,
Jan 17 2018
You are correct.. sorry for the typo!
,
Jan 17 2018
Also if we're removing 13dp text from the xml, Single line section descriptors (Dates etc.) change to 14dp
,
Jan 17 2018
,
Jan 17 2018
Marking as available. Either Becky or I will likely pick this up for M66 polish.
,
Jan 17 2018
Unless we need it for M65? We can probably squeeze it in today if so.
,
Jan 17 2018
Issue 779137 has been merged into this issue.
,
Jan 17 2018
+hanxi@, chrome/android/webapk/shell_apk/res/values/dimens.xml needs to be updated to remove text_size_medium_dense and use text_size_large (16sp) in its place. Is that something you can own? Screenshots from in-flight CL attached. Hannah, please review. Note that the accessibility tab switcher screenshots attached are only available when Chrome Home is enabled, so we can add polish in a follow-up CL if needed. https://chromium-review.googlesource.com/#/c/chromium/src/+/871133
,
Jan 17 2018
Yes, I own the demins.xml. Please see the screenshots to compare before and after changing the size: https://drive.google.com/open?id=1oPk5yoUFnuM_ZlNkgP-tb_fE4jaq2Qep. I feel the second line "Unsupported" should remain the small size 13dp. However, this needs some extra work, since the dialog items simply contains 2 lines of text with the same size. The dialog belongs to a WebAPKs, so it can't use any Chrome's code.
,
Jan 17 2018
I suggest using 14sp for the second line of text to match our other "subtitles".
,
Jan 17 2018
Also, thanks for the fast update!
,
Jan 17 2018
,
Jan 17 2018
lgtm!! Thanks for the quick turnaround guys!!
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099 commit 08d3a523ea0db7de4ab1ddee9ff3ccfdae951099 Author: Theresa Wellington <twellington@google.com> Date: Thu Jan 18 00:45:48 2018 Update list style text size and min height on Android Replaces *DenseListText1 with *Title1 and *DenseListText2 with *Body and removes dense text styles/dimens. Also updates the minimum height for modern list items. BUG= 802913 Change-Id: Idc1fa03235a396b14f6d23156ea59d5bae320796 Reviewed-on: https://chromium-review.googlesource.com/871133 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#529983} [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/android/java/res/layout/download_item_view.xml [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/android/java/res/layout/modern_list_item_view.xml [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/test/data/android/render_tests/BookmarkTest.bookmark_manager_folder_selected.Nexus_5-19.png [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/chrome/test/data/android/render_tests/BookmarkTest.bookmark_manager_one_folder.Nexus_5-19.png [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/ui/android/java/res/values-v17/styles.xml [modify] https://crrev.com/08d3a523ea0db7de4ab1ddee9ff3ccfdae951099/ui/android/java/res/values/dimens.xml
,
Feb 7 2018
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by twelling...@chromium.org
, Jan 17 2018