WebUI: Remove usage of paper-menu, replace with paper-listbox. |
||||
Issue descriptionpaper-menu has been deprecated, and it has not been ported to Polymer 2, see https://github.com/PolymerElements/paper-menu. Need to migrate away from this element in order to unblock migration of WebUI as a whole to Polymer 2. The only remaining usage of paper-menu, seems to be in media_router, at https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html?t&l=60.
,
Jan 19 2018
cc'ing media router OWNERs. Could you provide some instrucitons on how to launch the media router WebUI locally, so that I can replace paper-menu wit paper-listbox? Thank you.
,
Jan 19 2018
Just discovered that navigating to chrome://media-router works (although probably does not look exactly as in the normal in-dialog UI).
,
Jan 19 2018
You can open the Media Router dialog via the overflow menu ('Cast...', right below 'Print...' or also often via the right click context menu (although that is context dependent).
Even without any Cast devices the relevant UI elements should be in the dialog header IIUC.
,
Jan 19 2018
@amp: Thanks for the pointer. One more question. I am only able to see the first paper-menu instance, see [1]. Is there a way to easily invoke the 2nd (#sink-list-paper-menu) and 3rd (#search-results-paper-menu) instances? [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html?l=60,124,188
,
Jan 19 2018
,
Jan 19 2018
I can't recall exactly which instance correspond to which modes of the dialog. If you run on canary there should be a couple of 'test' devices which should populate the sink list (I think, I haven't run canary in a while, there should be a way to run a dev version of the media router component extension which should also have the test sinks). Search entry field will only show up on Chrome (not Chromium) and with a signed in account which is part of a domain (so not regular gmail account). IIRC, others more familiar with the dialog internals might be able to give better guidance.
,
Jan 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4c0fd8fe603b7836bb38db93ef4d0a66b2970c1 commit f4c0fd8fe603b7836bb38db93ef4d0a66b2970c1 Author: dpapad <dpapad@chromium.org> Date: Sat Jan 20 00:40:08 2018 WebUI: Remove obsolete references to paper-menu. This is in preparation of fully removing paper-menu from third_party/polymer. Bug: 802912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9b8a54d07b21ceb34d2f665db85c015d3cd386f Reviewed-on: https://chromium-review.googlesource.com/876984 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#530696} [modify] https://crrev.com/f4c0fd8fe603b7836bb38db93ef4d0a66b2970c1/chrome/browser/resources/md_downloads/compiled_resources2.gyp [modify] https://crrev.com/f4c0fd8fe603b7836bb38db93ef4d0a66b2970c1/chrome/browser/resources/md_extensions/compiled_resources2.gyp
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8063f5fad3908ea3a969950150653dae7ff97ec commit b8063f5fad3908ea3a969950150653dae7ff97ec Author: dpapad <dpapad@chromium.org> Date: Tue Jan 23 19:47:42 2018 Media router WebUI: Replace usage of paper-menu with paper-listbox. This is in preparation of removing paper-menu from third_party/polymer. Bug: 802912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9ceb9d8d83a345f94f37a56eeac23cd20585b12 Reviewed-on: https://chromium-review.googlesource.com/876926 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531309} [modify] https://crrev.com/b8063f5fad3908ea3a969950150653dae7ff97ec/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/b8063f5fad3908ea3a969950150653dae7ff97ec/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a2accda56a4ac7656722f32b2e83d11269f03e4 commit 9a2accda56a4ac7656722f32b2e83d11269f03e4 Author: dpapad <dpapad@chromium.org> Date: Tue Jan 23 21:19:19 2018 WebUI Polymer: Remove paper-menu from third_party/polymer. The element is no longer used and is deprecated in Polymer 2. Bug= 802912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e84de8cd64be8f838f8e2ae52d8dc4ccfd251c7 Reviewed-on: https://chromium-review.googlesource.com/877392 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531348} [modify] https://crrev.com/9a2accda56a4ac7656722f32b2e83d11269f03e4/third_party/polymer/v1_0/bower.json [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/BUILD.gn [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/bower.json [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu-extracted.js [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu-shared-styles.html [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu.html [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js [delete] https://crrev.com/daf7f91c5741848f2239410ff970325cf80eb89c/third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu.html [modify] https://crrev.com/9a2accda56a4ac7656722f32b2e83d11269f03e4/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/9a2accda56a4ac7656722f32b2e83d11269f03e4/ui/webui/resources/polymer_resources.grdp
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Jan 17 2018