New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 802885 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Jan 2018
Cc:
creis@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

No CPU, network and other stats will be reported by the processes API if there are only listeners to onUpdatedWithMemory

Project Member Reported by afakhry@chromium.org, Jan 16 2018 
During a recent email discussion about the processes API, I noticed a bug in the way we decide which stats the task manager should refresh and report to listeners of `onUpdatedWithMemory` when there are no `onUpdated` listeners.

I have a CL with test coverage.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917a4133c0c4e969da89f51a5ca5867db3d7d029

commit 917a4133c0c4e969da89f51a5ca5867db3d7d029
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Fri Jan 19 21:00:14 2018

Listeners to onUpdatedWithMemory should get CPU and other stats

Fix a bug resulting in `onUpdatedWithMemory` listeners getting
the memory stats only without the other stats that `onUpdated`
listeners get. This used to happen when there are no `onUpdated`
listeners.

BUG= 802885 
TEST=Added new test

Change-Id: I3db2673273391b97b509529ad04a6d0c1a8251c2
Reviewed-on: https://chromium-review.googlesource.com/868838
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530607}
[modify] https://crrev.com/917a4133c0c4e969da89f51a5ca5867db3d7d029/chrome/browser/extensions/api/processes/processes_api.cc
[modify] https://crrev.com/917a4133c0c4e969da89f51a5ca5867db3d7d029/chrome/browser/extensions/api/processes/processes_apitest.cc

Comment 2 by afakhry@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
►

Sign in to add a comment