Issue metadata
Sign in to add a comment
|
URL is not updated when Download manager is displayed |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3319.0 canary iOS Version: 11.2.5 beta#4 Device: iPhoneX, iPhone8, iPads URL: thinkbroadband.com/download Steps to reproduce: 1. Launch Google Chrome 2. Navigate to the above test webpage 3. Tap any file to download Observed results: Observe that Download manager is displayed but omnibox URL is not updated. Expected results: Omnibox URL should be correctly updated to the downloaded page URL Good Version: 65.0.3295.0 #cfe26c2 Bad Version: 65.0.3296.0 #ec7630c Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M63 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M64 NO Link to video/image: https://drive.google.com/file/d/1iLc-qw64KvXeXIsGuno6SJF5gdUc3X5Q/view
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26ecbe37fa333e90efd089fda186bfd7f8051f03 commit 26ecbe37fa333e90efd089fda186bfd7f8051f03 Author: Eugene But <eugenebut@google.com> Date: Fri Jan 19 16:56:35 2018 Do not discard pending entry for old download manager. Pending entry should only be discarded for new download manager or for passkit download. Old download manager is fullscreen and omnibox has to show download URL, instead of web view URL. Bug: 802880 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie2d00d9b29e91a315d846262da2298e23e57ac53 Reviewed-on: https://chromium-review.googlesource.com/871041 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#530541} [modify] https://crrev.com/26ecbe37fa333e90efd089fda186bfd7f8051f03/ios/web/web_state/ui/crw_web_controller.mm
,
Jan 19 2018
,
Jan 19 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 9 2018
Please request merge approval for M65 if this is now fixed.
,
Feb 9 2018
,
Feb 9 2018
This bug requires manual review: Less than 21 days to go before AppStore submit on M65 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
Fix looks good. Verified in M66.0.3345.0 canary Device: iPhoneX, iPhone6 plus iOS: 11.3, 10.3.3
,
Feb 12 2018
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/627c1e21cc73b67c0c6689ab2f9405d130773ca5 commit 627c1e21cc73b67c0c6689ab2f9405d130773ca5 Author: Eugene But <eugenebut@google.com> Date: Mon Feb 12 22:39:55 2018 Do not discard pending entry for old download manager. Pending entry should only be discarded for new download manager or for passkit download. Old download manager is fullscreen and omnibox has to show download URL, instead of web view URL. TBR=eugenebut@google.com (cherry picked from commit 26ecbe37fa333e90efd089fda186bfd7f8051f03) Bug: 802880 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie2d00d9b29e91a315d846262da2298e23e57ac53 Reviewed-on: https://chromium-review.googlesource.com/871041 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530541} Reviewed-on: https://chromium-review.googlesource.com/914713 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#436} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/627c1e21cc73b67c0c6689ab2f9405d130773ca5/ios/web/web_state/ui/crw_web_controller.mm
,
Feb 21 2018
Verified on M65.0.3325.89 beta Device: iPhone6s, iPad Pro iOS: 11.3 beta#2, 11.2.6 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by eugene...@chromium.org
, Jan 17 2018Components: -UI>Browser>Omnibox
Labels: M-65 ReleaseBlock-Stable
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)