Issue metadata
Sign in to add a comment
|
"SitePerProcessBrowserTest.SubframeTouchEventRouting" is flaky |
||||||||||||||||||||||||
Issue description"SitePerProcessBrowserTest.SubframeTouchEventRouting" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0LlN1YmZyYW1lVG91Y2hFdmVudFJvdXRpbmcM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 17 2018
disable test CL is in CQ https://chromium-review.googlesource.com/c/chromium/src/+/869145
,
Jan 17 2018
They might all have the same cause since they are all related to touch events. Most likely they are flaking from having moved touch events to asynchronous routing, i.e. https://chromium-review.googlesource.com/c/chromium/src/+/855118. I'll have a look, but it could possibly be exposing existing race conditions in the test because it takes longer to deliver the events now.
,
Jan 17 2018
,
Jan 17 2018
Detected 3 new flakes for test/step "SitePerProcessBrowserTest.SubframeTouchEventRouting". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0LlN1YmZyYW1lVG91Y2hFdmVudFJvdXRpbmcM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 17 2018
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac1311ffb8d41df922e909c32160fa7169771db2 commit ac1311ffb8d41df922e909c32160fa7169771db2 Author: Ken Buchanan <kenrb@chromium.org> Date: Thu Jan 18 00:48:29 2018 Fix flakiness in SitePerProcessBrowserTest.SubframeTouchEventRouting This adds a wait to ensure that the touch event id routed and dispatched before proceeding with the test. Bug:802828 Change-Id: I3a9591e9fdc7a0d98ab869882b94353df936d7b4 Reviewed-on: https://chromium-review.googlesource.com/871796 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#529985} [modify] https://crrev.com/ac1311ffb8d41df922e909c32160fa7169771db2/content/browser/site_per_process_browsertest.cc
,
Jan 18 2018
I am seeing flakes as recently as 2018-01-18 16:39:04 UTC (1.5 hours ago). I presume that the fix in #7 was not successful. If this flaky rate continues (nearly hourly) I will disable the test later today.
,
Jan 18 2018
Yes, unfortunately there are still some flakes, but the flakes look different now so I think the fix in #7 actually resolved an important race condition in the test. The remaining flakes are due to issue 798476 , so if the test has to be disabled, it should be tagged with that bug.
,
Jan 18 2018
Ack, thanks for letting me know. I am removing this from the sheriff queue.
,
Jan 18 2018
Detected 19 new flakes for test/step "SitePerProcessBrowserTest.SubframeTouchEventRouting". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0LlN1YmZyYW1lVG91Y2hFdmVudFJvdXRpbmcM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 18 2018
The issue came back into the sheriff's queue.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d35abd616a8f88e34f37a28be800694ae741db51 commit d35abd616a8f88e34f37a28be800694ae741db51 Author: Sorin Jianu <sorin@chromium.org> Date: Fri Jan 19 01:14:17 2018 Disable flaky test SitePerProcessBrowserTest.SubframeTouchEventRouting. TBR: kenrb@chromium.org Bug: 798476 , 802828 Change-Id: I62f25924477f4d281483063bfb0a56b93252db90 Reviewed-on: https://chromium-review.googlesource.com/875294 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530374} [modify] https://crrev.com/d35abd616a8f88e34f37a28be800694ae741db51/content/browser/site_per_process_browsertest.cc
,
Jan 19 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cacd0085c363f70055d6a20a51ad670a1681c411 commit cacd0085c363f70055d6a20a51ad670a1681c411 Author: Ken Buchanan <kenrb@chromium.org> Date: Mon Jan 22 20:38:12 2018 Re-enable various SitePerProcessBrowserTests A bug that was causing flakes in many OOPIF-based browser tests was fixed in r530669. This re-enables several tests that were disabled due to that bug. TBR=msramek@chromium.org Bug: 798476 , 803641 , 803628 , 803627 , 802828 , 802281 Change-Id: Ib37c6761cd1ee46d8e49ef393db21209935862dd Reviewed-on: https://chromium-review.googlesource.com/879101 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#530981} [modify] https://crrev.com/cacd0085c363f70055d6a20a51ad670a1681c411/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc [modify] https://crrev.com/cacd0085c363f70055d6a20a51ad670a1681c411/content/browser/site_per_process_browsertest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by creis@chromium.org
, Jan 17 2018Labels: OS-Windows
Owner: kenrb@chromium.org