Issue metadata
Sign in to add a comment
|
Avoid SafetyNet when reloading tab during startup |
||||||||||||||||||||
Issue descriptionUsually when Chrome starts on Android it reloads previously active tab. During reloading it checks URLs via SafetyNet, and that takes ~400ms on average for the first check (see the sheet below). Half of that renderer is idling, waiting for CommitNavigation. Can we bypass SafetyNet in this specific case - when previously loaded tab is reloaded during startup? I did a quick test, and hacked SafeBrowsingApiHandlerBridge::Core::CheckApiIsSupported() to always return false. That improved "Startup to MeaningfulPaint" metric by ~200ms (6%), see the data here: https://docs.google.com/spreadsheets/d/1hboQEfw6izXQRo9gz_JloQdDxEGHkFwccCcbtJPaK5s/edit?usp=sharing
,
Jan 16 2018
My fear is that one of the URLs will become malicious or otherwise on some Safe Browsing list and we let the user navigate to a malicious site. I think if we did it, it would be via some (explicit or implicit) cache to ensure we haven't let too much time pass since the check for that site. Thankfully, I believe Safe Browsing team is working on a local cache to avoid SafetyNet lookups. Varun, can you confirm?
,
Jan 18 2018
I agree, local cache would be much more appropriate here. Varun, what's the status of it?
,
Jan 18 2018
Re #c2, local cache is on our roadmap but isn't being worked on actively at the moment. It is planned for later in 2018.
,
Jan 18 2018
NextAction: check the status of safe browsing' local cache feature.
,
Jan 18 2018
Here's the issue for that: https://bugs.chromium.org/p/chromium/issues/detail?id=747428
,
Jan 18 2018
,
Jan 19 2018
,
Mar 8 2018
Related: crbug.com/817909
,
Aug 1
The NextAction date has arrived: 2018-08-01 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dskiba@chromium.org
, Jan 16 2018Status: Available (was: Untriaged)