Issue metadata
Sign in to add a comment
|
10%-68.8% regression in blink_perf.bindings at 528911:529082 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 16 2018
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8957207669676961520
,
Jan 17 2018
=== Auto-CCing suspected CL author bsalomon@google.com === Hi bsalomon@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Brian Salomon Commit : b5ef1f9b13e36a427dd6350986d41db208b2df1b Date : Thu Jan 11 19:37:51 2018 Subject: Make GrTextureOp capable of edge antialiasing. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : thread_times.key_mobile_sites_smooth Metric : thread_GPU_cpu_time_per_frame/http___slashdot.org_ Change : 12.01% | 0.775754993659 -> 0.868955356581 Revision Result N chromium@528910 0.775755 +- 0.00845534 6 good chromium@528970 0.789629 +- 0.0214588 6 good chromium@528985 0.79568 +- 0.0270864 6 good chromium@528993 0.793451 +- 0.0155628 6 good chromium@528994 0.790474 +- 0.020732 6 good chromium@528994,skia@f7dbc3507d 0.79523 +- 0.021027 6 good chromium@528994,skia@ac47b88d3c 0.787614 +- 0.0283225 6 good chromium@528994,skia@b5ef1f9b13 0.877331 +- 0.0296496 6 bad <-- chromium@528994,skia@2541edf0c6 0.869037 +- 0.0487444 6 bad chromium@528994,skia@d75fdc64be 0.86994 +- 0.0282057 6 bad chromium@528995 0.877893 +- 0.0362791 6 bad chromium@528997 0.876165 +- 0.0371304 6 bad chromium@529000 0.863712 +- 0.031223 6 bad chromium@529029 0.868955 +- 0.0336679 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...slashdot.org. thread_times.key_mobile_sites_smooth More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8957207669676961520 For feedback, file a bug with component Speed>Bisection
,
Jan 17 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/4e6cf91b7e6f7908d941275dc56c829143345402 commit 4e6cf91b7e6f7908d941275dc56c829143345402 Author: Brian Salomon <bsalomon@google.com> Date: Wed Jan 17 14:50:46 2018 Add macro to disable using GrTextureOp for AA in Chrome Bug: chromium:802408 Bug: chromium:801783 Change-Id: Id5f097b1df08e21e1385efeb8dd8a5e61305a013 Reviewed-on: https://skia-review.googlesource.com/95564 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/4e6cf91b7e6f7908d941275dc56c829143345402/src/gpu/SkGpuDevice_drawTexture.cpp
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3781e6ffa5dd2975f5382807875e16dbf12dae2d commit 3781e6ffa5dd2975f5382807875e16dbf12dae2d Author: Brian Salomon <bsalomon@google.com> Date: Thu Jan 18 04:28:18 2018 [Skia] Disable using GrTextureOp aa until bugs worked out Bug: 802408 Bug: 801783 Change-Id: I20fc0a7b708488f8d85ef9ab85f866c354134dbc Reviewed-on: https://chromium-review.googlesource.com/871270 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#530053} [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/skia/config/SkUserConfig.h [add] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-simple-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-tiled-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paint-subrect-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-simple-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-sizing-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/jpeg-yuv-progressive-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-canvas-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/optimize-contrast-image-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/paint-subrect-expected.png [modify] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png [add] https://crrev.com/3781e6ffa5dd2975f5382807875e16dbf12dae2d/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-canvas-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-image-expected.png [delete] https://crrev.com/aca25a2d1b5423411a38e9807e34d180bd4f392d/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/pixelated-svg-image-expected.png
,
Jan 19 2018
,
Jan 24 2018
馃搷 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c0e34c840000
,
Jan 24 2018
馃搷 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15c312b4840000
,
Jan 25 2018
馃搷 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12c0e34c840000 [viz] Remove SurfaceObserver::OnSurfaceSubtreeDamaged. By rijubrata.bhaumik@intel.com 路 Fri Jan 12 06:47:01 2018 chromium @ 782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6 Do not use soon deprecated v8::ReturnValue::Set. By yangguo@chromium.org 路 Fri Jan 12 15:21:46 2018 chromium @ 7ef680c7b45f3470968ac126838bc8b90c383572 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 25 2018
I kicked off some bisects because I had been strongly suggesting that this wasn't due to my change. The Skia roll containing my changes wasn't in the git range for many of the tests that regressed. I landed a change that avoided the new code path added by my change and performance wasn't restored on the perf charts. I also tried reproducing a regression due to my change on about 8 different phones/computers and couldn't reproduce it.
,
Jan 25 2018
The viz CL definitely doesn't cause any regressions.
,
Jan 27 2018
馃搷 Found significant differences after each of 11 commits. https://pinpoint.chromeperf.appspot.com/job/15c312b4840000 Reland "Make many base:: classes constexpr default constructible" By gab@chromium.org 路 Fri Jan 12 13:40:21 2018 chromium @ 2e4eab147b94a947ed4650234637b85802000b2b Rename CSS scroll-snap-margin to scroll-margin By sunyunjia@chromium.org 路 Fri Jan 12 14:08:25 2018 chromium @ 0d3134426aaa0499424fcf363552bc6a4f037145 Fix unpack the same icon twice on unpackers layer By ivafanas@yandex-team.ru 路 Fri Jan 12 14:52:43 2018 chromium @ 926bf293faabd120115fa5a105eb8dcc6eeadf0a Make task runners at RTCPeerConnectionHandle in WaitableEventWatcher changeable By hajimehoshi@chromium.org 路 Fri Jan 12 15:11:44 2018 chromium @ 138652c9e5bc18add6649a2651162193b2053dc6 Do not use soon deprecated v8::ReturnValue::Set. By yangguo@chromium.org 路 Fri Jan 12 15:21:46 2018 chromium @ 7ef680c7b45f3470968ac126838bc8b90c383572 No longer use deprecated v8::JSON::Parse. By yangguo@chromium.org 路 Fri Jan 12 15:35:33 2018 chromium @ c89bb094a71aa86f3fe23a4a1d471760f03ced25 [Web Payments] Embed Payment Handler window in PR dialog By anthonyvd@chromium.org 路 Fri Jan 12 16:14:06 2018 chromium @ 8f5e7e14b60b9c7735e0fdc208f5bb99b358619e Move MediaDevicesPermissionChecker to MediaDevicesManager By c.padhi@samsung.com 路 Fri Jan 12 16:17:01 2018 chromium @ 7db4074e5ec8d6e8e096c48761088c842d399ece Adds ability for BrowserMainParts::PreEarlyInitialization() to fail By sky@chromium.org 路 Fri Jan 12 16:44:21 2018 chromium @ 9068b4df605ec1b5767f66e3344a0cadeb82aaf1 Fix data race in unit_tests on calling By ganenkokb@yandex-team.ru 路 Fri Jan 12 16:46:36 2018 chromium @ 9c00a8b13bf2665b7d49bea24c6a060f8df032c1 [PaintWorklet] Fix shadow blur size when page zooms By xidachen@chromium.org 路 Fri Jan 12 17:07:05 2018 chromium @ 037f13946d29591fe1c1f6eeae6187645674aad0 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 27 2018
Looks like this metric is overly sensitive to small changes in Chrome, which makes the bisects come out very noisy. +jbroman, owner of the benchmark. But it looks like yangguo's change is about the same size as the regression shown on the perf dashboard. Do not use soon deprecated v8::ReturnValue::Set. By yangguo@chromium.org 路 Fri Jan 12 15:21:46 2018 chromium @ 7ef680c7b45f3470968ac126838bc8b90c383572
,
Jan 31 2018
+mlippautz,ulan who have touched this code since It seems plausible to me that opening a local handle could cause this regression; the previous overload of v8::ReturnValue::Set would copy the underlying pointer. Perhaps we should be holding a v8::Global instead of a v8::Persistent, if that's what V8 would rather have us pass to v8::ReturnValue.
,
Feb 1 2018
The regression comes from creating the Local inbetween. Just talked to Jochen about this: The idea (long long ago) was to get rid of Persistent and replace it with Global. That's why the setter is deprecated. Now, the main world wrapper is a Persistent which IIUC could be switched to Global. This will allow you to use the fast setter here. One would need to check how that plays out with the (Persistent|Global)ValueMap that is used for wrapper worlds though.
,
Feb 1 2018
,
Feb 13 2018
馃搷 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16a95835840000
,
Feb 14 2018
馃搷 Found significant differences after each of 3 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16a95835840000 Make task runners at RTCPeerConnectionHandle in WaitableEventWatcher changeable by hajimehoshi@chromium.org https://chromium.googlesource.com/chromium/src/+/138652c9e5bc18add6649a2651162193b2053dc6 macOS V2 Sandbox: Disable V2 for GPU processes. by kerrnel@chromium.org https://chromium.googlesource.com/chromium/src/+/6f59d9136999c22bbcbe226f00cd58563b29d81d Do not use soon deprecated v8::ReturnValue::Set. by yangguo@chromium.org https://chromium.googlesource.com/chromium/src/+/7ef680c7b45f3470968ac126838bc8b90c383572 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 14 2018
The V8::ReturnValue::Set CL has already been reverted like two weeks ago. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 16 2018