Issue metadata
Sign in to add a comment
|
18% regression in blink_perf.bindings at 527608:528973 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 16 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/148f97c0840000
,
Jan 18 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12ee0a48840000
,
Jan 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14c4b1f8840000
,
Jan 19 2018
Pinpoint jobs don't seem to ever finish. Kicking off one more time before looping in dev team...
,
Jan 23 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14c4b1f8840000
,
Jan 29 2018
yanggou: Sorry the bisects are so hard to read, but if you look at this bisect: https://pinpoint-dot-chromeperf.appspot.com/job/14c4b1f8840000 It does repro the drop at your CL, "Do not use soon deprecated v8::ReturnValue::Set." (r528947). Can you take a look?
,
Jan 30 2018
This is very interesting. That CL merely replaces a deprecated API by its successor. I'll revert and verify whether that helps. Then again maybe the benchmark does not track real-world usage? The name sounds a bit like a micro-benchmark...
,
Jan 30 2018
Yep, this is definitely a microbenchmark. +jbroman, the owner, for guidance on how important this regression is to address.
,
Feb 5 2018
,
Feb 5 2018
This has been reverted here last week: https://chromium-review.googlesource.com/c/chromium/src/+/893358 The graph has indeed recovered. Before I close this bug however, I'd like a verdict on how important the micro-benchmark is.
,
Feb 5 2018
It's not super important itself (so if we're progressing other things, it'd be okay to regress slightly here). But this is somewhat a measure of the minimum cost of an API call into Blink, and it'd be nice to not slow them down if we can avoid it.
,
Feb 5 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 16 2018