New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802396 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.7%-35.6% regression in smoothness.top_25_smooth at 528007:528214

Project Member Reported by m...@chromium.org, Jan 16 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 16 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=802396

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=bbf54e583a8ee02c981790f986b628fa156eabb77cbe25fe418ddaef8b3662bb


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus7v2
chromium-rel-mac11-pro
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 16 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/16a75290840000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 17 2018

Cc: briander...@chromium.org khushals...@chromium.org
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16a75290840000

cc: Avoid main thread latency recovery during loading.
By khushalsagar@chromium.org ยท Tue Jan 09 19:25:03 2018
chromium @ 2f9cdf26e68f1fc58a978216b0e4d97eb660a2d3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by m...@chromium.org, Jan 19 2018

Cc: -m...@chromium.org
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12e79764840000
I've started another bisect since the bug seems quite unrelated to the change in #3.

+tdresser, But investigating this, I'm looking at the latency info for the first scroll update event and I see the most increase in the time between Display::DrawAndSwap until when InputLatency::GestureScrollUpdate ends. This is the time we're waiting for a swap ack from the GPU right?
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/148996d8840000
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

Cc: vmi...@chromium.org backer@chromium.org
Owner: backer@chromium.org
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148996d8840000

Make front buffer manipulation NOTREACHED
By backer@chromium.org ยท Tue Jan 09 20:50:39 2018
chromium @ 4d9fb08430a1f94e315dd0ab79c42ae3f998ba99

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

Owner: khushals...@chromium.org
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12e79764840000

cc: Avoid main thread latency recovery during loading.
By khushalsagar@chromium.org ยท Tue Jan 09 19:25:03 2018
chromium @ 2f9cdf26e68f1fc58a978216b0e4d97eb660a2d3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -backer@chromium.org -vmi...@chromium.org
I moved the thread times regression from the bisect in #8 to  issue 804696 . The smoothness regression came back to the main thread latency change.
Cc: tdres...@chromium.org
Oops, +tdresser for realz.

I'm not exactly sure what I'm supposed to look for here. I see 2 traces for Latency::ScrollUpdate. The one in renderer is way lower (18 ms to 11 ms) and the one in the browser increased (2.5 to 4.8) And the most increase seems to be between the Display swap and when the trace ends, which I'm assuming is swap ack. I'm also a bit confused with how this change could have had any impact. It just makes sure we don't skip the second main frame during loading, and it doesn't look it had any impact there. We were never skipping that frame anyway. Tim, any ideas?
Cc: nzolghadr@chromium.org
Re #6, yeah, that should be time spent waiting for the swap ack.

We shouldn't be showing LatencyInfo slices for the renderer. Navid, any idea what's going on?

I'd say the next step is to request full traces, with all disabled by default categories. Could "not skipping the second main frame" result in us doing more rendering work? That might not explain this example fully, but I can see how doing a bit of extra rendering early in page load could block the handling of the first scroll update event.


Hmmm, let me get more tracing with cc to see what's going on. The part that confuses me is that we were not skipping the main frame prior to the change anyway, so its likely something else.
Components: Internals>GPU>Metrics
Status: WontFix (was: Assigned)
Looks like the metric is back close to the pre-regression value (~3ms). I don't think there is anything worth investigating here. There was a scheduler change that triggered this and minor fluctuations are expected.

Sign in to add a comment