The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64646172df767e7d2b8eb7ad80adb45724f30817

commit 64646172df767e7d2b8eb7ad80adb45724f30817
Author: Wez <wez@chromium.org>
Date: Fri Oct 19 18:39:28 2018

Add start & end markers around |str_stack| for use by Crash service.

Crash can locate particular entries in a stack by scanning for start &
end markers with unusual values.  We add start & end markers around the
|str_stack| copy of the LogMessage string, created when we're about to
crash the process due to a FATAL level log message.

Bug: 802393
Change-Id: I8fd462cc515ddbefb8c7b34363eea848171aa776
Reviewed-on: https://chromium-review.googlesource.com/c/1201344
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601236}
[modify] https://crrev.com/64646172df767e7d2b8eb7ad80adb45724f30817/base/logging.cc
[modify] https://crrev.com/64646172df767e7d2b8eb7ad80adb45724f30817/base/logging_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f90d7226adad7dd7f1ce17e41b60228f882c8479

commit f90d7226adad7dd7f1ce17e41b60228f882c8479
Author: Joe Downing <joedow@chromium.org>
Date: Fri Oct 19 21:10:06 2018

Revert "Add start & end markers around |str_stack| for use by Crash service."

This reverts commit 64646172df767e7d2b8eb7ad80adb45724f30817.

Reason for revert: LoggingTest.LogMessageMarkersOnStack is failing on several builders and this test was introduced in this CL:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/72386
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12371

Example error message:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932209218566904752/+/steps/base_unittests/0/logs/LoggingTest.LogMessageMarkersOnStack/0


Original change's description:
> Add start & end markers around |str_stack| for use by Crash service.
> 
> Crash can locate particular entries in a stack by scanning for start &
> end markers with unusual values.  We add start & end markers around the
> |str_stack| copy of the LogMessage string, created when we're about to
> crash the process due to a FATAL level log message.
> 
> Bug: 802393
> Change-Id: I8fd462cc515ddbefb8c7b34363eea848171aa776
> Reviewed-on: https://chromium-review.googlesource.com/c/1201344
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601236}

TBR=ajwong@chromium.org,dcheng@chromium.org,wez@chromium.org

Change-Id: If00343894caa467887191fbb09a4c80233cc94b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 802393
Reviewed-on: https://chromium-review.googlesource.com/c/1292595
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601295}
[modify] https://crrev.com/f90d7226adad7dd7f1ce17e41b60228f882c8479/base/logging.cc
[modify] https://crrev.com/f90d7226adad7dd7f1ce17e41b60228f882c8479/base/logging_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e976b73be0b03a2dea34340d71c1f1ce839c908d

commit e976b73be0b03a2dea34340d71c1f1ce839c908d
Author: Wez <wez@chromium.org>
Date: Sat Oct 20 03:37:31 2018

Reland "Add start & end markers around |str_stack| for use by Crash service."

Crash can locate particular entries in a stack by scanning for start &
end markers with unusual values.  We add start & end markers around the
|str_stack| copy of the LogMessage string, created when we're about to
crash the process due to a FATAL level log message.

This was originally landed with review:
https://chromium-review.googlesource.com/c/1201344
which was reverted because MSan bots (correctly) failed due to the test's
scanning of uninitialized stack memory. Since the test can't avoid doing
that, we simply disable it under both ASan and MSan.

Bug: 802393
Change-Id: Icd87f258aeb9556ab8e68d3e3431e80c01f1d3f0
Reviewed-on: https://chromium-review.googlesource.com/c/1292597
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601399}
[modify] https://crrev.com/e976b73be0b03a2dea34340d71c1f1ce839c908d/base/logging.cc
[modify] https://crrev.com/e976b73be0b03a2dea34340d71c1f1ce839c908d/base/logging_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cf4ff192d2b68f207503ed8e505f21c3729966

commit 20cf4ff192d2b68f207503ed8e505f21c3729966
Author: Wez <wez@chromium.org>
Date: Wed Jan 02 23:11:51 2019

Re-enable LogMessageMarkerOnStack test on Windows.

This test was disabled on Windows in
https://chromium-review.googlesource.com/c/1293670
because of failures on the Windows Debug bots.

The failure cannot be reproduced locally, and we don't have links to
logs from the failed runs, so re-enabling the test to allow us to repro
and diagnose the issue.

Bug:  897735 , 802393
Change-Id: I9086366e7b1f9240674f3b5678810d221b5d01ff
Reviewed-on: https://chromium-review.googlesource.com/c/1393545
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619528}
[modify] https://crrev.com/20cf4ff192d2b68f207503ed8e505f21c3729966/base/logging_unittest.cc