New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802379 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocked on:
issue 805437

Blocking:
issue 776877
issue 804970
issue 808505
issue 858879



Sign in to add a comment

Implement PresentationCallback for GLSurfaceEGL

Project Member Reported by penghuang@chromium.org, Jan 16 2018

Issue description

Implement PresentationCallback for GLSurfaceEGL
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b7dbcbbcdc669bde37b06b12c5b19242f477e9

commit 03b7dbcbbcdc669bde37b06b12c5b19242f477e9
Author: Peng Huang <penghuang@chromium.org>
Date: Thu Jan 18 17:13:58 2018

Move presentation code from GLSurface to GLSurfacePresentationHelper

Move presentation code from GLSurface to GLSurfacePresentationHelper, so
the code could be shared with other GLSurfaces.

Bug:  802379 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifc63b1e27aeee2025bcf44fc539a98b866223932
Reviewed-on: https://chromium-review.googlesource.com/868932
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530176}
[modify] https://crrev.com/03b7dbcbbcdc669bde37b06b12c5b19242f477e9/ui/gl/BUILD.gn
[modify] https://crrev.com/03b7dbcbbcdc669bde37b06b12c5b19242f477e9/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/03b7dbcbbcdc669bde37b06b12c5b19242f477e9/ui/gl/gl_surface_glx.h
[add] https://crrev.com/03b7dbcbbcdc669bde37b06b12c5b19242f477e9/ui/gl/gl_surface_presentation_helper.cc
[add] https://crrev.com/03b7dbcbbcdc669bde37b06b12c5b19242f477e9/ui/gl/gl_surface_presentation_helper.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d42fb1e483509b1a34a851b53b3a950c55d58cfa

commit d42fb1e483509b1a34a851b53b3a950c55d58cfa
Author: Peng Huang <penghuang@chromium.org>
Date: Tue Jan 23 17:39:34 2018

Add VSyncProvider::IsHWClock().

The VSyncProvider::IsHWClock() tells caller the timebase returned from
GetVSyncParameters() was retrived from HW or was sampled in user space.

Bug:  802379 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I07e36e64258b2c4af5417ca1be17560fb69ea243
Reviewed-on: https://chromium-review.googlesource.com/879021
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531272}
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/components/viz/service/display_embedder/software_output_device_mac.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/components/viz/service/display_embedder/software_output_device_mac.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/gpu/ipc/service/gpu_vsync_provider_win.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/gpu/ipc/service/gpu_vsync_provider_win.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gfx/vsync_provider.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gfx/vsync_provider.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_presentation_helper.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_presentation_helper.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/sync_control_vsync_provider.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/sync_control_vsync_provider.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/vsync_provider_win.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/vsync_provider_win.h
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/ozone/platform/drm/gpu/drm_vsync_provider.cc
[modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/ozone/platform/drm/gpu/drm_vsync_provider.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b

commit 2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b
Author: Peng Huang <penghuang@chromium.org>
Date: Tue Jan 23 18:59:02 2018

Supports Presentation in GLSurfaceEGL

Use the GLSurfacePresenterHelper to support presentation
in GLSurfaceEGL.

Bug:  802379 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I296d4bcc0d68256d0173d976a2750999f21ceebd
Reviewed-on: https://chromium-review.googlesource.com/870851
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531291}
[modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_egl.h
[modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_presentation_helper.cc
[modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_presentation_helper.h

Blocking: 804970
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdba2dd2bd4120529c5285d760baff83db9985dd

commit bdba2dd2bd4120529c5285d760baff83db9985dd
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Jan 24 17:52:02 2018

Revert "Supports Presentation in GLSurfaceEGL"

This reverts commit 2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b.

Reason for revert: multiple failures on devices running Android L/M: http://crbug.com/805437

Observed locally on Nexus5 LMY48H that reverting this change makes the crash go away for test org.chromium.chrome.browser.sync.OpenTabsTest#testIncognitoTabGetsInvalidSyncId

Original change's description:
> Supports Presentation in GLSurfaceEGL
> 
> Use the GLSurfacePresenterHelper to support presentation
> in GLSurfaceEGL.
> 
> Bug:  802379 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I296d4bcc0d68256d0173d976a2750999f21ceebd
> Reviewed-on: https://chromium-review.googlesource.com/870851
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531291}

TBR=penghuang@chromium.org,piman@chromium.org

Change-Id: I1119fcc5e25f108c2ee53a127c6431f44b31ecaf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  802379 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/883882
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531597}
[modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_egl.h
[modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_presentation_helper.cc
[modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_presentation_helper.h

Status: Assigned (was: Fixed)
Reopened to track the revert.

Comment 8 by kbr@chromium.org, Jan 25 2018

Blockedon: 805437

Comment 9 by kbr@chromium.org, Jan 25 2018

Cc: bpastene@chromium.org kbr@chromium.org ynovikov@chromium.org
If there is a Nexus 5 trybot we really need to make sure it's running tests that would have caught this failure. It was seen on the chromium.gpu.fyi waterfall breaking the Nexus 5 bot there, and fortunately also broke some tests on the chromium.android waterfall. See  Issue 805236 .

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a752dddf04833007d9c1275af38c3856f36ab457

commit a752dddf04833007d9c1275af38c3856f36ab457
Author: Peng Huang <penghuang@chromium.org>
Date: Fri Jan 26 20:04:37 2018

Disable GL_EXT_disjoint_timer_query for Nexus5

Bug: 805437, 802379 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I574359746c207e0e1078758d1908f0c98450333c
Reviewed-on: https://chromium-review.googlesource.com/886832
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532047}
[modify] https://crrev.com/a752dddf04833007d9c1275af38c3856f36ab457/gpu/config/gpu_driver_bug_list.json

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715e4f97981a55b2983077649f4915125afdd628

commit 715e4f97981a55b2983077649f4915125afdd628
Author: Peng Huang <penghuang@chromium.org>
Date: Wed Jan 31 19:47:38 2018

Supports Presentation in GLSurfaceEGL

Use the GLSurfacePresenterHelper to support presentation
in GLSurfaceEGL.

Bug:  802379 
Change-Id: Ia472918d168abbfdfdde7dd7189cb8a00593af05
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/886981
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533362}
[modify] https://crrev.com/715e4f97981a55b2983077649f4915125afdd628/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/715e4f97981a55b2983077649f4915125afdd628/ui/gl/gl_surface_egl.h

Status: Fixed (was: Assigned)

Comment 13 by kbr@chromium.org, Feb 3 2018

Blocking: 808505
Blocking: 858879

Sign in to add a comment