Implement PresentationCallback for GLSurfaceEGL |
|||||||||
Issue descriptionImplement PresentationCallback for GLSurfaceEGL
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d42fb1e483509b1a34a851b53b3a950c55d58cfa commit d42fb1e483509b1a34a851b53b3a950c55d58cfa Author: Peng Huang <penghuang@chromium.org> Date: Tue Jan 23 17:39:34 2018 Add VSyncProvider::IsHWClock(). The VSyncProvider::IsHWClock() tells caller the timebase returned from GetVSyncParameters() was retrived from HW or was sampled in user space. Bug: 802379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I07e36e64258b2c4af5417ca1be17560fb69ea243 Reviewed-on: https://chromium-review.googlesource.com/879021 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531272} [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/components/viz/service/display_embedder/software_output_device_mac.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/components/viz/service/display_embedder/software_output_device_mac.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/gpu/ipc/service/gpu_vsync_provider_win.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/gpu/ipc/service/gpu_vsync_provider_win.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gfx/vsync_provider.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gfx/vsync_provider.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_glx.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_presentation_helper.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/gl_surface_presentation_helper.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/sync_control_vsync_provider.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/sync_control_vsync_provider.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/vsync_provider_win.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/gl/vsync_provider_win.h [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/ozone/platform/drm/gpu/drm_vsync_provider.cc [modify] https://crrev.com/d42fb1e483509b1a34a851b53b3a950c55d58cfa/ui/ozone/platform/drm/gpu/drm_vsync_provider.h
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b commit 2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b Author: Peng Huang <penghuang@chromium.org> Date: Tue Jan 23 18:59:02 2018 Supports Presentation in GLSurfaceEGL Use the GLSurfacePresenterHelper to support presentation in GLSurfaceEGL. Bug: 802379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I296d4bcc0d68256d0173d976a2750999f21ceebd Reviewed-on: https://chromium-review.googlesource.com/870851 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531291} [modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_egl.h [modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_glx.cc [modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_presentation_helper.cc [modify] https://crrev.com/2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b/ui/gl/gl_surface_presentation_helper.h
,
Jan 23 2018
,
Jan 23 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdba2dd2bd4120529c5285d760baff83db9985dd commit bdba2dd2bd4120529c5285d760baff83db9985dd Author: Egor Pasko <pasko@chromium.org> Date: Wed Jan 24 17:52:02 2018 Revert "Supports Presentation in GLSurfaceEGL" This reverts commit 2adea4d74c2e7cee0228ac74b313ed8b2c6ad61b. Reason for revert: multiple failures on devices running Android L/M: http://crbug.com/805437 Observed locally on Nexus5 LMY48H that reverting this change makes the crash go away for test org.chromium.chrome.browser.sync.OpenTabsTest#testIncognitoTabGetsInvalidSyncId Original change's description: > Supports Presentation in GLSurfaceEGL > > Use the GLSurfacePresenterHelper to support presentation > in GLSurfaceEGL. > > Bug: 802379 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I296d4bcc0d68256d0173d976a2750999f21ceebd > Reviewed-on: https://chromium-review.googlesource.com/870851 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531291} TBR=penghuang@chromium.org,piman@chromium.org Change-Id: I1119fcc5e25f108c2ee53a127c6431f44b31ecaf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/883882 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531597} [modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_egl.h [modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_glx.cc [modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_presentation_helper.cc [modify] https://crrev.com/bdba2dd2bd4120529c5285d760baff83db9985dd/ui/gl/gl_surface_presentation_helper.h
,
Jan 24 2018
Reopened to track the revert.
,
Jan 25 2018
,
Jan 25 2018
If there is a Nexus 5 trybot we really need to make sure it's running tests that would have caught this failure. It was seen on the chromium.gpu.fyi waterfall breaking the Nexus 5 bot there, and fortunately also broke some tests on the chromium.android waterfall. See Issue 805236 .
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a752dddf04833007d9c1275af38c3856f36ab457 commit a752dddf04833007d9c1275af38c3856f36ab457 Author: Peng Huang <penghuang@chromium.org> Date: Fri Jan 26 20:04:37 2018 Disable GL_EXT_disjoint_timer_query for Nexus5 Bug: 805437, 802379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I574359746c207e0e1078758d1908f0c98450333c Reviewed-on: https://chromium-review.googlesource.com/886832 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532047} [modify] https://crrev.com/a752dddf04833007d9c1275af38c3856f36ab457/gpu/config/gpu_driver_bug_list.json
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/715e4f97981a55b2983077649f4915125afdd628 commit 715e4f97981a55b2983077649f4915125afdd628 Author: Peng Huang <penghuang@chromium.org> Date: Wed Jan 31 19:47:38 2018 Supports Presentation in GLSurfaceEGL Use the GLSurfacePresenterHelper to support presentation in GLSurfaceEGL. Bug: 802379 Change-Id: Ia472918d168abbfdfdde7dd7189cb8a00593af05 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/886981 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533362} [modify] https://crrev.com/715e4f97981a55b2983077649f4915125afdd628/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/715e4f97981a55b2983077649f4915125afdd628/ui/gl/gl_surface_egl.h
,
Jan 31 2018
,
Feb 3 2018
,
Jun 29 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 18 2018