New issue
Advanced search Search tips

Issue 802374 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ProfileChooserViewExtensionsTest.InvokeUi_DiceGuest" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 16 2018

Issue description

"ProfileChooserViewExtensionsTest.InvokeUi_DiceGuest" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNQcm9maWxlQ2hvb3NlclZpZXdFeHRlbnNpb25zVGVzdC5JbnZva2VVaV9EaWNlR3Vlc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 2 by kbr@chromium.org, Jan 17 2018

Cc: msarda@chromium.org
 Issue 802919  has been merged into this issue.

Comment 3 by kbr@chromium.org, Jan 17 2018

Owner: msarda@chromium.org
Status: Assigned (was: Untriaged)
Seen in  Issue 802919  as well:
[56919:771:0116/164515.985746:FATAL:mutable_profile_oauth2_token_service_delegate.cc(346)] Check failed: !loading_primary_account_id_.empty() || signin::IsDicePrepareMigrationEnabled().


Also seen on one of my unrelated CLs:
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/629108

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2faea803bed68091e9564cb24711b6f5cf545d95

commit 2faea803bed68091e9564cb24711b6f5cf545d95
Author: Gang Wu <gangwu@chromium.org>
Date: Wed Jan 17 03:03:17 2018

Disable a flaking ProfileChooserViewExtensionsTest.InvokeUi_DiceGuest test

Currently ProfileChooserViewExtensionsTest.InvokeUi_DiceGuest
is flaking, preventing changes from landing. This disables the test while a fix
is investigated.

Bug:  802374 
Change-Id: I3c6c67916e78a0e7113f2de00aa3ae05d4aebe7f
Reviewed-on: https://chromium-review.googlesource.com/868933
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529561}
[modify] https://crrev.com/2faea803bed68091e9564cb24711b6f5cf545d95/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Comment 5 by gangwu@chromium.org, Jan 17 2018

Labels: -Sheriff-Chromium

Comment 6 by msarda@chromium.org, Jan 17 2018

Owner: tangltom@chromium.org
Thomas: It looks like the test you added was flaky, so it got disabled.
Status: WontFix (was: Assigned)
This is not relevant anymore since Dice enabled by default now.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d561872ddb3493627900e67e028d596f2fa8059b

commit d561872ddb3493627900e67e028d596f2fa8059b
Author: Ryan Meier <rameier@chromium.org>
Date: Fri Nov 30 20:26:53 2018

Re-enable two tests in profile_chooser_view_browsertest.cc

Bug:  802374 
Change-Id: I89e01e755d4a5bf4dabda8f93b75eafc7418fc34
Reviewed-on: https://chromium-review.googlesource.com/c/1355613
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612760}
[modify] https://crrev.com/d561872ddb3493627900e67e028d596f2fa8059b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Sign in to add a comment