Fullscreen wpt tests: subframe relies on mainframe activation |
||
Issue descriptionThis no longer works with UserActivationV2: a frame can only utilize activation in itself or in a descendant frame. We have two failing tests with V2: wpt/fullscreen/model/move-to-fullscreen-iframe-manual.html wpt/fullscreen/api/element-request-fullscreen-and-exit-iframe-manual.html Moving the "button" elems into iframes should make both tests pass. However not sure if the automation scripts will find the button inside a frame.
,
Jan 17 2018
Nah, my attempt to move the button into the iframe failed: https://chromium-review.googlesource.com/868323 foolip@: do you see any way to make the automation script (wpt_automation/fullscreen/auto-click.js) work?
,
Jan 26 2018
auto-click.js already tries to monitor for new buttons inside of iframes, but maybe it doesn't work. Can you check if `observe(iframe.contentDocument)` is ever reached, and then if `click(node)` is reached? Could be that it does try to click, but the coordinates are wrong?
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a985dce481877ed571fa72287b202d026622f5b commit 5a985dce481877ed571fa72287b202d026622f5b Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Jun 27 15:25:08 2018 Fix the clicked iframe in two wpt fullscreen tests. With User Activation v2, activating a parent frame doesn't activate its subframes. We fixed these two tests by sending the click to subframes. This needed a workaround in auto-click.js because the mutation observer there in doesn't seem to work when a button element is added to a subframe. Bug: 802371 Change-Id: I786668c87b802565e99ad16223cafc8ac1fd6296 Reviewed-on: https://chromium-review.googlesource.com/868323 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570778} [modify] https://crrev.com/5a985dce481877ed571fa72287b202d026622f5b/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-exit-iframe-manual.html [modify] https://crrev.com/5a985dce481877ed571fa72287b202d026622f5b/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/move-to-fullscreen-iframe-manual.html [modify] https://crrev.com/5a985dce481877ed571fa72287b202d026622f5b/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js
,
Jun 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Jan 16 2018