New issue
Advanced search Search tips

Issue 802368 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clarify AudioHandler::ref/deref messages

Project Member Reported by rtoy@chromium.org, Jan 16 2018 
When DEBUB_AUDIONODE_REFERENCES is enabled, the AudioHandler messages
will print out ref and deref messages.  These are legacy messages.
They should be updated to reflect what ref (connection made) and deref
(disconnection) actually mean.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e9582a9af8a50ba7f79ad43bd6d577c6a9f6e43

commit 0e9582a9af8a50ba7f79ad43bd6d577c6a9f6e43
Author: Raymond Toy <rtoy@chromium.org>
Date: Wed Jan 17 17:59:15 2018

Clarify AudioHandler::ref/deref message

Instead of using ref/deref in the debug messages, use MakeConnection,
and BreakConnectionWithLock, respectively, to match better what is
actually happening.

(The old ref/deref messages referred to the connect ref count
changing, and the methods were called ref/deref, but not anymore.)

No behavioral changes because these are only enabled when
DEBUB_AUDIONODE_REFERENCES is set.

Bug:  802368 
Change-Id: I4a6fe0973acd39f553175563799c0d36533a8fe0
Reviewed-on: https://chromium-review.googlesource.com/868273
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529799}
[modify] https://crrev.com/0e9582a9af8a50ba7f79ad43bd6d577c6a9f6e43/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Comment 2 by rtoy@chromium.org, Jan 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment