New issue
Advanced search Search tips

Issue 802352 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocking:
issue 714618



Sign in to add a comment

Refactor PasswordManagerImpl in the settings page

Project Member Reported by cfroussios@chromium.org, Jan 16 2018

Issue description

The PasswordManager abstraction from
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
deserves it's own place, e.g. password_manager_proxy.js
 

Comment 1 by kolos@chromium.org, Jan 26 2018

Blocking: 714618
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/052f2656298157a6f5bff8e0219424662b97700d

commit 052f2656298157a6f5bff8e0219424662b97700d
Author: Christos Froussios <cfroussios@chromium.org>
Date: Mon Apr 09 20:30:23 2018

[Password Manager] Move PasswordManager proxy to a separate file

The new PasswordManagerProxy class is an abstraction over
chrome.passwordsPrivate, used to test the passsword settings page
bahaviour.

Bug:  802352 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I12fba7cfdb4405477adf49ccb64f64d4b30a3d93
Reviewed-on: https://chromium-review.googlesource.com/883621
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549259}
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[add] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/password_manager_proxy.html
[add] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/password_manager_proxy.js
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/052f2656298157a6f5bff8e0219424662b97700d/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Assigned)

Sign in to add a comment