New issue
Advanced search Search tips

Issue 802346 link

Starred by 2 users
Status: Fixed
Owner:
michaeldo@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Install plugin placeholder over content in all frames

Project Member Reported by michaeldo@chromium.org, Jan 16 2018 
The plugin placeholder is only installed over significant flash content in the main document frame.

Content should be covered in all frames.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9c27c4338cb1b8ad21a168d905cc4c964e857fb

commit c9c27c4338cb1b8ad21a168d905cc4c964e857fb
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Jan 17 23:04:19 2018

Add placeholder for unsupported plugins in all frames.

Bug:  802346 , 546350
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c0ecc26cd412daff30d29a4309dd43228872301
Reviewed-on: https://chromium-review.googlesource.com/868328
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529938}
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/BUILD.gn
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/BUILD.gn
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/common_js_unittest.mm
[delete] https://crrev.com/f99b788b80d018e18b543314afbeaea9c99304ea/ios/web/web_state/js/crw_js_plugin_placeholder_manager.h
[delete] https://crrev.com/f99b788b80d018e18b543314afbeaea9c99304ea/ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/page_script_util.h
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/page_script_util.mm
[add] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/plugin_placeholder_js_unittest.mm
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/resources/common.js
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/resources/legacy.js
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/js/resources/plugin_placeholder.js
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/c9c27c4338cb1b8ad21a168d905cc4c964e857fb/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

Comment 2 by michaeldo@chromium.org, Jan 17 2018

Status: Fixed (was: Started)
Summary: Install plugin placeholder over content in all frames (was: Install plugin placeholder over content in any frame)
►

Sign in to add a comment