Cleanup plugin_placeholder.js |
|||
Issue descriptionAll plugin JavaScript logic has moved into this single JavaScript file. The following cleanup tasks should be reviewed: - Return plugin elements instead of storing them inside __gCrWeb['placeholderTargetPlugins'] - Remove the exposed __gCrWeb['plugin'] namespace - Make all functions private.
,
Feb 2 2018
Yes, working on this now.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6bbb641a08e63991107abcf4fdafc59b8cf2361 commit b6bbb641a08e63991107abcf4fdafc59b8cf2361 Author: Mike Dougherty <michaeldo@chromium.org> Date: Fri Feb 02 22:19:41 2018 Cleanup plugin_placeholder.js Remove exposed plugin API since all logic is now contained to a single file and it runs immediately upon injection. The unittests are now obsolete because no API is exposed. However, all previous unittest scenarios are covered by the PluginPlaceholderTestCase EarlGrey tests. Bug: 802344 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2f31af1fe9fa4f94f678064fe2a8cc316b837757 Reviewed-on: https://chromium-review.googlesource.com/899914 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534169} [modify] https://crrev.com/b6bbb641a08e63991107abcf4fdafc59b8cf2361/ios/web/BUILD.gn [delete] https://crrev.com/63612d32bdf79162b3aadf5b80ee61e36624fd14/ios/web/web_state/js/plugin_placeholder_js_unittest.mm [modify] https://crrev.com/b6bbb641a08e63991107abcf4fdafc59b8cf2361/ios/web/web_state/js/resources/plugin_placeholder.js
,
Feb 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eugene...@chromium.org
, Jan 30 2018