New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 802309 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Downloads-Blocking-Bugs


Sign in to add a comment

[Downloads] Support delegate method to intercept and/or block a download

Project Member Reported by dtrainor@chromium.org, Jan 16 2018

Issue description

Add a method to the DownloadManagerDelegate to allow intercepting or blocking a download.  This can be a synchronous call and will eventually replace the download throttle for offline pages.
 
Cc: dim...@chromium.org chili@chromium.org
+dimich@ and +chili@ for fyi.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8

commit cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Feb 15 14:21:23 2018

Downloads : Added a delegate method for intercepting downloads

This method will be useful for other systems that want to handle
download themselves, especially offline pages, which can intercept
the download here onwards based on mime_type.

Bug:  802309 
Change-Id: I5b7bfd7840334979d082c6afa983668ceb020968
Reviewed-on: https://chromium-review.googlesource.com/879548
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537008}
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/chrome/browser/download/chrome_download_manager_delegate.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_create_info.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_request_core.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_request_core.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/download_response_handler.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/url_downloader.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/browser/download/url_downloader.h
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/public/browser/download_manager_delegate.cc
[modify] https://crrev.com/cba5d24ae30bd4fd8199746ec3d63e91a4a1f4c8/content/public/browser/download_manager_delegate.h

Status: Fixed (was: Assigned)

Sign in to add a comment